Skip to content

fix(lint): annotate Python daemon Command::new sites #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 1 commit into from
May 30, 2026
Merged

fix(lint): annotate Python daemon Command::new sites #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/fbuild-python/src/daemon.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ impl Daemon {
// (FastLED/fbuild#275) so a venv install never gets shadowed by a
// stale user-level daemon on PATH.
let mut cmd = match daemon_spawn_target() {
// allow-direct-spawn: daemon must outlive the Python interpreter.
Some(path) => std::process::Command::new(path),
// allow-direct-spawn: daemon must outlive the Python interpreter.
None => std::process::Command::new(DAEMON_BIN_NAME),
};
if fbuild_paths::is_dev_mode() {
Expand Down Expand Up @@ -244,7 +246,9 @@ impl AsyncDaemon {
// from inside this async block.
// allow-direct-spawn: daemon must outlive the Python interpreter.
let mut cmd = match spawn_target {
// allow-direct-spawn: daemon must outlive the Python interpreter.
Some(path) => std::process::Command::new(path),
// allow-direct-spawn: daemon must outlive the Python interpreter.
None => std::process::Command::new(DAEMON_BIN_NAME),
};
if dev_mode {
Expand Down
Loading