Bit more testing

Author: cowtowncoder

src/main/java/tools/jackson/dataformat/xml/ser/DTD.java

@@ -22,7 +22,7 @@ static String _emptyToNull(String str) {
 
     static String _nonEmptyNonNull(String prop, String str) {
         if (str == null || str.isEmpty()) {
-            throw new IllegalArgumentException("Illegal argument for `%s`: must be non-empty String"
+            throw new IllegalArgumentException("Illegal argument for '%s': must be non-empty String"
                     .formatted(prop));
         }
         return str;

src/test/java/tools/jackson/dataformat/xml/ser/XmlGeneratorInitializerTest.java

@@ -7,6 +7,7 @@
 import tools.jackson.dataformat.xml.XmlTestUtil;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.fail;
 
 public class XmlGeneratorInitializerTest extends XmlTestUtil
 {
@@ -18,7 +19,7 @@ public void testDTDWithPublicId() throws Exception
     {
         ObjectWriter w = MAPPER.writer().with(
                 new XmlGeneratorInitializer()
-                        .withDTD("StringBean", "system", "http://foo.bar", null));
+                        .withDTD("StringBean", "system", "http://foo.bar", ""));
         assertEquals(a2q("<!DOCTYPE StringBean PUBLIC 'http://foo.bar' 'system'>"
                 +"<StringBean><text>test</text></StringBean>"),
                 w.writeValueAsString(new StringBean("test")));
@@ -29,7 +30,7 @@ public void testDTDWithSystemIdOnly() throws Exception
     {
         ObjectWriter w = MAPPER.writer().with(
                 new XmlGeneratorInitializer()
-                        .withDTD("StringBean", "system", null, null));
+                        .withDTD("StringBean", "system", "", null));
         assertEquals(a2q("<!DOCTYPE StringBean SYSTEM 'system'>"
                 +"<StringBean><text>test</text></StringBean>"),
                 w.writeValueAsString(new StringBean("test")));
@@ -46,4 +47,19 @@ public void testDTDWithInternalSubset() throws Exception
                 +"<StringBean><text>test</text></StringBean>"),
                 w.writeValueAsString(new StringBean("test")));
     }
+
+    @Test
+    public void testDTDInvalidNoRoot() throws Exception
+    {
+        try {
+            /*ObjectWriter w =*/ MAPPER.writer().with(
+                new XmlGeneratorInitializer()
+                    .withDTD("", null, null, null));
+            fail("Should not pass");
+        } catch (IllegalArgumentException e) {
+            verifyException(e, "Illegal argument for 'rootName': must be");
+        }
+    }
+
+    // Other tests
 }