Minor improvements

Author: cowtowncoder

src/main/java/tools/jackson/dataformat/xml/ser/ToXmlGenerator.java

@@ -100,6 +100,8 @@ public class ToXmlGenerator
      */
 
     /**
+     * Document Type Declaration to write, if any; {@code null} if none.
+     *
      * @since 3.2
      */
     protected DTD _dtd;

src/main/java/tools/jackson/dataformat/xml/ser/XmlGeneratorInitializer.java

@@ -29,13 +29,13 @@ public void initialize(SerializationConfig config, JsonGenerator g) throws Jacks
         }
     }
 
-    public XmlGeneratorInitializer withDTD(String rootName,
+    public XmlGeneratorInitializer setDTD(String rootName,
             String systemId, String publicId,
             String internalSubset) {
-        return withDTD(new DTD(rootName, systemId, publicId, internalSubset));
+        return setDTD(new DTD(rootName, systemId, publicId, internalSubset));
     }
 
-    public XmlGeneratorInitializer withDTD(DTD dtd) {
+    public XmlGeneratorInitializer setDTD(DTD dtd) {
         _dtd = dtd;
         return this;
     }

src/test/java/tools/jackson/dataformat/xml/ser/XmlGeneratorInitializerTest.java

@@ -19,7 +19,7 @@ public void testDTDWithPublicId() throws Exception
     {
         ObjectWriter w = MAPPER.writer().with(
                 new XmlGeneratorInitializer()
-                        .withDTD("StringBean", "system", "http://foo.bar", ""));
+                        .setDTD("StringBean", "system", "http://foo.bar", ""));
         assertEquals(a2q("<!DOCTYPE StringBean PUBLIC 'http://foo.bar' 'system'>"
                 +"<StringBean><text>test</text></StringBean>"),
                 w.writeValueAsString(new StringBean("test")));
@@ -30,7 +30,7 @@ public void testDTDWithSystemIdOnly() throws Exception
     {
         ObjectWriter w = MAPPER.writer().with(
                 new XmlGeneratorInitializer()
-                        .withDTD("StringBean", "system", "", null));
+                        .setDTD("StringBean", "system", "", null));
         assertEquals(a2q("<!DOCTYPE StringBean SYSTEM 'system'>"
                 +"<StringBean><text>test</text></StringBean>"),
                 w.writeValueAsString(new StringBean("test")));
@@ -41,7 +41,7 @@ public void testDTDWithInternalSubset() throws Exception
     {
         ObjectWriter w = MAPPER.writer().with(
                 new XmlGeneratorInitializer()
-                        .withDTD("StringBean", "system", "http://foo.bar", "<!ELEMENT root (#PCDATA)>"));
+                        .setDTD("StringBean", "system", "http://foo.bar", "<!ELEMENT root (#PCDATA)>"));
         assertEquals(a2q("<!DOCTYPE StringBean PUBLIC 'http://foo.bar' 'system' "
                 +"[<!ELEMENT root (#PCDATA)>]>"
                 +"<StringBean><text>test</text></StringBean>"),
@@ -54,7 +54,7 @@ public void testDTDInvalidNoRoot() throws Exception
         try {
             /*ObjectWriter w =*/ MAPPER.writer().with(
                 new XmlGeneratorInitializer()
-                    .withDTD("", null, null, null));
+                    .setDTD("", null, null, null));
             fail("Should not pass");
         } catch (IllegalArgumentException e) {
             verifyException(e, "Illegal argument for 'rootName': must be");