Mark #248 as fixed; add regression test (#823)

Author: cowtowncoder

release-notes/CREDITS

@@ -39,6 +39,11 @@ Christopher McVay (@mcvayc)
  * Fixed #306: Can not use `@JacksonXmlText` for Creator property (creator parameter)
   (3.2.0)
 
+Tobias M (@lightbringer)
+ * Reported #248: `@JacksonXmlProperty` with attributes raises an exception
+   when used with `@JsonIdentityInfo`
+  (3.2.0)
+
 Eduard Wirch (@ewirch)
  * Reported #306: Can not use `@JacksonXmlText` for Creator property (creator parameter)
   (3.2.0)

release-notes/VERSION

@@ -18,6 +18,10 @@ Version: 3.x (for earlier see VERSION-2.x)
 #192: Two wrapped lists with items of same name conflict
  (reported by @TeemuStenhammar)
  (fix by @cowtowncoder, w/ Claude code)
+#248: `@JacksonXmlProperty` with attributes raises an exception when used
+  with `@JsonIdentityInfo`
+ (reported by Tobias M)
+ (fix by @cowtowncoder, w/ Claude code)
 #299: `@JsonUnwrapped` with a `@JacksonXmlElementWrapper(useWrapping=false)`
   on a collection fails reading from XML
  (reported by @jmsjr)

src/test/java/tools/jackson/dataformat/xml/lists/WrappedListsWithSameName192Test.java

@@ -0,0 +1,46 @@
+package tools.jackson.dataformat.xml.lists;
+
+import java.util.List;
+
+import org.junit.jupiter.api.Test;
+
+import tools.jackson.dataformat.xml.XmlMapper;
+import tools.jackson.dataformat.xml.XmlTestUtil;
+import tools.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper;
+import tools.jackson.dataformat.xml.annotation.JacksonXmlProperty;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+// [dataformat-xml#192]: Two wrapped lists with items of same name
+public class WrappedListsWithSameName192Test extends XmlTestUtil
+{
+    static class TwoLists {
+        @JacksonXmlElementWrapper(localName = "ones")
+        @JacksonXmlProperty(localName = "name")
+        public List<String> ones;
+
+        @JacksonXmlElementWrapper(localName = "twos")
+        @JacksonXmlProperty(localName = "name")
+        public List<String> twos;
+    }
+
+    private final XmlMapper MAPPER = newMapper();
+
+    @Test
+    public void testTwoWrappedListsWithSameItemName() throws Exception
+    {
+        final String xml =
+                "<TwoLists>"
+                + "<ones><name>one1</name><name>one2</name></ones>"
+                + "<twos><name>two1</name><name>two2</name></twos>"
+                + "</TwoLists>";
+        TwoLists result = MAPPER.readValue(xml, TwoLists.class);
+        assertNotNull(result);
+        assertEquals(2, result.ones.size());
+        assertEquals("one1", result.ones.get(0));
+        assertEquals("one2", result.ones.get(1));
+        assertEquals(2, result.twos.size());
+        assertEquals("two1", result.twos.get(0));
+        assertEquals("two2", result.twos.get(1));
+    }
+}

src/test/java/tools/jackson/dataformat/xml/misc/ObjectIdWithAttribute248Test.java

@@ -0,0 +1,66 @@
+package tools.jackson.dataformat.xml.misc;
+
+import org.junit.jupiter.api.Test;
+
+import com.fasterxml.jackson.annotation.JsonIdentityInfo;
+import com.fasterxml.jackson.annotation.ObjectIdGenerators;
+
+import tools.jackson.dataformat.xml.XmlMapper;
+import tools.jackson.dataformat.xml.XmlTestUtil;
+import tools.jackson.dataformat.xml.annotation.JacksonXmlProperty;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+// [dataformat-xml#248]: @JacksonXmlProperty(isAttribute=true) with @JsonIdentityInfo
+//  throws "Trying to write an attribute when there is no open start element"
+public class ObjectIdWithAttribute248Test extends XmlTestUtil
+{
+    @JsonIdentityInfo(generator = ObjectIdGenerators.PropertyGenerator.class, property = "name")
+    static class NodeA {
+        @JacksonXmlProperty(isAttribute = true)
+        public String name;
+
+        public NodeB ref;
+
+        public NodeA() { }
+        public NodeA(String name) { this.name = name; }
+    }
+
+    static class NodeB {
+        public NodeA ref;
+
+        public NodeB() { }
+        public NodeB(NodeA a) { this.ref = a; }
+    }
+
+    private final XmlMapper MAPPER = newMapper();
+
+    @Test
+    public void testSerializeAttributeWithIdentityInfo() throws Exception
+    {
+        NodeA a = new NodeA("test");
+        NodeB b = new NodeB(a);
+        a.ref = b;
+
+        String xml = MAPPER.writeValueAsString(a);
+        assertNotNull(xml);
+        assertTrue(xml.contains("name=\"test\""),
+                "Expected 'name' as XML attribute, got: " + xml);
+    }
+
+    @Test
+    public void testRoundTripAttributeWithIdentityInfo() throws Exception
+    {
+        NodeA a = new NodeA("test");
+        NodeB b = new NodeB(a);
+        a.ref = b;
+
+        String xml = MAPPER.writeValueAsString(a);
+        NodeA result = MAPPER.readValue(xml, NodeA.class);
+
+        assertNotNull(result);
+        assertEquals("test", result.name);
+        assertNotNull(result.ref);
+        assertSame(result, result.ref.ref);
+    }
+}