Minor clean up of pr

Author: cowtowncoder

release-notes/VERSION

@@ -84,6 +84,9 @@ Version: 3.x (for earlier see VERSION-2.x)
  (fix by @cowtowncoder, w/ Claude code)
 #541: Allow specifying URI of the default namespace for root element
  (fix by @cowtowncoder, w/ Claude code)
+#556: `XmlMapper` does not support multi-dimensional arrays
+ (reported by @schwarfl)
+ (fix by @cowtowncoder, w/ Claude code)
 #561: Deserializing empty timestamp fields to `null` value doesn't
   work (instead becomes "empty", Epoch time)
  (reported by @silvestr85)

src/main/java/tools/jackson/dataformat/xml/XmlWriteFeature.java

@@ -110,22 +110,24 @@ public enum XmlWriteFeature implements FormatFeature
 
     /**
      * Feature that determines whether attempt to serialize a directly nested
-     * array, {@link java.util.Collection} or {@link java.util.Map} (i.e. an
-     * array/Collection/Map whose immediate parent is also an array/Collection
+     * array or {@link java.util.Collection} (i.e. an
+     * array/Collection whose immediate parent is also an array/Collection
      * — without an intermediate POJO) should fail with an exception (true)
      * or be allowed (false) — knowing that, when allowed, the resulting XML
      * cannot represent the nested structure and the inner dimension will be
-     * silently flattened into the outer one.
+     * silently flattened into the outer one, nor can it be deserialized back.
      *<p>
      * "Natural-style" XML has no canonical representation for an unnamed
      * nested array, so a clean round-trip is not possible without an
      * intermediate POJO wrapper.
      *<p>
      * Default setting is {@code true} (enabled): nested arrays cause an
-     * exception. Disabling restores the legacy Jackson 2.x behavior of
+     * exception. Disabling restores the legacy behavior of
      * silently flattening dimensions.
      *<p>
      * See <a href="https://github.com/FasterXML/jackson-dataformat-xml/issues/556">#556</a>.
+     *
+     * @since 3.2
      */
     FAIL_ON_NESTED_ARRAYS(true),
     ;

src/main/java/tools/jackson/dataformat/xml/ser/ToXmlGenerator.java

@@ -672,14 +672,16 @@ public JsonGenerator writeStartArray(Object currValue) throws JacksonException
         if (_xmlPrettyPrinter != null) {
             _xmlPrettyPrinter.writeStartArray(this);
         } else {
-            // nothing to do here; no-operation
+            // nothing to do here; no-op
         }
         return this;
     }
 
     // [dataformat-xml#556]: nested arrays/Collections/Maps cannot be expressed
     // in natural-style XML without an intermediate POJO. Fail fast (when the
     // feature is enabled) instead of silently flattening dimensions.
+    //
+    // @since 3.2
     private void _verifyNotNestedArray() throws JacksonException
     {
         if (_streamWriteContext.inArray()

…rmat/xml/tofix/MultidimArray556Test.java …format/xml/ser/MultidimArray556Test.javasrc/test/java/tools/jackson/dataformat/xml/tofix/MultidimArray556Test.java renamed to src/test/java/tools/jackson/dataformat/xml/ser/MultidimArray556Test.java src/test/java/tools/jackson/dataformat/xml/tofix/MultidimArray556Test.java renamed to src/test/java/tools/jackson/dataformat/xml/ser/MultidimArray556Test.java

@@ -1,4 +1,4 @@
-package tools.jackson.dataformat.xml.tofix;
+package tools.jackson.dataformat.xml.ser;
 
 import java.util.Arrays;
 import java.util.List;
@@ -9,7 +9,6 @@
 import tools.jackson.dataformat.xml.XmlMapper;
 import tools.jackson.dataformat.xml.XmlTestUtil;
 import tools.jackson.dataformat.xml.XmlWriteFeature;
-import tools.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -64,6 +63,7 @@ public void testLegacyFlatteningWhenFeatureDisabled() throws Exception
     // Eventual goal: a 2D array should round-trip with proper nesting.
     // Currently fails (fail-fast above); annotation inverts pass/fail so this
     // entry tracks the unsupported-but-desired behavior.
+    /*
     @JacksonTestFailureExpected
     @Test
     public void test2DArrayRoundTrip() throws Exception
@@ -75,4 +75,5 @@ public void test2DArrayRoundTrip() throws Exception
         assertEquals(input[0][0], result[0][0]);
         assertEquals(input[1][0], result[1][0]);
     }
+    */
 }