Clarify TOML array table comment#682
Merged
Merged
Conversation
Co-Authored-By: multicode <multicode@yawk.at>
There was a problem hiding this comment.
Pull request overview
Updates an internal comment in TomlParser to more precisely describe how the parser traverses arrays-of-tables when parsing table headers, without changing runtime behavior. This aligns the documentation with the actual implementation (which rejects dotted-key assignments into arrays-of-tables).
Changes:
- Refines the array-of-tables traversal comment to explicitly scope the “broad” interpretation to table headers.
- Removes the stale claim that simple dotted keys can extend arrays-of-tables.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Merging without review since this is just a comment change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
JAVA_HOME=/usr/lib/jvm/java-21-openjdk MAVEN_USER_HOME=/home/opc/dev/agent-work/toml329/.m2-jackson ./mvnw -pl toml -am test -qgit diff --check