Skip to content

Clarify TOML array table comment#682

Merged
yawkat merged 1 commit into
3.xfrom
fix-toml-array-table-comment
May 27, 2026
Merged

Clarify TOML array table comment#682
yawkat merged 1 commit into
3.xfrom
fix-toml-array-table-comment

Conversation

@yawkat

@yawkat yawkat commented May 27, 2026

Copy link
Copy Markdown
Member

Summary

  • clarify the TOML parser comment for array-of-tables traversal
  • remove the stale claim that simple dotted-key assignments into arrays of tables are accepted
  • leave parser behavior unchanged

Verification

  • JAVA_HOME=/usr/lib/jvm/java-21-openjdk MAVEN_USER_HOME=/home/opc/dev/agent-work/toml329/.m2-jackson ./mvnw -pl toml -am test -q
  • git diff --check

Co-Authored-By: multicode <multicode@yawk.at>
@github-actions

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 70.85% 📈 +0.000%
Branches branches 65.52% 📈 +0.000%

Coverage data generated from JaCoCo test results

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates an internal comment in TomlParser to more precisely describe how the parser traverses arrays-of-tables when parsing table headers, without changing runtime behavior. This aligns the documentation with the actual implementation (which rejects dotted-key assignments into arrays-of-tables).

Changes:

  • Refines the array-of-tables traversal comment to explicitly scope the “broad” interpretation to table headers.
  • Removes the stale claim that simple dotted keys can extend arrays-of-tables.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yawkat

yawkat commented May 27, 2026

Copy link
Copy Markdown
Member Author

Merging without review since this is just a comment change

@yawkat yawkat merged commit cb9d52b into 3.x May 27, 2026
5 checks passed
@yawkat yawkat deleted the fix-toml-array-table-comment branch May 27, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants