Skip to content

Clarify TOML array table comment #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yawkat merged 1 commit into from
May 27, 2026
Merged

Clarify TOML array table comment #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions toml/src/main/java/tools/jackson/dataformat/toml/TomlParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,8 @@ private FieldRef parseAndEnterKey(
/* "Any reference to an array of tables points to the most recently defined table element of the array.
* This allows you to define sub-tables, and even sub-arrays of tables, inside the most recent table."
*
* I interpret this somewhat broadly: I accept such references even if there were unrelated tables
* in between, and I accept them for simple dotted keys as well (not just for tables). These cases don't
* seem to be covered by the specification.
* I interpret this somewhat broadly for table headers: I accept such references even if there were
* unrelated tables in between. This case doesn't seem to be covered by the specification.
*/
TomlArrayNode array = (TomlArrayNode) existing;
if (array.closed) {
Expand Down