Skip to content

Use toml-test-for-java for TOML compliance tests#684

Merged
cowtowncoder merged 1 commit into
3.xfrom
use-toml-test-for-java-683
Jun 3, 2026
Merged

Use toml-test-for-java for TOML compliance tests#684
cowtowncoder merged 1 commit into
3.xfrom
use-toml-test-for-java-683

Conversation

@yawkat

@yawkat yawkat commented Jun 3, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the external toml-test checkout workflow with the published toml-test-for-java test artifact
  • run valid/invalid TOML 1.0 corpus cases directly from embedded TomlTestSuite fixtures
  • remove the dedicated TOML compliance workflow now that the default Maven verify run covers these tests

Verification

  • Confirmed at.yawk.toml.test:toml-test-for-java:0.1.0-2.2.0 resolves from Maven Central
  • Ran ./mvnw -B -q -ff -ntp -pl toml -Dtest=ComplianceValidTest,ComplianceInvalidTest -Dmaven.repo.local=/home/opc/dev/agent-work/jackson-text683/.m2-public-check/repository clean test with a fresh local Maven repository
  • Ran git diff --check

Resolves #683

Co-Authored-By: multicode <multicode@yawk.at>
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 71.20% 📈 +0.350%
Branches branches 65.83% 📈 +0.310%

Coverage data generated from JaCoCo test results

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request streamlines TOML 1.0 compliance testing by switching from an external toml-test repository checkout to the published toml-test-for-java artifact, allowing the compliance suite to run as part of the normal Maven verify build.

Changes:

  • Updated TOML compliance tests to use at.yawk.toml.test.TomlTestSuite fixtures (TomlTestCase) instead of filesystem-based corpus inputs.
  • Added the toml-test-for-java test dependency and JPMS test-module requirement.
  • Removed the dedicated GitHub Actions TOML compliance workflow now that ./mvnw verify covers these tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
toml/src/test/java/tools/jackson/dataformat/toml/ComplianceValidTest.java Runs valid TOML 1.0 corpus cases via TomlTestSuite#validToml100 and parses expected JSON directly from the embedded fixture.
toml/src/test/java/tools/jackson/dataformat/toml/ComplianceInvalidTest.java Runs invalid TOML 1.0 corpus cases via TomlTestSuite#invalidToml100 and asserts parsing failures from embedded TOML bytes.
toml/src/test/java/module-info.java Adds the test-module requirement for at.yawk.toml.test.
toml/pom.xml Adds the at.yawk.toml.test:toml-test-for-java test-scoped dependency.
.github/workflows/toml-compliance.yml Removes the standalone compliance workflow in favor of default CI running verify.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cowtowncoder cowtowncoder merged commit 94d9f67 into 3.x Jun 3, 2026
4 checks passed
@cowtowncoder cowtowncoder deleted the use-toml-test-for-java-683 branch June 3, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use toml-test-for-java for toml spec tests

3 participants