Use toml-test-for-java for TOML compliance tests#684
Merged
Conversation
Co-Authored-By: multicode <multicode@yawk.at>
There was a problem hiding this comment.
Pull request overview
This pull request streamlines TOML 1.0 compliance testing by switching from an external toml-test repository checkout to the published toml-test-for-java artifact, allowing the compliance suite to run as part of the normal Maven verify build.
Changes:
- Updated TOML compliance tests to use
at.yawk.toml.test.TomlTestSuitefixtures (TomlTestCase) instead of filesystem-based corpus inputs. - Added the
toml-test-for-javatest dependency and JPMS test-module requirement. - Removed the dedicated GitHub Actions TOML compliance workflow now that
./mvnw verifycovers these tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| toml/src/test/java/tools/jackson/dataformat/toml/ComplianceValidTest.java | Runs valid TOML 1.0 corpus cases via TomlTestSuite#validToml100 and parses expected JSON directly from the embedded fixture. |
| toml/src/test/java/tools/jackson/dataformat/toml/ComplianceInvalidTest.java | Runs invalid TOML 1.0 corpus cases via TomlTestSuite#invalidToml100 and asserts parsing failures from embedded TOML bytes. |
| toml/src/test/java/module-info.java | Adds the test-module requirement for at.yawk.toml.test. |
| toml/pom.xml | Adds the at.yawk.toml.test:toml-test-for-java test-scoped dependency. |
| .github/workflows/toml-compliance.yml | Removes the standalone compliance workflow in favor of default CI running verify. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cowtowncoder
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toml-testcheckout workflow with the publishedtoml-test-for-javatest artifactTomlTestSuitefixturesverifyrun covers these testsVerification
at.yawk.toml.test:toml-test-for-java:0.1.0-2.2.0resolves from Maven Central./mvnw -B -q -ff -ntp -pl toml -Dtest=ComplianceValidTest,ComplianceInvalidTest -Dmaven.repo.local=/home/opc/dev/agent-work/jackson-text683/.m2-public-check/repository clean testwith a fresh local Maven repositorygit diff --checkResolves #683