Use toml-test expected document validator#688
Merged
Conversation
Co-Authored-By: multicode <multicode@yawk.at>
Co-Authored-By: multicode <multicode@yawk.at>
There was a problem hiding this comment.
Pull request overview
This PR updates the TOML compliance “valid corpus” test harness to rely on toml-test-for-java’s expected-document validator rather than maintaining custom JSON-to-Jackson-node mapping and semantic comparison logic in this repo.
Changes:
- Replace custom expected-JSON mapping + semantic-equality checks with
TomlExpectedDocumentValidator-based validation. - Add a Jackson-specific validator adapter for parsing expected JSON and validating Java Time values.
- Bump
toml-test-for-javatest dependency from0.1.0-2.2.0to0.2.0-2.2.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| toml/src/test/java/tools/jackson/dataformat/toml/ComplianceValidTest.java | Switches compliance validation to TomlExpectedDocumentValidator and adds a Jackson adapter for expected JSON + Java Time comparisons. |
| toml/pom.xml | Updates the toml-test-for-java test dependency to a newer version that provides the expected-document validator harness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cowtowncoder
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For verifying expected parsing results, I've added a checker harness to toml-test-for-java.