Skip to content

Use toml-test expected document validator#688

Merged
cowtowncoder merged 2 commits into
3.xfrom
toml-expected-document-validator
Jun 4, 2026
Merged

Use toml-test expected document validator#688
cowtowncoder merged 2 commits into
3.xfrom
toml-expected-document-validator

Conversation

@yawkat

@yawkat yawkat commented Jun 4, 2026

Copy link
Copy Markdown
Member

For verifying expected parsing results, I've added a checker harness to toml-test-for-java.

yawkat and others added 2 commits June 4, 2026 10:00
Co-Authored-By: multicode <multicode@yawk.at>
Co-Authored-By: multicode <multicode@yawk.at>
@yawkat yawkat requested review from Copilot and cowtowncoder June 4, 2026 10:07
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 71.28% 📈 +0.000%
Branches branches 65.95% 📈 +0.000%

Coverage data generated from JaCoCo test results

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the TOML compliance “valid corpus” test harness to rely on toml-test-for-java’s expected-document validator rather than maintaining custom JSON-to-Jackson-node mapping and semantic comparison logic in this repo.

Changes:

  • Replace custom expected-JSON mapping + semantic-equality checks with TomlExpectedDocumentValidator-based validation.
  • Add a Jackson-specific validator adapter for parsing expected JSON and validating Java Time values.
  • Bump toml-test-for-java test dependency from 0.1.0-2.2.0 to 0.2.0-2.2.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
toml/src/test/java/tools/jackson/dataformat/toml/ComplianceValidTest.java Switches compliance validation to TomlExpectedDocumentValidator and adds a Jackson adapter for expected JSON + Java Time comparisons.
toml/pom.xml Updates the toml-test-for-java test dependency to a newer version that provides the expected-document validator harness.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cowtowncoder cowtowncoder added the TOML Issue related to TOML format backend label Jun 4, 2026
@cowtowncoder cowtowncoder merged commit bb74ff2 into 3.x Jun 4, 2026
4 checks passed
@cowtowncoder cowtowncoder deleted the toml-expected-document-validator branch June 4, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TOML Issue related to TOML format backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants