remove scala-java8-compat test dependency

Author: pjfanning

build.sbt

@@ -119,7 +119,6 @@ else
   )
 
 libraryDependencies ++= jacksonDependencies ++ Seq(
-  "org.scala-lang.modules" %% "scala-java8-compat" % "1.0.2" % Test,
   "javax.ws.rs" % "javax.ws.rs-api" % "2.1.1" % Test,
   "io.swagger" % "swagger-core" % "1.6.8" % Test,
   "org.scalatest" %% "scalatest" % "3.2.20" % Test

src/test/scala/tools/jackson/module/scala/deser/CaseObjectDeserializerTest.scala

@@ -8,8 +8,6 @@ import tools.jackson.databind.json.JsonMapper
 import tools.jackson.module.scala.{ClassTagExtensions, DefaultScalaModule}
 import tools.jackson.module.scala.introspect.ScalaAnnotationIntrospectorModule
 
-import scala.compat.java8.FunctionConverters.asJavaUnaryOperator
-
 object CaseObjectDeserializerTest {
   case object TestObject
 
@@ -51,11 +49,11 @@ class CaseObjectDeserializerTest extends DeserializerTest {
 
   it should "deserialize Foo and not create a new instance (visibility settings)" in {
     val mapper = newBuilder
-      .changeDefaultVisibility(asJavaUnaryOperator((a: Any) => {
+      .changeDefaultVisibility(_ => {
         VisibilityChecker.defaultInstance()
           .withFieldVisibility(JsonAutoDetect.Visibility.ANY)
           .withGetterVisibility(JsonAutoDetect.Visibility.NONE)
-      }))
+      })
       .build()
     val original = Foo
     val json = mapper.writeValueAsString(original)

src/test/scala/tools/jackson/module/scala/deser/OptionDeserializerTest.scala

@@ -9,7 +9,6 @@ import tools.jackson.module.scala.DefaultScalaModule
 import tools.jackson.module.scala.introspect.ScalaAnnotationIntrospectorModule
 
 import scala.annotation.meta.field
-import scala.compat.java8.FunctionConverters
 
 object OptionDeserializerTest {
   case class UnavailableField(foo: Option[String])
@@ -97,7 +96,7 @@ class OptionDeserializerTest extends DeserializerTest {
 
   it should "handle conversion of null to empty collection" in {
     val mapper = newBuilder
-      .changeDefaultNullHandling(FunctionConverters.asJavaUnaryOperator(_ => JsonSetter.Value.construct(Nulls.AS_EMPTY, Nulls.AS_EMPTY)))
+      .changeDefaultNullHandling(_ => JsonSetter.Value.construct(Nulls.AS_EMPTY, Nulls.AS_EMPTY))
       .build()
     val json = """{"o": null}"""
     val result1 = mapper.readValue(json, classOf[JavaOptionalWrapper])

src/test/scala/tools/jackson/module/scala/deser/SeqDeserializerTest.scala

@@ -9,7 +9,6 @@ import tools.jackson.module.scala.{DefaultScalaModule, JacksonModule}
 
 import java.util.UUID
 import scala.collection.{immutable, mutable}
-import scala.compat.java8.FunctionConverters
 
 object SeqDeserializerTest {
   case class JavaListWrapper(s: java.util.ArrayList[String])
@@ -247,7 +246,7 @@ class SeqDeserializerTest extends DeserializerTest {
   it should "handle conversion of null to empty collection" in {
     val mapper = JsonMapper.builder()
       .addModule(DefaultScalaModule)
-      .changeDefaultNullHandling(FunctionConverters.asJavaUnaryOperator(_ => JsonSetter.Value.construct(Nulls.AS_EMPTY, Nulls.AS_EMPTY)))
+      .changeDefaultNullHandling(_ => JsonSetter.Value.construct(Nulls.AS_EMPTY, Nulls.AS_EMPTY))
       .build()
     val json = """{"s": null}"""
     val result1 = mapper.readValue(json, classOf[JavaListWrapper])

src/test/scala/tools/jackson/module/scala/deser/UnsortedMapDeserializerTest.scala

@@ -10,7 +10,6 @@ import org.scalatest.OptionValues
 
 import java.util.UUID
 import scala.collection._
-import scala.compat.java8.FunctionConverters
 
 case class JavaMapWrapper(m: java.util.HashMap[String, String])
 case class MapWrapper(m: Map[String, String])
@@ -106,7 +105,7 @@ class UnsortedMapDeserializerTest extends DeserializerTest with OptionValues {
   it should "handle conversion of null to empty collection" in {
     val mapper = JsonMapper.builder()
       .addModule(DefaultScalaModule)
-      .changeDefaultNullHandling(FunctionConverters.asJavaUnaryOperator(_ => JsonSetter.Value.construct(Nulls.AS_EMPTY, Nulls.AS_EMPTY)))
+      .changeDefaultNullHandling(_ => JsonSetter.Value.construct(Nulls.AS_EMPTY, Nulls.AS_EMPTY))
       .build()
     val json = """{"m": null}"""
     val result1 = mapper.readValue(json, classOf[JavaMapWrapper])

src/test/scala/tools/jackson/module/scala/ser/CaseClassSerializerTest.scala

@@ -7,7 +7,6 @@ import tools.jackson.databind.{MapperFeature, ObjectMapper, PropertyNamingStrate
 import tools.jackson.module.scala.DefaultScalaModule
 
 import scala.beans.BeanProperty
-import scala.compat.java8.FunctionConverters
 
 case class ConstructorTestCaseClass(intValue: Int, stringValue: String)
 
@@ -134,8 +133,8 @@ class CaseClassSerializerTest extends SerializerTest {
 
   def nonNullMapper: ObjectMapper = {
     newBuilder
-      .changeDefaultPropertyInclusion(FunctionConverters.asJavaUnaryOperator(_ =>
-        JsonInclude.Value.construct(JsonInclude.Include.NON_NULL, JsonInclude.Include.NON_NULL)))
+      .changeDefaultPropertyInclusion(_ =>
+        JsonInclude.Value.construct(JsonInclude.Include.NON_NULL, JsonInclude.Include.NON_NULL))
       .build()
   }
 

src/test/scala/tools/jackson/module/scala/ser/CaseObjectSerializerTest.scala

@@ -4,8 +4,6 @@ import com.fasterxml.jackson.annotation.{JsonAutoDetect, PropertyAccessor}
 import tools.jackson.databind.introspect.VisibilityChecker
 import tools.jackson.module.scala.DefaultScalaModule
 
-import scala.compat.java8.FunctionConverters.asJavaUnaryOperator
-
 case object CaseObjectExample {
   val field1: String = "test"
   val field2: Int = 42
@@ -29,11 +27,11 @@ class CaseObjectSerializerTest extends SerializerTest {
   // https://github.com/FasterXML/jackson-module-scala/issues/596
   it should "serialize a case object when visibility settings set" ignore {
     val mapper = newBuilder
-      .changeDefaultVisibility(asJavaUnaryOperator((a: Any) => {
+      .changeDefaultVisibility(_ => {
         VisibilityChecker.defaultInstance()
           .withFieldVisibility(JsonAutoDetect.Visibility.ANY)
           .withGetterVisibility(JsonAutoDetect.Visibility.NONE)
-      }))
+      })
       .build()
     mapper.writeValueAsString(CaseObjectExample) should (
       equal("""{"field1":"test","field2":42}""") or
@@ -43,11 +41,11 @@ class CaseObjectSerializerTest extends SerializerTest {
 
   it should "serialize an inner case object when visibility settings set" in {
     val mapper = newBuilder
-      .changeDefaultVisibility(asJavaUnaryOperator((a: Any) => {
+      .changeDefaultVisibility(_ => {
         VisibilityChecker.defaultInstance()
           .withFieldVisibility(JsonAutoDetect.Visibility.ANY)
           .withGetterVisibility(JsonAutoDetect.Visibility.NONE)
-      }))
+      })
       .build()
     mapper.writeValueAsString(Foo) shouldEqual """{"field":"bar"}"""
   }

src/test/scala/tools/jackson/module/scala/ser/OptionSerializerTest.scala

@@ -7,7 +7,6 @@ import tools.jackson.module.scala.{DefaultScalaModule, JacksonModule}
 
 import java.util
 import scala.annotation.meta.{field, getter}
-import scala.compat.java8.FunctionConverters._
 
 object OptionSerializerTest {
   class NonEmptyOptions {
@@ -263,7 +262,7 @@ class OptionSerializerTest extends SerializerTest {
   }
 
   private def newMapperWithPropertyInclusion(includeValue: JsonInclude.Value): ObjectMapper = {
-    val builder = newBuilder.changeDefaultPropertyInclusion(asJavaUnaryOperator((a: Any) => includeValue))
+    val builder = newBuilder.changeDefaultPropertyInclusion(_ => includeValue)
     builder.build()
   }
 }