Fix PropertyValueService DI error — use exported ChannelsPropertiesService

PropertyValueService is a provider in DevicesModule but NOT in its
exports list, so it's unavailable for injection in other modules.
NestJS threw UnknownDependenciesException at startup.

Replaced with channelsPropertiesService.update() which IS exported
and matches the pattern used by the Z2M plugin for writing property
values. This also triggers the proper WebSocket events for real-time
UI updates.

https://claude.ai/code/session_014bjB9Cn1WKASNLBeCuSbom

Author: claude

apps/backend/src/plugins/devices-zigbee-herdsman/services/zigbee-herdsman.service.ts

@@ -2,13 +2,12 @@
 import { Injectable } from '@nestjs/common';
 
 import { ExtensionLoggerService, createExtensionLogger } from '../../../common/logger';
+import { toInstance } from '../../../common/utils/transform.utils';
 import { ConfigService } from '../../../modules/config/services/config.service';
 import { ConnectionState } from '../../../modules/devices/devices.constants';
-import { ChannelPropertyEntity } from '../../../modules/devices/entities/devices.entity';
 import { ChannelsPropertiesService } from '../../../modules/devices/services/channels.properties.service';
 import { DeviceConnectivityService } from '../../../modules/devices/services/device-connectivity.service';
 import { DevicesService } from '../../../modules/devices/services/devices.service';
-import { PropertyValueService } from '../../../modules/devices/services/property-value.service';
 import {
 	ConfigChangeResult,
 	IManagedPluginService,
@@ -18,6 +17,8 @@ import {
 	DEVICES_ZIGBEE_HERDSMAN_PLUGIN_NAME,
 	DEVICES_ZIGBEE_HERDSMAN_TYPE,
 } from '../devices-zigbee-herdsman.constants';
+import { UpdateZigbeeHerdsmanChannelPropertyDto } from '../dto/update-channel-property.dto';
+import { ZigbeeHerdsmanChannelPropertyEntity } from '../entities/devices-zigbee-herdsman.entity';
 import { ZhDiscoveredDevice } from '../interfaces/zigbee-herdsman.interface';
 import { ZigbeeHerdsmanConfigModel } from '../models/config.model';
 
@@ -44,7 +45,6 @@ export class ZigbeeHerdsmanService implements IManagedPluginService {
 		private readonly configValidator: ZigbeeHerdsmanConfigValidatorService,
 		private readonly devicesService: DevicesService,
 		private readonly channelsPropertiesService: ChannelsPropertiesService,
-		private readonly propertyValueService: PropertyValueService,
 		private readonly deviceConnectivityService: DeviceConnectivityService,
 		private readonly zhConnectivityService: ZhDeviceConnectivityService,
 	) {}
@@ -265,20 +265,20 @@ export class ZigbeeHerdsmanService implements IManagedPluginService {
 				return;
 			}
 
-			// Write converted values to matching channel properties
-			// Property identifiers are set to zigbee expose names during adoption
-			const allProperties = await this.channelsPropertiesService.findAll<ChannelPropertyEntity>(
-				undefined,
+			// Write converted values to matching channel properties.
+			// Property identifiers are set to zigbee expose names during adoption.
+			// Use channelsPropertiesService.update() (exported from DevicesModule)
+			// to persist values — this also triggers WebSocket events.
+			const deviceChannelIds = device.channels?.map((c) => c.id) ?? [];
+			if (deviceChannelIds.length === 0) {
+				return;
+			}
+
+			const deviceProperties = await this.channelsPropertiesService.findAll<ZigbeeHerdsmanChannelPropertyEntity>(
+				deviceChannelIds,
 				DEVICES_ZIGBEE_HERDSMAN_TYPE,
 			);
 
-			// Filter to properties belonging to this device's channels
-			const deviceChannelIds = new Set(device.channels?.map((c) => c.id) ?? []);
-			const deviceProperties = allProperties.filter((p) => {
-				const channelId = typeof p.channel === 'string' ? p.channel : p.channel?.id;
-				return channelId && deviceChannelIds.has(channelId);
-			});
-
 			for (const property of deviceProperties) {
 				const stateKey = property.identifier;
 				if (!stateKey || !(stateKey in convertedState)) {
@@ -291,10 +291,19 @@ export class ZigbeeHerdsmanService implements IManagedPluginService {
 				}
 
 				try {
-					const writeValue = typeof value === 'object' ? JSON.stringify(value) : (value as string | number | boolean);
-					await this.propertyValueService.write(property, writeValue);
+					const writeValue = typeof value === 'object' ? JSON.stringify(value) : value;
+					await this.channelsPropertiesService.update<
+						ZigbeeHerdsmanChannelPropertyEntity,
+						UpdateZigbeeHerdsmanChannelPropertyDto
+					>(
+						property.id,
+						toInstance(UpdateZigbeeHerdsmanChannelPropertyDto, {
+							type: DEVICES_ZIGBEE_HERDSMAN_TYPE,
+							value: writeValue,
+						}),
+					);
 				} catch {
-					// Non-critical — individual property write failures are logged by PropertyValueService
+					// Non-critical — individual property write failures
 				}
 			}
 		} catch (error) {