Support removing related links when deleting nodes and allow multiple links per pin#71
Open
fgfxf wants to merge 132 commits into
Open
Support removing related links when deleting nodes and allow multiple links per pin#71fgfxf wants to merge 132 commits into
fgfxf wants to merge 132 commits into
Conversation
Added credits
Getting ready for first release.
Getting ready for first release.
viewport_wrapper.h will become a stand-alone helper for rendering multiple viewport with ease.
Refactored confusing method's names. Implemented generic type Pin UID system. Improved documentation. Fixed OutPin graphic bug. Added additional hit-box on pin's circle + little animation.
Working example on Mac and Linux
Contribution of: Cursed-Gato
…e_ calling DestroyContext() on main context.
…ererHasTextures matches between contexts. fix for imgui 1.92.
…amic font scaling in dear imgui 1.92.
Fixes for dear imgui 1.92
Fix logic for dynamic inputs + add full node size calculation
Better example with links
currently when zooming this causes the links & nodes to become detached from the mouse pointer. This fix makes sure they stay attached to the mouse.
Fix zooming messing up dragging
Added nullptr check in Link destructor
Owner
|
The code formatting doesn't match the one used. Comments should be purely English. Describe the problem you are fixing |
fgfxf
force-pushed
the
master
branch
2 times, most recently
from
652d2b6 to
1a0574d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds safer link cleanup when deleting nodes and allows pins to hold multiple links.
Details
Previously, deleting a node did not always remove the links connected to its pins. This could leave dangling links in the graph and potentially cause invalid pointer access when the graph was rendered or updated later.
This PR updates the link removal logic so that all links related to a node are removed before the node itself is erased. It also changes pin link management to support multiple links per pin.
Changes
Testing
Manually tested by creating nodes with single and multiple links, deleting connected nodes, and verifying that related links are removed correctly while unrelated links remain valid.