Open
Conversation
Dev/v0.7.0
update the version and dependent libs.
[CoreEngine] remove the deprecated files in the scheduler.
…gging Inference Gateway Logs
…/FedML into raphael/fix-multi-subfd
[Deploy] Recursively find the model serving package folder
[Deploy] Hot fix grammar.
…tfix Hot fix to support local debugging
…n Windows OS. 2. fixed the issue the sqlite path is illegal in Windows OS.
[CoreEngine] 1. fixed the issue that the fork method is not support i…
…counter Adding hash set for counting the number of pending requests per endpoint.
…d_urls Moving from storage object to presigned URLs
[Deploy] Refactor the quick start example, use public ip as default.
…ed architecture that supports Launch Master, Launch Slave, Deploy Master, and Deploy Slave at the same time.
…ateway performance
…disable MQTT debug logging
update dev/0.7.0 to charlie dev branch
Deployment and Inference Module Performance Optimization Project
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| logging.info("=" * 80) | ||
| logging.info("[Device Model Deployment] Creating container with following parameters:") | ||
| logging.info("=" * 80) | ||
| logging.info("Image: {}".format(inference_image_name)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we should avoid logging any potentially sensitive information. Instead of logging the inference_image_name directly, we can log a sanitized version or avoid logging it altogether. We should also review other logging statements to ensure no sensitive information is being logged.
The best way to fix this without changing existing functionality is to sanitize the inference_image_name before logging it. We can replace sensitive parts of the string with a placeholder or simply avoid logging it if it contains sensitive information.
Suggested changeset
1
python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py
| @@ -223,3 +223,4 @@ | ||
| logging.info("=" * 80) | ||
| logging.info("Image: {}".format(inference_image_name)) | ||
| sanitized_inference_image_name = inference_image_name.replace(registry_user_password, "****") if registry_user_password in inference_image_name else inference_image_name | ||
| logging.info("Image: {}".format(sanitized_inference_image_name)) | ||
| logging.info("Container name: {}".format(default_server_container_name)) |
Copilot is powered by AI and may make mistakes. Always verify output.
[debug] Remove verbose logging in job monitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.