Add write commands to horustctl#309
Conversation
535ec47 to
b1093e4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
2196b1d to
c82733e
Compare
f6151e2 to
d1b347c
Compare
There was a problem hiding this comment.
I have a question. Previously, horust works as a container init process, so it exits when all the services are done. But now when we use horustctl to control the services lifecycle, if we stop all the services, the horust will exit, there is no room for horustctl to start those services since the uds is gone. I'm not sure if this is something we should change.
Do you have any recommendations/suggestions? The rationale behind horustctl is that some users asked for it and in some cases it comes as a deciding factor on adoption apparently. I agree, I don't see much of a reason to use horustctl inside a container, but maybe there are cases in which it might be helpful. I think it might be helpful if a user wants to run horust outside a container as well. Let me know what you think! |
It seems We shall not break the current |
Motivation and Context
Fixes: #31
Description
Horustctl was created as part of pr: #200. Later that pr was splitted in smaller more digestible PRs, while refactoring the codebase as well. The current horustctl support only querying the status of the supervised services. This PR add support for changing a single service status using the horustcli.
How Has This Been Tested?
Unit and Integration tests.
Types of changes
Checklist: