Rename method _to_dict to to_dict

Author: Felixoid

zenmoney/request.py

@@ -23,7 +23,7 @@ def diff(self, diff: Diff, debug=False) -> Diff:
         '''
         Accept the Diff object and returns Diff object
         '''
-        response = self.__post(self.uri_diff, json=Diff._to_dict(diff))
+        response = self.__post(self.uri_diff, json=Diff.to_dict(diff))
         if debug:
             self._plain_diff = response.json()
 
@@ -35,7 +35,7 @@ def suggest(self, transaction: object) -> Transaction:
         returns the same data with suggestions
         '''
         response = self.__post(self.uri_suggest,
-                               json={'transaction': transaction._to_dict()})
+                               json={'transaction': transaction.to_dict()})
         return response.json()
 
     def __post(self, uri: str, **kwargs):

zenmoney/zenobject.py

@@ -5,14 +5,16 @@ def to_dict(obj, classkey=None):
     if isinstance(obj, dict):
         data = {}
         for (k, v) in obj.items():
-            data[k] = ZenObject._to_dict(v, classkey)
+            data[k] = to_dict(v, classkey)
 
         return data
     elif hasattr(obj, '__iter__') and not isinstance(obj, str):
-        return [ZenObject._to_dict(v, classkey) for v in obj]
+        return [to_dict(v, classkey) for v in obj]
     elif hasattr(obj, '__dict__'):
         data = dict([
-            (key, ZenObject._to_dict(getattr(obj, key), classkey))
+            (key, to_dict(getattr(obj, key), classkey))
+            # __dir__ is used here to get dynamic properties
+            # like Diff.currentClientTimestamp as well
             for key in obj.__dir__()
             if not key.startswith('_')
             and not callable(getattr(obj, key))
@@ -38,7 +40,7 @@ def __eq__(self, obj):
     def _type(self):
         return type(self).__name__
 
-    def _to_dict(self, classkey=None):
+    def to_dict(self, classkey=None):
         return to_dict(self, classkey)
 
 
@@ -87,5 +89,5 @@ def _by_attr(self, attr, value):
                 if value == attr_value:
                     yield o
 
-    def _to_dict(self, classkey=None):
+    def to_dict(self, classkey=None):
         return to_dict(self, classkey)