Skip to content

resolve loadURL blank screen issue#4

Open
kapilrc wants to merge 1 commit into
Festify:masterfrom
kapilrc:resolve-loadURL-blank-screen-issue
Open

resolve loadURL blank screen issue#4
kapilrc wants to merge 1 commit into
Festify:masterfrom
kapilrc:resolve-loadURL-blank-screen-issue

Conversation

@kapilrc

@kapilrc kapilrc commented Oct 15, 2020

Copy link
Copy Markdown

With the base code, the loadURL returned blank html screen. This changes resolves the relative path issue and loads the requested URL.

@NeoLegends

Copy link
Copy Markdown
Member

Thanks! The changes as they currently are, however, would lead to the plugin being unable to load internet urls (as in e. g. https://google.com/). In Festify, however, we need to load internet URLs, so we cannot accept this as-is.

I suggest you add a second function to the ExternalScreen class that is specialized on loading URLs relative to the app package (e. g. loadLocalUrl) that then performs the string formatting and loads the formatted URL.

@kapilk2

kapilk2 commented Oct 15, 2020

Copy link
Copy Markdown

This is a great idea for loading local and web Urls. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants