Skip to content

feat: add 'vex' option#342

Merged
italvi merged 59 commits into
mainfrom
vex_command
Apr 28, 2025
Merged

feat: add 'vex' option#342
italvi merged 59 commits into
mainfrom
vex_command

Conversation

@Matze08
Copy link
Copy Markdown
Contributor

@Matze08 Matze08 commented Dec 16, 2024

closes #156

@github-actions github-actions Bot added documentation Improvements or additions to documentation enhancement New feature or request settings_changes unittests labels Dec 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 17, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
__main__.py4302594%252–253, 270, 282, 325, 336–340, 342, 918, 961, 1006, 1011, 1015, 1040, 1054, 1058, 1062, 1064, 1073, 1083, 1150, 1152
vex.py81297%58, 75
auxiliary
   output.py741086%110, 138–143, 145, 155, 158
TOTAL221610995% 

Tests Skipped Failures Errors Time
417 2 💤 0 ❌ 0 🔥 15.619s ⏱️

CBeck-96
CBeck-96 requested changes Jan 8, 2025
View reviewed changes
Comment thread cdxev/vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread tests/test_vex.py
@Matze08 Matze08 requested a review from CBeck-96 January 8, 2025 10:32
CBeck-96
CBeck-96 requested changes Jan 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@CBeck-96 CBeck-96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so many vex files in test? You could just create one file containing all cases and test the functions with them.
The current version is harder to maintain in case of changes to the specification and if your inpout is to specific you might miss some error sources.

Comment thread cdxev/vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread tests/auxiliary/test_vex/searched_vex_missing_data.json Outdated
Comment thread tests/test_vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread cdxev/vex.py Outdated
Comment thread cdxev/__main__.py Outdated
@Matze08 Matze08 requested a review from CBeck-96 January 22, 2025 09:22
@italvi italvi mentioned this pull request Mar 25, 2025
Closed
@CBeck-96 CBeck-96 requested a review from italvi March 28, 2025 08:45
@CBeck-96 CBeck-96 mentioned this pull request Apr 9, 2025
Closed
italvi
italvi requested changes Apr 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@italvi italvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only documentation changes, then it can be approved.

Comment thread docs/source/usage/vex.rst
Comment thread docs/source/usage/vex.rst Outdated
Comment thread docs/source/usage/vex.rst Outdated
Comment thread docs/source/usage/vex.rst Outdated
Comment thread cdxev/__main__.py Outdated
italvi
italvi reviewed Apr 22, 2025
View reviewed changes
Comment thread cdxev/__main__.py Outdated
italvi
italvi reviewed Apr 22, 2025
View reviewed changes
Comment thread cdxev/__main__.py Outdated
italvi
italvi reviewed Apr 22, 2025
View reviewed changes
Comment thread docs/source/usage/vex.rst Outdated
italvi
italvi reviewed Apr 22, 2025
View reviewed changes
Comment thread docs/source/usage/vex.rst Outdated
@CBeck-96 CBeck-96 requested a review from italvi April 24, 2025 10:04
italvi
italvi requested changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@italvi italvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

Comment thread docs/source/usage/vex.rst
Comment thread docs/source/usage/vex.rst Outdated
Comment thread docs/source/usage/vex.rst Outdated
Comment thread cdxev/__main__.py Outdated
Comment thread docs/source/usage/vex.rst Outdated
@italvi italvi mentioned this pull request Apr 28, 2025
Open
italvi
italvi approved these changes Apr 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@italvi italvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, thanks!

@italvi italvi merged commit a0ea4d6 into main Apr 28, 2025
8 checks passed
@italvi italvi deleted the vex_command branch July 19, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CBeck-96 CBeck-96 CBeck-96 left review comments

@italvi italvi italvi approved these changes

Assignees

@CBeck-96 CBeck-96

Labels

documentation Improvements or additions to documentation enhancement New feature or request settings_changes unittests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

What is the point of merge-vex?

3 participants

@Matze08 @italvi @CBeck-96