Skip to content

Commit 400ee18

Browse files
Address review partially
1 parent 8ff9896 commit 400ee18

5 files changed

Lines changed: 24 additions & 5 deletions

File tree

Include/internal/pycore_code.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ typedef struct {
529529

530530
PyAPI_FUNC(int) _Py_Instrument(PyCodeObject *co, PyInterpreterState *interp);
531531

532-
extern _Py_CODEUNIT _Py_GetBaseCodeUnit(PyCodeObject *code, int offset);
532+
PyAPI_FUNC(_Py_CODEUNIT) _Py_GetBaseCodeUnit(PyCodeObject *code, int offset);
533533

534534
extern int _PyInstruction_GetLength(PyCodeObject *code, int offset);
535535

Modules/_testinternalcapi/test_cases.c.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,10 @@
424424
next_oparg = exec->vm_data.oparg;
425425
}
426426
#endif
427-
assert(next_instr->op.code == STORE_FAST || next_instr->op.code == ENTER_EXECUTOR);
427+
_PyFrame_SetStackPointer(frame, stack_pointer);
428+
assert(_Py_GetBaseCodeUnit(_PyFrame_GetCode(frame),
429+
next_instr - _PyFrame_GetBytecode(frame)).op.code == STORE_FAST);
430+
stack_pointer = _PyFrame_GetStackPointer(frame);
428431
#else
429432
next_oparg = (int)CURRENT_OPERAND0_16();
430433
#endif

Python/bytecodes.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,8 @@ dummy_func(
792792
next_oparg = exec->vm_data.oparg;
793793
}
794794
#endif
795-
assert(next_instr->op.code == STORE_FAST || next_instr->op.code == ENTER_EXECUTOR);
795+
assert(_Py_GetBaseCodeUnit(_PyFrame_GetCode(frame),
796+
next_instr - _PyFrame_GetBytecode(frame)).op.code == STORE_FAST);
796797
#else
797798
next_oparg = (int)CURRENT_OPERAND0_16();
798799
#endif

Python/executor_cases.c.h

Lines changed: 13 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/generated_cases.c.h

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)