Skip to content

Commit 06dbade

Browse files
author
Brendan Gray
committed
fix: GitHub Actions workflow - use CSC_LINK env var for signing, remove secrets-in-if syntax error
1 parent f4c857e commit 06dbade

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,13 @@ jobs:
2929
- name: Build renderer
3030
run: npm run build:renderer
3131

32-
- name: Decode signing certificate
33-
if: ${{ secrets.WIN_CSC_BASE64 != '' }}
34-
run: |
35-
[System.IO.File]::WriteAllBytes("$env:GITHUB_WORKSPACE\code-signing.pfx", [System.Convert]::FromBase64String("${{ secrets.WIN_CSC_BASE64 }}"))
36-
3732
- name: Build Windows installer
3833
run: npx electron-builder --win --x64 --config electron-builder.nosign.json
3934
env:
4035
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
36+
CSC_LINK: ${{ secrets.WIN_CSC_LINK }}
4137
CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }}
38+
CSC_IDENTITY_AUTO_DISCOVERY: 'false'
4239

4340
- name: Upload Windows artifact
4441
uses: actions/upload-artifact@v4

electron-builder.nosign.cuda.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
"icon": "icon.ico",
3131
"publisherName": "GraySoft LLC",
3232
"signingHashAlgorithms": ["sha256"],
33-
"certificateFile": "code-signing.pfx",
3433
"target": [
3534
{
3635
"target": "nsis",

electron-builder.nosign.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
"icon": "icon.ico",
3333
"publisherName": "GraySoft LLC",
3434
"signingHashAlgorithms": ["sha256"],
35-
"certificateFile": "code-signing.pfx",
3635
"target": [
3736
{
3837
"target": "nsis",

0 commit comments

Comments
 (0)