v1.8.29: 7 bug fixes - single-click open, tool instructions, live preview, reasoning dropdown, code-dump nudge

Brendan Gray · Brendan Gray · commit bfe0e0794fac · 2026-03-12T20:47:24.000-04:00
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
@@ -1,5 +1,16 @@
 # 🚫 STOP — READ THIS FIRST — NON-NEGOTIABLE — NO EXCEPTIONS
 
+## 🔴 RULE -1 — NEVER END INTERACTION WITHOUT MULTI-CHOICE QUESTION — ABSOLUTE
+
+**This is THE most critical rule. Every premium request costs money. Ending without continuation wastes it.**
+
+- **NEVER end an interaction by just stopping.** If you complete a task, hit a wall, need input, or have nothing more to do — you MUST use the multi-choice question tool to give the user options.
+- **Every interaction MUST end with either:** (1) a multi-choice question tool call, OR (2) active work still in progress (e.g., waiting for a build, running a command)
+- **"I've completed X, let me know if you need anything else"** — BANNED. This is ending without continuation.
+- **"Ready to proceed when you are"** — BANNED. Use multi-choice question instead.
+- **If you are about to type your final message:** STOP. Call the multi-choice question tool with options like: "Build it", "Make additional changes", "Review the plan", "I have questions", etc.
+- **This rule applies to EVERY interaction, no exceptions.** The user should never have to type a new message just to continue — they should be able to click an option.
+
 ** NEVER BLAME MODEL
  SIZE —ALL MODELS EXCEL IN LM STUDIO  AT SAME TASKS THEYRE BEING TESTED ON HERE! If something fails, the problem is in the pipeline. Exhaust all levers before concluding "the model isn't good enough." Do not say "the model can't do this" without first confirming that every other lever has been pulled. This is a production software project, not a research experiment. The user expects results, not excuses.
 
diff --git a/main/agenticChat.js b/main/agenticChat.js
@@ -1667,8 +1667,11 @@ function register(ctx) {
         }
       }
 
-      // Route planning text to thinking panel
-      if (toolResults.hasToolCalls && toolResults.results.length > 0 && mainWindow) {
+      // Route planning text to thinking panel — ONLY for thinking models
+      // Non-thinking models' intro text ("Let me create that...") is their response, not reasoning
+      const _modelPath = llmEngine?.currentModelPath || '';
+      const _isThinkingModel = /qwq|r1-distill|deepseek.*r1|-think/i.test(_modelPath);
+      if (_isThinkingModel && toolResults.hasToolCalls && toolResults.results.length > 0 && mainWindow) {
         let planningText;
         if (toolResults.formalCallCount > 0) {
           // Formal tool calls — strip from tool indicators onward
@@ -1713,12 +1716,15 @@ function register(ctx) {
         const _unclosedFenceMatch = !hasCodeBlocks && responseText.match(/```(?:html?|css|javascript|js|typescript|ts|python|py|json)\s*\n([\s\S]{500,})$/i);
         const hasUnclosedLargeBlock = !!_unclosedFenceMatch && !_unclosedFenceMatch[1].includes('```');
         // Detect raw HTML/code dumped without fences (model obeyed "no code blocks" but didn't use write_file)
-        // Requires STRUCTURAL HTML document tags (<!DOCTYPE, <html, <head, <body) to avoid false
-        // positives on plain-text descriptions that mention individual element names like <div>, <section>.
-        const hasRawCodeDump = !hasCodeBlocks && !hasUnclosedLargeBlock && responseText.length > 500 && (
-          (/<html[\s>]/i.test(responseText) && (/<head[\s>]/i.test(responseText) || /<body[\s>]/i.test(responseText))) ||
-          (/<style[\s>]/i.test(responseText) && (responseText.match(/[{};]\s*\w+\s*:/g) || []).length > 5) ||
-          (/<script[\s>]/i.test(responseText) && (responseText.match(/(?:function |const |let |var |=>)/g) || []).length > 3)
+        // STRICT detection: requires FULL document structure (<html> AND (<head> OR <body>)) with significant length
+        // to avoid false positives on partial explanations or snippets. Length threshold raised to 1500 chars.
+        const hasRawCodeDump = !hasCodeBlocks && !hasUnclosedLargeBlock && responseText.length > 1500 && (
+          // Full HTML document: must have <html> AND at least one of <head> or <body> with substantial content
+          (/<html[\s>]/i.test(responseText) && /<head[\s>]/i.test(responseText) && /<body[\s>]/i.test(responseText) && (responseText.match(/<\/\w+>/g) || []).length > 10) ||
+          // CSS block: must have multiple complete CSS rules (not just a few property mentions)
+          (/<style[\s>]/i.test(responseText) && (responseText.match(/\{[^}]+\}/g) || []).length > 8) ||
+          // JS block: must have multiple function/variable declarations (substantial code)
+          (/<script[\s>]/i.test(responseText) && (responseText.match(/(?:function\s+\w+|const\s+\w+\s*=|let\s+\w+\s*=|var\s+\w+\s*=)/g) || []).length > 5)
         );
 
         // Skip nudge when context is critically small — resetSession can hang on degraded KV cache
diff --git a/main/constants.js b/main/constants.js
@@ -76,11 +76,31 @@ If your output is cut off mid-generation, the system will automatically continue
 
 const DEFAULT_COMPACT_PREAMBLE = `You are a helpful, knowledgeable AI assistant. You can answer questions on ANY topic — coding, history, science, math, creative writing, and more. You also have coding tools available. Call tools to take action — never just describe what you'd do. Never refuse a request because it is not about code. Always attempt to fulfill the user's request regardless of its length or complexity. When the user specifies output format or file structure, follow those requirements exactly.
 
+## CRITICAL — ALWAYS USE TOOLS
+**When the user asks you to create, write, save, or generate ANY file — call write_file IMMEDIATELY.** Do NOT write code in your response. Do NOT describe what the file would contain. CALL THE TOOL.
+- User: "Create an HTML page" → YOU call write_file, NOT output HTML in chat
+- User: "Make a script" → YOU call write_file, NOT output code blocks
+- User: "Build a website" → YOU call write_file for EACH file
+**Code blocks in chat = WRONG. Tool calls = CORRECT.**
+
 ## CRITICAL — You Have Real-Time Access
 **Use web_search or fetch_webpage for live data.** NEVER say "I cannot access real-time data." You CAN. If cut off mid-task, the system continues automatically — NEVER refuse.
 
-## Tools
-read_file, write_file, edit_file, list_directory, find_files, grep_search, run_command, web_search, fetch_webpage, browser_navigate, browser_snapshot, browser_click, browser_type, search_codebase, analyze_error, append_to_file, write_todos, update_todo
+## Tools (USE THEM!)
+- **write_file** — Create/overwrite files. USE THIS when asked to create ANY file.
+- **edit_file** — Modify a specific part of an existing file.
+- **append_to_file** — Add content to end of file without overwriting.
+- **read_file** — Read file contents before editing.
+- **list_directory** — See what files exist in a folder.
+- **find_files** — Search for files by name pattern.
+- **grep_search** — Search file contents for text.
+- **run_command** — Execute terminal/shell commands.
+- **web_search** — Get live internet data (current info, docs, news).
+- **fetch_webpage** — Get full text content from a URL.
+- **browser_navigate** — Open a URL in browser.
+- **browser_snapshot** — Capture current browser page.
+- **browser_click/type** — Interact with browser page elements.
+- **write_todos/update_todo** — Track multi-step tasks.
 
 ## Rules
 - **Never output full file content as code blocks in chat** — always use write_file, edit_file, or append_to_file. Code blocks are only for brief snippets or explanations.
diff --git a/src/components/Editor/Previews.tsx b/src/components/Editor/Previews.tsx
@@ -62,7 +62,14 @@ export const BinaryPreview: React.FC<{ filePath: string; fileName: string }> = (
 // ── HTML Preview ──
 export const HtmlPreview: React.FC<{ content: string; filePath: string; onToggleCode: () => void }> = ({ content, filePath, onToggleCode }) => {
   const iframeRef = useRef<HTMLIFrameElement>(null);
-  const [key, setKey] = useState(0);
+  const [manualKey, setManualKey] = useState(0);
+  // Auto-refresh: hash content so iframe re-renders on every edit (live preview)
+  const contentHash = useMemo(() => {
+    let h = 0;
+    for (let i = 0; i < content.length; i++) h = ((h << 5) - h + content.charCodeAt(i)) | 0;
+    return h;
+  }, [content]);
+  const key = `${manualKey}-${contentHash}`;
 
   const resolvedContent = useMemo(() => {
     const dir = filePath.replace(/\\/g, '/').replace(/\/[^/]*$/, '');
@@ -89,7 +96,7 @@ export const HtmlPreview: React.FC<{ content: string; filePath: string; onToggle
         <div className="flex-1" />
         <button
           className="p-1 text-[#858585] hover:text-white rounded hover:bg-[#3c3c3c] transition-colors"
-          onClick={() => setKey(k => k + 1)}
+          onClick={() => setManualKey(k => k + 1)}
           title="Refresh preview"
         >
           <RefreshCw size={12} />
diff --git a/src/components/FileExplorer/FileNode.tsx b/src/components/FileExplorer/FileNode.tsx
@@ -51,9 +51,14 @@ export const FileNodeComponent: React.FC<FileNodeComponentProps> = ({
   const handleClick = useCallback((event: React.MouseEvent) => {
     event.preventDefault();
     event.stopPropagation();
-    if (node.type === 'directory') onToggle(node);
+    if (node.type === 'directory') {
+      onToggle(node);
+    } else {
+      // Single-click on file opens it (regression fix: was double-click only)
+      onOpenFile?.(node);
+    }
     onSelect(node, event);
-  }, [node, onToggle, onSelect]);
+  }, [node, onToggle, onSelect, onOpenFile]);
 
   const handleExpandClick = useCallback((event: React.MouseEvent) => {
     event.preventDefault();
