v1.8.20: Fix duplicate tool bubbles, thinking duplication, fetch_webpage misuse

Author: Brendan Gray

main/agenticChat.js

@@ -1186,6 +1186,8 @@ function register(ctx) {
       if (continuationCount > 0) {
         displayChunk = displayChunk.replace(/\[(?:Continue your response|You were generating a tool call)[\s\S]*?\]/gi, '');
       }
+      // Save length before adding this iteration's text (for Bug 2 fix: remove reasoning that gets routed to thinking)
+      const priorDisplayLen = displayResponseText.length;
       displayResponseText += displayChunk;
 
       // Correct UI stream buffer: the overlapping tokens were already streamed
@@ -1485,7 +1487,10 @@ function register(ctx) {
         }
         if (planningText) {
           mainWindow.webContents.send('llm-thinking-token', planningText);
-          mainWindow.webContents.send('llm-replace-last', planningText);
+          // Bug 2 fix: Wipe reasoning from stream buffer (it's now in thinking panel only)
+          mainWindow.webContents.send('llm-replace-last', '');
+          // Also remove from displayResponseText so it doesn't appear in committed message
+          displayResponseText = displayResponseText.substring(0, priorDisplayLen);
         }
       }
 
@@ -1560,8 +1565,11 @@ function register(ctx) {
 
       if (isStale()) break;
 
-      // Accumulate tool results
-      allToolResults.push(...toolResults.results);
+      // Filter out deferred results from UI pipeline — they haven't executed yet
+      const uiToolResults = toolResults.results.filter(tr => !tr._deferred);
+
+      // Accumulate only non-deferred tool results for UI
+      allToolResults.push(...uiToolResults);
       capArray(allToolResults, 50);
 
       // Compress old tool results
@@ -1590,8 +1598,8 @@ function register(ctx) {
         executionState.update(tr.tool, tr.params, tr.result, iteration);
       }
 
-      // UI events
-      sendToolExecutionEvents(mainWindow, toolResults.results, playwrightBrowser, { checkSuccess: true });
+      // UI events — send only non-deferred results to prevent duplicate bubbles
+      sendToolExecutionEvents(mainWindow, uiToolResults, playwrightBrowser, { checkSuccess: true });
 
       // Build tool feedback
       const toolFeedback = buildToolFeedback(toolResults.results, {
@@ -1606,7 +1614,7 @@ function register(ctx) {
         snapFeedback = `\n### Page snapshot after ${snapResult.triggerTool}\n${snapResult.snapshotText}\n\n**${snapResult.elementCount} elements.** Use [ref=N] with browser_click/type.\n`;
       }
 
-      if (mainWindow) mainWindow.webContents.send('mcp-tool-results', toolResults.results);
+      if (mainWindow) mainWindow.webContents.send('mcp-tool-results', uiToolResults);
       fullResponseText += toolFeedback + snapFeedback;
       if (fullResponseText.length > MAX_RESPONSE_SIZE) {
         fullResponseText = fullResponseText.substring(fullResponseText.length - MAX_RESPONSE_SIZE);
@@ -1943,7 +1951,7 @@ async function executeNativeToolCalls(opts) {
 
       // Write deferral
       if (shouldDefer && DATA_WRITE_TOOLS.has(call.tool)) {
-        results.push({ tool: call.tool, params: call.params, result: { success: false, error: 'DEFERRED: Re-issue write next turn using actual data from tool results.' } });
+        results.push({ tool: call.tool, params: call.params, _deferred: true, result: { success: false, error: 'DEFERRED: Re-issue write next turn using actual data from tool results.' } });
         continue;
       }
 

main/constants.js

@@ -62,6 +62,7 @@ You can also answer general questions, help with writing, and have normal conver
 - **Never output full file content as code blocks in chat.** Always use the appropriate tool: write_file for new files, edit_file for modifications, append_to_file for additions, read_file before editing. Code blocks are only for brief snippets or explanations.
 - edit_file: call read_file first to get the exact current text, then supply precise oldText
 - Browser: browser_navigate → browser_snapshot → browser_click/type using refs from snapshot
+- When creating files (HTML, CSS, JS, etc.), write all content directly. Reference external resources (fonts, libraries, images) via CDN links — do not use fetch_webpage to download them.
 - Multi-step tasks (3+ steps): use write_todos to plan, update_todo as each step completes`;
 
 const DEFAULT_COMPACT_PREAMBLE = `You are a helpful, knowledgeable AI assistant. You can answer questions on ANY topic — coding, history, science, math, creative writing, and more. You also have coding tools available. Call tools to take action — never just describe what you'd do. Never refuse a request because it is not about code. Always attempt to fulfill the user's request regardless of its length or complexity. When the user specifies output format or file structure, follow those requirements exactly.
@@ -85,6 +86,7 @@ read_file, write_file, edit_file, list_directory, find_files, grep_search, run_c
 - If a tool fails, retry once with corrected parameters.
 - For edits: call read_file first, then edit_file with exact oldText and newText.
 - For large files: write_file first section, then append_to_file for each remaining section.
+- When creating files (HTML, CSS, JS, etc.), write all content directly. Reference external resources (fonts, libraries, images) via CDN links — do not use fetch_webpage to download them.
 - If the user asks for multiple files, create ALL of them. Call write_file for EACH file — do not stop after the first file. Do not claim a file was created unless you received a success result from write_file for that specific file. Do not summarize until every requested file exists.
 - Always use the exact filename the user specifies.
 - Once ALL parts of the task are complete (every requested file written, every question answered), respond with a brief summary. Do not call more tools after the task is done.`;

main/mcpToolServer.js

@@ -286,7 +286,7 @@ class MCPToolServer {
       },
       {
         name: 'fetch_webpage',
-        description: 'Fetch and extract content from a specific URL.',
+        description: 'Fetch and extract text content from a webpage URL. Use ONLY to READ information from a web page (articles, documentation, data). Do NOT use to download CSS, fonts, images, or other resources for files you are creating — reference them via CDN links instead.',
         parameters: {
           url: { type: 'string', description: 'URL to fetch', required: true },
         },

src/components/Chat/ChatPanel.tsx

@@ -437,7 +437,26 @@ export const ChatPanel: React.FC<ChatPanelProps> = ({
         });
       }
       if (finished.length > 0) {
-        setCompletedStreamingTools(prev => [...prev, ...finished]);
+        // Bug 1 fix: Dedup write tools by tool+filePath, keeping latest entry
+        setCompletedStreamingTools(prev => {
+          const combined = [...prev, ...finished];
+          const writeTools = ['write_file', 'create_file', 'edit_file', 'append_to_file'];
+          const seen = new Map<string, number>();
+          // Find latest index for each write tool+filePath combo
+          for (let i = combined.length - 1; i >= 0; i--) {
+            const td = combined[i];
+            if (writeTools.includes(td.tool)) {
+              const key = `${td.tool}:${td.params?.filePath || td.params?.fileName || ''}`;
+              if (!seen.has(key)) seen.set(key, i);
+            }
+          }
+          // Keep non-write tools + only the latest of each write tool+filePath
+          return combined.filter((td, idx) => {
+            if (!writeTools.includes(td.tool)) return true;
+            const key = `${td.tool}:${td.params?.filePath || td.params?.fileName || ''}`;
+            return seen.get(key) === idx;
+          });
+        });
       }
       executingToolsRef.current = [];
       setExecutingTools([]);
@@ -2769,16 +2788,22 @@ ${e.message}`,
                             const doneExt = doneFilePath.includes('.') ? doneFilePath.split('.').pop()?.toLowerCase() || '' : '';
                             const doneLang = LANG_MAP_LIVE[doneExt] || doneExt || 'code';
                             const doneContent = toolData.params?.content as string | undefined;
+                            // Bug 1 fix: Use actual result status instead of hardcoded 'ok'
+                            const isStreamOk = (toolData as any).result?.success !== false;
                             return (
                               <div key={`done-flat-${i}`} className="mt-2">
                                 <div className="flex items-center gap-1.5 mb-1 px-0.5">
-                                  <Check size={11} className="text-[#89d185] flex-shrink-0" />
-                                  <span className="text-[11px] text-[#d4d4d4] font-medium">{getToolLabel(toolData, 'ok')}</span>
+                                  {isStreamOk ? (
+                                    <Check size={11} className="text-[#89d185] flex-shrink-0" />
+                                  ) : (
+                                    <X size={11} className="text-[#f14c4c] flex-shrink-0" />
+                                  )}
+                                  <span className="text-[11px] text-[#d4d4d4] font-medium">{getToolLabel(toolData, isStreamOk ? 'ok' : 'fail')}</span>
                                 </div>
                                 {doneContent ? (
                                   <CodeBlock code={doneContent} language={doneLang} onApply={() => onApplyCode(currentFile, doneContent)} isToolCall={true} />
                                 ) : (
-                                  <div className="text-[11px] text-[#89d185] px-0.5">Written</div>
+                                  <div className={`text-[11px] px-0.5 ${isStreamOk ? 'text-[#89d185]' : 'text-[#f14c4c]'}`}>{isStreamOk ? 'Written' : 'Failed'}</div>
                                 )}
                               </div>
                             );
@@ -2811,7 +2836,7 @@ ${e.message}`,
                                     ? (typeof rdResult === 'object' ? JSON.stringify(rdResult, null, 2).substring(0, 600) : String(rdResult).substring(0, 600))
                                     : 'Completed';
                                   return (
-                                    <CollapsibleToolBlock key={`done-${i}`} label={getToolLabel(toolData, 'ok')} icon="✓">
+                                    <CollapsibleToolBlock key={`done-${i}`} label={getToolLabel(toolData, rdIsOk ? 'ok' : 'fail')} icon={rdIsOk ? '✓' : '✗'}>
                                       <div>
                                         {toolData.params && Object.keys(toolData.params).length > 0 && (
                                           <>