Skip to content

docs: clarify primary type labels are issues-only (PRs use ownership labels) (#31)#32

Merged
SamuelHassine merged 1 commit into
mainfrom
chore/labels-pr-clarification
Jun 7, 2026
Merged

docs: clarify primary type labels are issues-only (PRs use ownership labels) (#31)#32
SamuelHassine merged 1 commit into
mainfrom
chore/labels-pr-clarification

Conversation

@SamuelHassine

Copy link
Copy Markdown
Member

Summary

Clarifies the shared label taxonomy so it can never be misread (by a human or an automated reviewer):

  • Primary type labels (feature / bug / documentation) are applied to issues only, alongside the GitHub issue Type.
  • Pull requests do not carry a primary type label — the type: title prefix conveys the type. PRs should instead carry an ownership label (filigran team / community) to differentiate the author, plus any useful area/workflow labels.

Updated .github/LABELS.md, .github/labels.yml, and the CONTRIBUTING conventions block.

Closes #31

@SamuelHassine
SamuelHassine merged commit f16d7ac into main Jun 7, 2026
@SamuelHassine
SamuelHassine deleted the chore/labels-pr-clarification branch June 7, 2026 20:57
@SamuelHassine

Copy link
Copy Markdown
Member Author

🤖 [AI-generated]

Hey @SamuelHassine! 👋 I'm Sam, your convention guardian. I've reviewed PR #32 and here's a summary of what I checked and adjusted:


📝 Title

✅ Your title was already fully compliant — no change needed.

docs: clarify primary type labels are issues-only (PRs use ownership labels) (#31)

Valid docs type, lowercase imperative verb ("clarify"), correct proper-noun casing ("PRs"), no trailing period, and the required (#31) issue reference for a PR title. 🎯


🏷️ Labels

Action Label Reason
✅ Added filigran team Ownership label per .github/LABELS.md §2/§3 — PRs carry an ownership label (author is a Filigran org member), not a primary type label.

Note: no documentation type label was added — per the shared taxonomy, primary type labels (feature / bug / documentation) are applied to issues only. The docs: title prefix conveys the type on PRs.


📋 PR Description Quality

Overall: Good 🎉

Your PR description looks complete and well-structured. Great job! 🎉 It has a clear Summary, an itemized list of what's clarified, the exact files touched, and a Closes #31 linked-issue reference. For a docs change, no test evidence is required.


💡 For future PRs, please follow the contribution conventions and the title & label taxonomy.

Thanks for contributing! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: clarify primary type labels are issues-only (PRs use ownership labels)

1 participant