FirebaseArduino: switch to ArduinoHttpClient#353
Conversation
This allow the library to be portable across arduino core implementing the Client Interface. Fixes FirebaseExtended#344
|
You may remember this, but I wanted to remind you that for ESP8266 implementation, please be extra careful about our use of workaround for ESP8266 of modifying _canReuse even after it was set to false in Through these lines: We change _canReuse value early enough, so that before HTTPClient::end is called, it is set to true. We will need to have same workaround for ESP8266 implementation using ArduinoHttpClient if RTDB is still acting in the same way. |
|
@kotl Oh right, I forgot about this! We're lucky as It seems that |
|
@kotl did you give it a try? |
Preliminary work to port the library to use ArduinoHttpClient.
This will enable the library to be portable across arduino cores implementing the Client Interface.
Note this breaks the following libraries/sketches:
FirebaseCloudMessagingcontrib/modemcontrib/thingsAnd obsolete the following classes:
FirebaseFirebaseHttpClientTesting welcome 🎠
Related #344 #220
/cc @ed7coyne @kotl