Skip to content

Commit 3e267bf

Browse files
committed
tests: skip Issue161 test on Firebird 6
The Firebird 6 master snapshot in CI aborts parameterized EXECUTE PROCEDURE on the very first SQLExecute — "Stack overflow" on Windows, SEGFAULT on Linux — and every matrix job that runs against it fails on the new test. Locally the same test passes against the 6.0.0.1910 snapshot, and all FB 3 / 4 / 5 jobs pass green, so it isn't the Issue #161 driver fix itself that regresses. The repo already has a SKIP_ON_FIREBIRD6() macro for exactly this pre-existing parameterized- query incompatibility (see test_param_conversions.cpp's existing Char*-parameter tests); honour the same convention here until that path is rewritten. The underlying driver fix is still verified on FB 3 / 4 / 5 CI jobs and by the DuckDB odbc_copy_from reproduction.
1 parent fb356d6 commit 3e267bf

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

tests/test_param_conversions.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,14 @@ TEST_F(ParamConversionsTest, NumericAsCharParam) {
286286
// execute, so multi-digit values collapsed to a single character and most rows
287287
// were silently lost (odbc-scanner issue #161).
288288
TEST_F(ParamConversionsTest, Issue161_SLongToVarcharViaStoredProcedure) {
289+
// CI's Firebird-6 master snapshot aborts parameterized EXECUTE PROCEDURE
290+
// with "Stack overflow" (Windows) or SEGFAULT (Linux) on the very first
291+
// SQLExecute — the same parameterized-query regression already documented
292+
// by SKIP_ON_FIREBIRD6(). The underlying driver fix is exercised on FB 3
293+
// / 4 / 5 anyway, so punt this particular harness until the FB6
294+
// parameterized-query path is rewritten.
295+
SKIP_ON_FIREBIRD6();
296+
289297
// Provision the sandbox: a VARCHAR-keyed table and an UPDATE-OR-INSERT SP.
290298
ExecIgnoreError("EXECUTE BLOCK AS BEGIN "
291299
"IF (EXISTS(SELECT 1 FROM RDB$PROCEDURES WHERE RDB$PROCEDURE_NAME = 'ODBC_ISSUE161_SP')) THEN "

0 commit comments

Comments
 (0)