Skip to content

Commit 8ea653f

Browse files
committed
Remove continue-on-error from ASAN CI job
The heap-buffer-overflow in ConvertingString (sizeof(wchar_t) vs sizeof(SQLWCHAR)) has been fixed. ASAN now passes all 375 tests cleanly on ubuntu-22.04/GCC, so the soft-fail guard is no longer needed.
1 parent 832d8e7 commit 8ea653f

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

.github/workflows/build-and-test.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,11 @@ jobs:
5959
- os: ubuntu-22.04
6060
sanitizer: Asan
6161
firebird-version: '5.0.3'
62-
# ASAN found pre-existing memory bugs (e.g. heap-buffer-overflow in
63-
# OdbcError::sqlGetDiagRec). Allow failure until those are fixed.
64-
continue-on-error: true
6562
- os: ubuntu-22.04
6663
sanitizer: Valgrind
6764
firebird-version: '5.0.3'
6865

6966
runs-on: ${{ matrix.os }}
70-
continue-on-error: ${{ matrix.continue-on-error || false }}
7167

7268
steps:
7369
- uses: actions/checkout@v6

0 commit comments

Comments
 (0)