Skip to content

Commit 98115a1

Browse files
committed
Disable ASAN CI job until Linux widechar paths are fixed
Per #289 discussion with @irodushka: rather than keep ASAN running under continue-on-error, disable it outright until the Unicode rewrite lands (draft PR #291, tracked as #287 Tier 1b). Re-enable the matrix entry once #291 merges. Valgrind remains strict.
1 parent 09b934a commit 98115a1

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

.github/workflows/build-and-test.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,21 +56,19 @@ jobs:
5656
firebird-branch: master
5757

5858
# ── Linux x64 sanitizers (Debug, Firebird 5.0.3) ─────────────────────
59-
- os: ubuntu-22.04
60-
sanitizer: Asan
61-
firebird-version: '5.0.3'
59+
# ASAN is temporarily disabled — re-enable once the Linux widechar
60+
# conversion paths in MainUnicode.cpp are rewritten (#287 Tier 1b,
61+
# draft PR #291). Until then it fails on a heap-buffer-overflow in
62+
# SQLGetDiagRecW.
63+
# - os: ubuntu-22.04
64+
# sanitizer: Asan
65+
# firebird-version: '5.0.3'
6266
- os: ubuntu-22.04
6367
sanitizer: Valgrind
6468
firebird-version: '5.0.3'
6569

6670
runs-on: ${{ matrix.os }}
6771

68-
# Temporary: the ASAN job is expected to fail on the heap-buffer-overflow
69-
# inside SQLGetDiagRecW until the Linux widechar conversion paths in
70-
# MainUnicode.cpp are rewritten. Tracked in issue #287 Tier 1b. Revert
71-
# this back to strict once the Unicode fix PR lands.
72-
continue-on-error: ${{ matrix.sanitizer == 'Asan' }}
73-
7472
steps:
7573
- uses: actions/checkout@v6
7674
with:

0 commit comments

Comments
 (0)