Skip to content

Commit d1a651d

Browse files
committed
Remove continue-on-error from ASAN CI job
The heap-buffer-overflow in ConvertingString (sizeof(wchar_t) vs sizeof(SQLWCHAR)) has been fixed. ASAN now passes all 375 tests cleanly on ubuntu-22.04/GCC, so the soft-fail guard is no longer needed.
1 parent 636972b commit d1a651d

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

.github/workflows/build-and-test.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ jobs:
2424
- os: ubuntu-22.04
2525
config: Debug
2626
sanitizer: Asan
27-
# ASAN found pre-existing memory bugs (e.g. heap-buffer-overflow in
28-
# OdbcError::sqlGetDiagRec). Allow failure until those are fixed.
29-
continue-on-error: true
3027
- os: ubuntu-22.04
3128
config: Debug
3229
sanitizer: Valgrind

0 commit comments

Comments
 (0)