Closed
Conversation
Member
|
For the record: this work is already covered in #275. |
fdcastel
added a commit
to fdcastel/firebird-odbc-driver
that referenced
this pull request
Mar 21, 2026
- Fix OdbcJdbcSetup sources: Windows uses full GUI setup (17 files), Linux uses only OdbcInstGetProp.cpp (matching makefile.sources) - Exclude ResourceManagerSink.cpp and TransactionResourceAsync.cpp from Linux build (ATL-only) - Add -D_REENTRANT -D_PTHREADS -DEXTERNAL -DunixODBC for Linux (matching old makefile.linux compile flags) - Fix ODBC linking on Linux: use ODBC::ODBC target instead of empty ODBC_LIBRARIES variable - Change IscDbc from STATIC to OBJECT library (avoids unnecessary intermediate archive; objects consumed directly by OdbcFb) - Add CMAKE_BUILD_TYPE defaulting to Release (single-config generators) - Add per-config compiler optimization flags for GCC/Clang (Debug: -O0 -g3, Release: -O3 -ftree-loop-vectorize, etc.) - Add CPU architecture detection (x86, x86_64, ARM64, generic) with -msse4.1 for x86/x86_64 (from PR FirebirdSQL#248) CI workflow updates: - linux.yml: use CMake instead of deleted Gcc.lin makefiles - msbuild.yml: add cmake -B build step to fetch Firebird headers (required by updated .vcxproj include paths) - rpi_arm64.yml: use CMake instead of deleted Gcc.lin makefiles - All workflows: trigger on new-build-system branches + PRs
fdcastel
added a commit
to fdcastel/firebird-odbc-driver
that referenced
this pull request
Mar 21, 2026
Fix Linux build; address PR FirebirdSQL#281 review feedback - Fix OdbcJdbcSetup sources: Windows uses full GUI setup (17 files), Linux uses only OdbcInstGetProp.cpp (matching makefile.sources) - Exclude ResourceManagerSink.cpp and TransactionResourceAsync.cpp from Linux build (ATL-only) - Add -D_REENTRANT -D_PTHREADS -DEXTERNAL -DunixODBC for Linux (matching old makefile.linux compile flags) - Fix ODBC linking on Linux: use ODBC::ODBC target instead of empty ODBC_LIBRARIES variable - Change IscDbc from STATIC to OBJECT library (avoids unnecessary intermediate archive; objects consumed directly by OdbcFb) - Add CMAKE_BUILD_TYPE defaulting to Release (single-config generators) - Add per-config compiler optimization flags for GCC/Clang (Debug: -O0 -g3, Release: -O3 -ftree-loop-vectorize, etc.) - Add CPU architecture detection (x86, x86_64, ARM64, generic) with -msse4.1 for x86/x86_64 (from PR FirebirdSQL#248) CI workflow updates: - linux.yml: use CMake instead of deleted Gcc.lin makefiles - msbuild.yml: add cmake -B build step to fetch Firebird headers (required by updated .vcxproj include paths) - rpi_arm64.yml: use CMake instead of deleted Gcc.lin makefiles - All workflows: trigger on new-build-system branches + PRs
fdcastel
added a commit
to fdcastel/firebird-odbc-driver
that referenced
this pull request
Mar 21, 2026
… feedback - Fix OdbcJdbcSetup sources: Windows uses full GUI setup (17 files), Linux uses only OdbcInstGetProp.cpp (matching makefile.sources) - Exclude ResourceManagerSink.cpp and TransactionResourceAsync.cpp from Linux build (ATL-only) - Add -D_REENTRANT -D_PTHREADS -DEXTERNAL -DunixODBC for Linux (matching old makefile.linux compile flags) - Fix ODBC linking on Linux: use ODBC::ODBC target instead of empty ODBC_LIBRARIES variable - Change IscDbc from STATIC to OBJECT library (avoids unnecessary intermediate archive; objects consumed directly by OdbcFb) - Add CMAKE_BUILD_TYPE defaulting to Release (single-config generators) - Add per-config compiler optimization flags for GCC/Clang (Debug: -O0 -g3, Release: -O3 -ftree-loop-vectorize, etc.) - Add CPU architecture detection (x86, x86_64, ARM64, generic) with -msse4.1 for x86/x86_64 (from PR FirebirdSQL#248) CI workflow updates: - linux.yml: use CMake instead of deleted Gcc.lin makefiles - msbuild.yml: add cmake -B build step to fetch Firebird headers (required by updated .vcxproj include paths) - rpi_arm64.yml: use CMake instead of deleted Gcc.lin makefiles - All workflows: trigger on new-build-system branches + PRs
Contributor
Author
|
Closed as a dup - see PR#281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.