AggNodes.cpp

/*
 * The contents of this file are subject to the Interbase Public
 * License Version 1.0 (the "License"); you may not use this file
 * except in compliance with the License. You may obtain a copy
 * of the License at http://www.Inprise.com/IPL.html
 *
 * Software distributed under the License is distributed on an
 * "AS IS" basis, WITHOUT WARRANTY OF ANY KIND, either express
 * or implied. See the License for the specific language governing
 * rights and limitations under the License.
 *
 * The Original Code was created by Inprise Corporation
 * and its predecessors. Portions created by Inprise Corporation are
 * Copyright (C) Inprise Corporation.
 *
 * All Rights Reserved.
 * Contributor(s): ______________________________________.
 * Adriano dos Santos Fernandes - refactored from pass1.cpp, gen.cpp, cmp.cpp, par.cpp and evl.cpp
 */

#include "firebird.h"
#include "../dsql/AggNodes.h"
#include "../dsql/ExprNodes.h"
#include "../jrd/jrd.h"
#include "firebird/impl/blr.h"
#include "../jrd/btr.h"
#include "../jrd/exe.h"
#include "../jrd/tra.h"
#include "../jrd/recsrc/RecordSource.h"
#include "../jrd/blb_proto.h"
#include "../jrd/cmp_proto.h"
#include "../jrd/evl_proto.h"
#include "../jrd/intl_proto.h"
#include "../jrd/mov_proto.h"
#include "../jrd/par_proto.h"
#include "../dsql/ddl_proto.h"
#include "../dsql/errd_proto.h"
#include "../dsql/gen_proto.h"
#include "../dsql/make_proto.h"
#include "../dsql/pass1_proto.h"
#include "../dsql/utld_proto.h"
#include "../jrd/DataTypeUtil.h"
#include <math.h>

using namespace Firebird;
using namespace Jrd;

namespace Jrd {


static RegisterNode<AggNode> regAggNode({blr_agg_function});

AggNode::Factory* AggNode::factories = NULL;

AggNode::AggNode(MemoryPool& pool, const AggInfo& aAggInfo, bool aDistinct, bool aDialect1,
			ValueExprNode* aArg)
	: TypedNode<ValueExprNode, ExprNode::TYPE_AGGREGATE>(pool),
	  aggInfo(aAggInfo),
	  arg(aArg),
	  asb(NULL),
	  distinct(aDistinct),
	  dialect1(aDialect1),
	  indexed(false)
{
}

DmlNode* AggNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScratch* csb, const UCHAR /*blrOp*/)
{
	MetaName name;
	csb->csb_blr_reader.getMetaName(name);

	AggNode* node = NULL;

	for (const Factory* factory = factories; factory; factory = factory->next)
	{
		if (name == factory->name)
		{
			node = factory->newInstance(pool);
			break;
		}
	}

	if (!node)
		PAR_error(csb, Arg::Gds(isc_funnotdef) << name);

	const UCHAR count = csb->csb_blr_reader.getByte();

	NodeRefsHolder holder(pool);
	node->getChildren(holder, false);

	if (count != holder.refs.getCount())
		PAR_error(csb, Arg::Gds(isc_funmismat) << name);

	node->parseArgs(tdbb, csb, count);

	return node;
}

AggNode* AggNode::dsqlPass(DsqlCompilerScratch* dsqlScratch)
{
	if (dsqlScratch->isPsql())
	{
		ERRD_post(Arg::Gds(isc_sqlerr) << Arg::Num(-104) <<
				  Arg::Gds(isc_dsql_command_err));
	}

	if (!(dsqlScratch->inSelectList || dsqlScratch->inWhereClause || dsqlScratch->inGroupByClause ||
		  dsqlScratch->inHavingClause || dsqlScratch->inOrderByClause))
	{
		// not part of a select list, where clause, group by clause,
		// having clause, or order by clause
		ERRD_post(Arg::Gds(isc_sqlerr) << Arg::Num(-104) <<
				  Arg::Gds(isc_dsql_agg_ref_err));
	}

	AutoSetRestore<USHORT> autoInAggregateFunction(&dsqlScratch->inAggregateFunction,
		static_cast<USHORT>(dsqlScratch->inAggregateFunction + 1));

	return dsqlCopy(dsqlScratch);
}

string AggNode::internalPrint(NodePrinter& printer) const
{
	ValueExprNode::internalPrint(printer);

	NODE_PRINT(printer, distinct);
	NODE_PRINT(printer, dialect1);
	NODE_PRINT(printer, arg);
	NODE_PRINT(printer, asb);
	NODE_PRINT(printer, sort);
	NODE_PRINT(printer, indexed);

	return aggInfo.name;
}

bool AggNode::dsqlAggregateFinder(AggregateFinder& visitor)
{
	if (visitor.window || visitor.ignoreSubSelects)
		return false;

	bool aggregate = false;
	USHORT localDeepestLevel = 0;

	// If we are already in an aggregate function don't search inside
	// sub-selects and other aggregate-functions for the deepest field
	// used else we would have a wrong deepest_level value.

	{	// scope
		// We disable visiting of subqueries to handle this kind of query:
		//   select (select sum((select outer.column from inner1)) from inner2)
		//     from outer;
		AutoSetRestore<USHORT> autoDeepestLevel(&visitor.deepestLevel, 0);
		AutoSetRestore<bool> autoIgnoreSubSelects(&visitor.ignoreSubSelects, true);

		NodeRefsHolder holder(visitor.getPool());
		getChildren(holder, true);

		for (auto i : holder.refs)
			visitor.visit(*i);

		localDeepestLevel = visitor.deepestLevel;
	}

	if (localDeepestLevel == 0)
	{
		// ASF: There were no usage of a field of this scope [COUNT(*) or SUM(1)] or
		// they are inside a subquery [COUNT((select outer.field from inner))].

		// So the level found (deepestLevel) is the one of the current query in
		// processing.
		visitor.deepestLevel = visitor.currentLevel;
	}
	else
		visitor.deepestLevel = localDeepestLevel;

	// If the deepestLevel is the same as the current scopeLevel this is an
	// aggregate that belongs to the current context.
	if (visitor.deepestLevel == visitor.dsqlScratch->scopeLevel)
		aggregate = true;
	else
	{
		// Check also for a nested aggregate that could belong to this context. Example:
		//   select (select count(count(outer.n)) from inner) from outer

		AutoSetRestore<USHORT> autoDeepestLevel(&visitor.deepestLevel, localDeepestLevel);

		NodeRefsHolder holder(visitor.getPool());
		getChildren(holder, true);

		for (auto i : holder.refs)
			aggregate |= visitor.visit(*i);
	}

	return aggregate;
}

bool AggNode::dsqlAggregate2Finder(Aggregate2Finder& visitor)
{
	if (visitor.windowOnly)
		return false;

	bool found = false;
	FieldFinder fieldFinder(visitor.getPool(), visitor.checkScopeLevel, visitor.matchType);

	NodeRefsHolder holder(visitor.getPool());
	getChildren(holder, true);

	for (auto i : holder.refs)
		found |= fieldFinder.visit(*i);

	if (!fieldFinder.getField())
	{
		// For example COUNT(*) is always same scope_level (node->nod_count = 0)
		// Normally COUNT(*) is the only way to come here but something stupid
		// as SUM(5) is also possible.
		// If currentScopeLevelEqual is false scopeLevel is always higher
		switch (visitor.matchType)
		{
			case FIELD_MATCH_TYPE_LOWER_EQUAL:
			case FIELD_MATCH_TYPE_EQUAL:
				return visitor.currentScopeLevelEqual;

			///case FIELD_MATCH_TYPE_HIGHER_EQUAL:
			///	return true;

			case FIELD_MATCH_TYPE_LOWER:	// Not used here
			///case FIELD_MATCH_TYPE_HIGHER:
				fb_assert(false);
				return false;

			default:
				fb_assert(false);
		}
	}

	return found;
}

bool AggNode::dsqlInvalidReferenceFinder(InvalidReferenceFinder& visitor)
{
	bool invalid = false;

	if (!visitor.insideOwnMap)
	{
		// We are not in an aggregate from the same scope_level so
		// check for valid fields inside this aggregate
		invalid |= ExprNode::dsqlInvalidReferenceFinder(visitor);
	}

	if (!visitor.insideHigherMap)
	{
		NodeRefsHolder holder(visitor.dsqlScratch->getPool());
		getChildren(holder, true);

		for (auto i : holder.refs)
		{
			// If there's another aggregate with the same scope_level or
			// an higher one then it's a invalid aggregate, because
			// aggregate-functions from the same context can't
			// be part of each other.
			if (Aggregate2Finder::find(visitor.dsqlScratch->getPool(), visitor.context->ctx_scope_level,
					FIELD_MATCH_TYPE_EQUAL, false, *i))
			{
				// Nested aggregate functions are not allowed
				ERRD_post(Arg::Gds(isc_sqlerr) << Arg::Num(-104) <<
						  Arg::Gds(isc_dsql_agg_nested_err));
			}
		}
	}

	return invalid;
}

bool AggNode::dsqlSubSelectFinder(SubSelectFinder& /*visitor*/)
{
	return false;
}

ValueExprNode* AggNode::dsqlFieldRemapper(FieldRemapper& visitor)
{
	AggregateFinder aggFinder(visitor.getPool(), visitor.dsqlScratch, false);
	aggFinder.deepestLevel = visitor.dsqlScratch->scopeLevel;
	aggFinder.currentLevel = visitor.currentLevel;

	if (dsqlAggregateFinder(aggFinder))
	{
		if (!visitor.window && visitor.dsqlScratch->scopeLevel == aggFinder.deepestLevel)
			return PASS1_post_map(visitor.dsqlScratch, this, visitor.context, visitor.windowNode);
	}

	NodeRefsHolder holder(visitor.getPool());
	getChildren(holder, true);

	for (auto i : holder.refs)
	{
		if (*i)
			*i = (*i)->dsqlFieldRemapper(visitor);
	}

	return this;
}

bool AggNode::dsqlMatch(DsqlCompilerScratch* dsqlScratch, const ExprNode* other, bool ignoreMapCast) const
{
	if (!ExprNode::dsqlMatch(dsqlScratch, other, ignoreMapCast))
		return false;

	const AggNode* o = nodeAs<AggNode>(other);
	fb_assert(o);

	// ASF: We compare name address. That should be ok, as we have only one AggInfo instance
	// per function.
	return aggInfo.blr == o->aggInfo.blr && aggInfo.name == o->aggInfo.name &&
		distinct == o->distinct && dialect1 == o->dialect1;
}

void AggNode::setParameterName(dsql_par* parameter) const
{
	parameter->par_name = parameter->par_alias = aggInfo.name;
}

void AggNode::genBlr(DsqlCompilerScratch* dsqlScratch)
{
	NodeRefsHolder holder(dsqlScratch->getPool());
	getChildren(holder, true);

	if (aggInfo.blr)	// Is this a standard aggregate function?
		dsqlScratch->appendUChar((distinct ? aggInfo.distinctBlr : aggInfo.blr));
	else	// This is a new window function.
	{
		dsqlScratch->appendUChar(blr_agg_function);
		dsqlScratch->appendNullString(aggInfo.name);

		unsigned count = 0;

		for (auto i : holder.refs)
		{
			if (*i)
				++count;
		}

		dsqlScratch->appendUChar(UCHAR(count));
	}

	for (auto i : holder.refs)
	{
		if (*i)
			GEN_expr(dsqlScratch, *i);
	}
}

AggNode* AggNode::pass2(thread_db* tdbb, CompilerScratch* csb)
{
	ValueExprNode::pass2(tdbb, csb);

	dsc desc;
	getDesc(tdbb, csb, &desc);
	impureOffset = csb->allocImpure<impure_value_ex>();
	if (sort)
		doPass2(tdbb, csb, sort.getAddress());

	return this;
}

void AggNode::makeSortDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);
}

void AggNode::aggInit(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	impure->vlux_count = 0;

	if (distinct || sort)
	{
		// Initialize a sort to reject duplicate values.

		impure_agg_sort* asbImpure = request->getImpure<impure_agg_sort>(asb->impure);

		// Get rid of the old sort areas if this request has been used already.
		delete asbImpure->iasb_sort;
		asbImpure->iasb_sort = NULL;

		asbImpure->iasb_sort = FB_NEW_POOL(request->req_sorts.getPool()) Sort(
			tdbb->getDatabase(), &request->req_sorts, asb->length,
			asb->keyItems.getCount(), (distinct ? 1 : asb->keyItems.getCount()),
			asb->keyItems.begin(), (distinct ? RecordSource::rejectDuplicate : nullptr), 0);
	}
}

bool AggNode::aggPass(thread_db* tdbb, Request* request) const
{
	dsc* desc = NULL;

	if (arg)
	{
		desc = EVL_expr(tdbb, request, arg);
		if (!desc)
			return false;

		if (distinct)
		{
			fb_assert(asb);

			// "Put" the value to sort.
			impure_agg_sort* asbImpure = request->getImpure<impure_agg_sort>(asb->impure);
			UCHAR* data;
			asbImpure->iasb_sort->put(tdbb, reinterpret_cast<ULONG**>(&data));

			MOVE_CLEAR(data, asb->length);

			if (asb->intl)
			{
				// Convert to an international byte array.
				dsc to;
				to.dsc_dtype = dtype_text;
				to.dsc_flags = 0;
				to.dsc_sub_type = 0;
				to.dsc_scale = 0;
				to.setTextType(ttype_sort_key);
				to.dsc_length = asb->keyItems[0].getSkdLength();
				to.dsc_address = data;
				INTL_string_to_key(tdbb, INTL_TEXT_TO_INDEX(desc->getTextType()),
					desc, &to, INTL_KEY_UNIQUE);
			}

			dsc toDesc = asb->desc;
			toDesc.dsc_address = data +
				(asb->intl ? asb->keyItems[1].getSkdOffset() : 0);
			MOV_move(tdbb, desc, &toDesc);

			// dimitr:	Here we add a monotonically increasing value to the sort record.
			// 			It allows the record to look more random than it was originally.
			//			This helps the quick sort algorithm to avoid the worst-case of
			//			all equal values (see CORE-214).

			ULONG* const pDummy = reinterpret_cast<ULONG*>(data + asb->length - sizeof(ULONG));
			*pDummy = asbImpure->iasb_dummy++;

			return true;
		}
		else if (sort)
		{
			fb_assert(asb);
			// "Put" the value to sort.
			impure_agg_sort* asbImpure = request->getImpure<impure_agg_sort>(asb->impure);
			UCHAR* data;
			asbImpure->iasb_sort->put(tdbb, reinterpret_cast<ULONG**>(&data));

			MOVE_CLEAR(data, asb->length);

			auto descOrder = asb->descOrder.begin();
			auto keyItem = asb->keyItems.begin();

			for (auto& nodeOrder : sort->expressions)
			{
				dsc toDesc = *(descOrder++);
				toDesc.dsc_address = data + (IPTR) toDesc.dsc_address;
				if (const auto fromDsc = EVL_expr(tdbb, request, nodeOrder))
				{
					if (IS_INTL_DATA(fromDsc))
					{
						INTL_string_to_key(tdbb, INTL_TEXT_TO_INDEX(fromDsc->getTextType()),
							fromDsc, &toDesc, INTL_KEY_UNIQUE);
					}
					else
						MOV_move(tdbb, fromDsc, &toDesc);
				}
				else
					*(data + keyItem->getSkdOffset()) = TRUE;

				// The first key for NULLS FIRST/LAST, the second key for the sorter
				keyItem += 2;
			}

			dsc toDesc = asb->desc;
			toDesc.dsc_address = data + (IPTR) toDesc.dsc_address;
			MOV_move(tdbb, desc, &toDesc);

			return true;
		}
	}

	aggPass(tdbb, request, desc);
	return true;
}

void AggNode::aggFinish(thread_db* /*tdbb*/, Request* request) const
{
	if (asb)
	{
		impure_agg_sort* const asbImpure = request->getImpure<impure_agg_sort>(asb->impure);
		delete asbImpure->iasb_sort;
		asbImpure->iasb_sort = NULL;
	}
}

dsc* AggNode::execute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (impure->vlu_blob)
	{
		impure->vlu_blob->BLB_close(tdbb);
		impure->vlu_blob = NULL;
	}

	if (distinct || sort)
	{
		impure_agg_sort* asbImpure = request->getImpure<impure_agg_sort>(asb->impure);
		dsc desc = asb->desc;

		// Sort the values already "put" to sort.
		asbImpure->iasb_sort->sort(tdbb);

		// Now get the sorted/projected values and compute the aggregate.

		while (true)
		{
			UCHAR* data;
			asbImpure->iasb_sort->get(tdbb, reinterpret_cast<ULONG**>(&data));

			if (!data)
			{
				// We are done, close the sort.
				delete asbImpure->iasb_sort;
				asbImpure->iasb_sort = NULL;
				break;
			}

			if (distinct)
				desc.dsc_address = data + (asb->intl ? asb->keyItems[1].getSkdOffset() : 0);
			else
				desc.dsc_address = data + (IPTR) asb->desc.dsc_address;

			aggPass(tdbb, request, &desc);
		}
	}

	return aggExecute(tdbb, request);
}


//--------------------


static AggNode::RegisterFactory0<AnyValueAggNode> anyValueAggInfo("ANY_VALUE");

AnyValueAggNode::AnyValueAggNode(MemoryPool& pool, ValueExprNode* aArg)
	: AggNode(pool, anyValueAggInfo, false, false, aArg)
{
}

DmlNode* AnyValueAggNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScratch* csb, const UCHAR /*blrOp*/)
{
	const auto node = FB_NEW_POOL(pool) AnyValueAggNode(pool);
	node->arg = PAR_parse_value(tdbb, csb);
	return node;
}

void AnyValueAggNode::parseArgs(thread_db* tdbb, CompilerScratch* csb, unsigned /*count*/)
{
	arg = PAR_parse_value(tdbb, csb);
}

void AnyValueAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg, true);
}

void AnyValueAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);
}

ValueExprNode* AnyValueAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	const auto node = FB_NEW_POOL(*tdbb->getDefaultPool()) AnyValueAggNode(*tdbb->getDefaultPool());
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	return node;
}

string AnyValueAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	return "AnyValueAggNode";
}

void AnyValueAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	const auto impure = request->getImpure<impure_value_ex>(impureOffset);
	impure->vlu_desc.dsc_dtype = 0;
}

void AnyValueAggNode::aggPass(thread_db* tdbb, Request* request, dsc* desc) const
{
	const auto impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlu_desc.dsc_dtype)
	{
		const auto argValue = EVL_expr(tdbb, request, arg);

		if (argValue)
			EVL_make_value(tdbb, argValue, impure);
	}

}

dsc* AnyValueAggNode::aggExecute(thread_db* /*tdbb*/, Request* request) const
{
	const auto impure = request->getImpure<impure_value_ex>(impureOffset);

	if (impure->vlu_desc.dsc_dtype)
		return &impure->vlu_desc;

	return nullptr;
}

AggNode* AnyValueAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) AnyValueAggNode(dsqlScratch->getPool(),
		doDsqlPass(dsqlScratch, arg));
}


//--------------------


static AggNode::Register<AvgAggNode> avgAggInfo("AVG", blr_agg_average, blr_agg_average_distinct);

AvgAggNode::AvgAggNode(MemoryPool& pool, bool aDistinct, bool aDialect1, ValueExprNode* aArg)
	: AggNode(pool, avgAggInfo, aDistinct, aDialect1, aArg),
	  tempImpure(0)
{
}

DmlNode* AvgAggNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScratch* csb, const UCHAR blrOp)
{
	AvgAggNode* node = FB_NEW_POOL(pool) AvgAggNode(pool,
		(blrOp == blr_agg_average_distinct),
		(csb->blrVersion == 4));
	node->arg = PAR_parse_value(tdbb, csb);
	return node;
}

void AvgAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg, true);

	if (desc->isNull())
		return;

	if (DTYPE_IS_DECFLOAT(desc->dsc_dtype))
		return;

	if (dialect1)
	{
		if (!DTYPE_IS_NUMERIC(desc->dsc_dtype) && !DTYPE_IS_TEXT(desc->dsc_dtype))
		{
			ERRD_post(Arg::Gds(isc_expression_eval_err) <<
					  Arg::Gds(isc_dsql_agg_wrongarg) << Arg::Str("AVG"));
		}
		else if (DTYPE_IS_TEXT(desc->dsc_dtype))
		{
			desc->dsc_dtype = dtype_double;
			desc->dsc_length = sizeof(double);
		}
	}
	else
	{
		if (!DTYPE_IS_NUMERIC(desc->dsc_dtype))
		{
			ERRD_post(Arg::Gds(isc_expression_eval_err) <<
					  Arg::Gds(isc_dsql_agg2_wrongarg) << Arg::Str("AVG"));
		}
		else if (desc->dsc_dtype == dtype_int128)
		{
			desc->dsc_dtype = dtype_int128;
			desc->dsc_length = sizeof(Int128);
		}
		else if (DTYPE_IS_EXACT(desc->dsc_dtype))
		{
			desc->dsc_dtype = dtype_int64;
			desc->dsc_length = sizeof(SINT64);
		}
		else
		{
			desc->dsc_dtype = dtype_double;
			desc->dsc_length = sizeof(double);
		}
	}
}

void AvgAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);
	outputDesc(desc);

	switch (desc->dsc_dtype)
	{
		case dtype_dec64:
		case dtype_dec128:
			nodFlags |= FLAG_DECFLOAT;
			break;

		case dtype_int64:
		case dtype_int128:
			nodFlags |= FLAG_INT128;
			// fall down...
		case dtype_short:
		case dtype_long:
			nodScale = desc->dsc_scale;
			break;

		case dtype_unknown:
			break;

		default:
			nodFlags |= FLAG_DOUBLE;
			break;
	}
}

void AvgAggNode::outputDesc(dsc* desc) const
{
	if (DTYPE_IS_DECFLOAT(desc->dsc_dtype))
	{
		desc->dsc_scale = 0;
		desc->dsc_sub_type = 0;
		desc->dsc_flags = 0;
		return;
	}

	if (dialect1)
	{
		if (!(DTYPE_IS_NUMERIC(desc->dsc_dtype) || DTYPE_IS_TEXT(desc->dsc_dtype)))
		{
			if (desc->dsc_dtype != dtype_unknown)
				ERR_post(Arg::Gds(isc_datype_notsup));	// data type not supported for arithmetic
		}

		desc->dsc_dtype = DEFAULT_DOUBLE;
		desc->dsc_length = sizeof(double);
		desc->dsc_scale = 0;
		desc->dsc_sub_type = 0;
		desc->dsc_flags = 0;
		return;
	}

	switch (desc->dsc_dtype)
	{
		case dtype_short:
		case dtype_long:
		case dtype_int64:
			desc->dsc_dtype = dtype_int64;
			desc->dsc_length = sizeof(SINT64);
			desc->dsc_flags = 0;
			break;

		case dtype_int128:
			desc->dsc_dtype = dtype_int128;
			desc->dsc_length = sizeof(Int128);
			desc->dsc_flags = 0;
			break;

		case dtype_unknown:
			desc->dsc_dtype = dtype_unknown;
			desc->dsc_length = 0;
			desc->dsc_scale = 0;
			desc->dsc_sub_type = 0;
			desc->dsc_flags = 0;
			break;

		default:
			if (!DTYPE_IS_NUMERIC(desc->dsc_dtype))
			{
				if (desc->dsc_dtype == dtype_quad)
					IBERROR(224);	// msg 224 quad word arithmetic not supported

				ERR_post(Arg::Gds(isc_datype_notsup));	// data type not supported for arithmetic
			}

			desc->dsc_dtype = DEFAULT_DOUBLE;
			desc->dsc_length = sizeof(double);
			desc->dsc_scale = 0;
			desc->dsc_sub_type = 0;
			desc->dsc_flags = 0;
			break;
	}
}

ValueExprNode* AvgAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	AvgAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) AvgAggNode(*tdbb->getDefaultPool(),
		distinct, dialect1);
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	return node;
}

AggNode* AvgAggNode::pass2(thread_db* tdbb, CompilerScratch* csb)
{
	AggNode::pass2(tdbb, csb);

	if (dialect1 && !(nodFlags & FLAG_DECFLOAT))
		nodFlags |= FLAG_DOUBLE;

	// We need a second descriptor in the impure area for AVG.
	tempImpure = csb->allocImpure<impure_value_ex>();

	return this;
}

string AvgAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, tempImpure);

	return "AvgAggNode";
}

void AvgAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (dialect1)
	{
		impure->vlu_desc.makeDouble(&impure->vlu_misc.vlu_double);
		impure->vlu_misc.vlu_double = 0;
	}
	else
	{
		// Initialize the result area as an int64. If the field being aggregated is approximate
		// numeric, the first call to add will convert the descriptor.
		impure->make_int64(0, nodScale);
	}
}

void AvgAggNode::aggPass(thread_db* tdbb, Request* request, dsc* desc) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	if (impure->vlux_count++ == 0)		// first call to aggPass()
	{
		impure_value_ex* impureTemp = request->getImpure<impure_value_ex>(tempImpure);
		impureTemp->vlu_desc = *desc;
		outputDesc(&impureTemp->vlu_desc);
	}

	ArithmeticNode::add(tdbb, desc, &impure->vlu_desc, impure, blr_add, dialect1, nodScale, nodFlags);
}

dsc* AvgAggNode::aggExecute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlux_count)
		return NULL;

	dsc temp;
	SINT64 i;
	double d;
	Decimal128 dec;
	Decimal64 d64;
	Int128 i128;

	impure_value_ex* impureTemp = request->getImpure<impure_value_ex>(tempImpure);
	UCHAR dtype = impureTemp->vlu_desc.dsc_dtype;

	if (!dialect1 && impure->vlu_desc.dsc_dtype == dtype_int64)
	{
		i = *((SINT64*) impure->vlu_desc.dsc_address) / impure->vlux_count;
		temp.makeInt64(impure->vlu_desc.dsc_scale, &i);
	}
	else if (!dialect1 && impure->vlu_desc.dsc_dtype == dtype_int128)
	{
		i128.set(impure->vlux_count, 0);
		i128 = ((Int128*) impure->vlu_desc.dsc_address)->div(i128, 0);
		if (dtype == dtype_int128)
			temp.makeInt128(impure->vlu_desc.dsc_scale, &i128);
		else
		{
			fb_assert(dtype == dtype_int64);
			i = i128.toInt64(0);
			temp.makeInt64(impure->vlu_desc.dsc_scale, &i);
		}
	}
	else if (dtype == dtype_dec128)
	{
		DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
		dec.set(impure->vlux_count, decSt, 0);
		dec = MOV_get_dec128(tdbb, &impure->vlu_desc).div(decSt, dec);
		temp.makeDecimal128(&dec);
	}
	else if (dtype == dtype_dec64)
	{
		DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
		// use higher precision for division
		dec.set(impure->vlux_count, decSt, 0);
		d64 = MOV_get_dec128(tdbb, &impure->vlu_desc).div(decSt, dec).toDecimal64(decSt);
		temp.makeDecimal64(&d64);
	}
	else
	{
		d = MOV_get_double(tdbb, &impure->vlu_desc) / impure->vlux_count;
		temp.makeDouble(&d);
	}

	EVL_make_value(tdbb, &temp, impureTemp);

	return &impureTemp->vlu_desc;
}

AggNode* AvgAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) AvgAggNode(dsqlScratch->getPool(), distinct, dialect1,
		doDsqlPass(dsqlScratch, arg));
}


//--------------------


static AggNode::Register<ListAggNode> listAggInfo("LIST", blr_agg_list, blr_agg_list_distinct);

ListAggNode::ListAggNode(MemoryPool& pool, bool aDistinct, ValueExprNode* aArg,
			ValueExprNode* aDelimiter, ValueListNode* aOrderClause)
	: AggNode(pool, listAggInfo, aDistinct, false, aArg),
	  delimiter(aDelimiter),
	  dsqlOrderClause(aOrderClause)
{
}

DmlNode* ListAggNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScratch* csb, const UCHAR blrOp)
{
	ListAggNode* node = FB_NEW_POOL(pool) ListAggNode(pool,	(blrOp == blr_agg_list_distinct));
	node->arg = PAR_parse_value(tdbb, csb);
	node->delimiter = PAR_parse_value(tdbb, csb);
	if (csb->csb_blr_reader.peekByte() == blr_within_group_order)
	{
		csb->csb_blr_reader.getByte(); // skip blr_within_group_order
		if (const auto count = csb->csb_blr_reader.getByte())
			node->sort = PAR_sort_internal(tdbb, csb, true, count);
	}

	return node;
}

bool ListAggNode::dsqlMatch(DsqlCompilerScratch* dsqlScratch, const ExprNode* other, bool ignoreMapCast) const
{
	if (!AggNode::dsqlMatch(dsqlScratch, other, ignoreMapCast))
		return false;

	const ListAggNode* o = nodeAs<ListAggNode>(other);
	fb_assert(o);

	if (dsqlOrderClause || o->dsqlOrderClause)
		return PASS1_node_match(dsqlScratch, dsqlOrderClause, o->dsqlOrderClause, ignoreMapCast);

	return true;
}

void ListAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg);
	desc->makeBlob(desc->getBlobSubType(), desc->getTextType());
	desc->setNullable(true);
}

void ListAggNode::genBlr(DsqlCompilerScratch* dsqlScratch)
{
	AggNode::genBlr(dsqlScratch);
	if (dsqlOrderClause)
		GEN_sort(dsqlScratch, blr_within_group_order, dsqlOrderClause);
}

bool ListAggNode::setParameterType(DsqlCompilerScratch* dsqlScratch,
	std::function<void (dsc*)> makeDesc, bool forceVarChar)
{
	const bool argType = PASS1_set_parameter_type(dsqlScratch, arg, makeDesc, forceVarChar);
	const bool delimiterType = PASS1_set_parameter_type(dsqlScratch, delimiter, makeDesc, forceVarChar);
	return argType || delimiterType;
}

void ListAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);
	desc->makeBlob(desc->getBlobSubType(), desc->getTextType());
}

ValueExprNode* ListAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	ListAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) ListAggNode(*tdbb->getDefaultPool(), distinct);

	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	node->delimiter = copier.copy(tdbb, delimiter);

	if (sort)
		node->sort = sort->copy(tdbb, copier);

	return node;
}

string ListAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, delimiter);

	return "ListAggNode";
}

void ListAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	// We don't know here what should be the sub-type and text-type.
	// Defer blob creation for when first record is found.
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	impure->vlu_blob = NULL;
	impure->vlu_desc.dsc_dtype = 0;
}

void ListAggNode::aggPass(thread_db* tdbb, Request* request, dsc* desc) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlu_blob)
	{
		impure->vlu_blob = blb::create(tdbb, request->req_transaction,
			&impure->vlu_misc.vlu_bid);
		impure->vlu_desc.makeBlob(desc->getBlobSubType(), desc->getTextType(),
			(ISC_QUAD*) &impure->vlu_misc.vlu_bid);
	}

	MoveBuffer buffer;
	UCHAR* temp;
	int len;

	if (impure->vlux_count)
	{
		const dsc* const delimiterDesc = EVL_expr(tdbb, request, delimiter);

		if (!delimiterDesc)
		{
			// Mark the result as NULL.
			impure->vlu_desc.dsc_dtype = 0;
			return;
		}

		len = MOV_make_string2(tdbb, delimiterDesc, impure->vlu_desc.getTextType(),
			&temp, buffer, false);
		impure->vlu_blob->BLB_put_data(tdbb, temp, len);
	}

	++impure->vlux_count;
	len = MOV_make_string2(tdbb, desc, impure->vlu_desc.getTextType(),
		&temp, buffer, false);
	impure->vlu_blob->BLB_put_data(tdbb, temp, len);
}

dsc* ListAggNode::aggExecute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (distinct || sort)
	{
		if (impure->vlu_blob)
		{
			impure->vlu_blob->BLB_close(tdbb);
			impure->vlu_blob = NULL;
		}
	}

	if (!impure->vlux_count || !impure->vlu_desc.dsc_dtype)
		return NULL;

	return &impure->vlu_desc;
}

AggNode* ListAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	thread_db* tdbb = JRD_get_thread_data();

	AggNode* node = FB_NEW_POOL(dsqlScratch->getPool()) ListAggNode(dsqlScratch->getPool(), distinct,
		doDsqlPass(dsqlScratch, arg), doDsqlPass(dsqlScratch, delimiter),
		doDsqlPass(dsqlScratch, dsqlOrderClause));

	dsc argDesc;
	node->arg->make(dsqlScratch, &argDesc);

	CharSet* charSet = INTL_charset_lookup(tdbb, argDesc.getCharSet());

	node->setParameterType(dsqlScratch,
		[&] (dsc* desc) { desc->makeText(charSet->maxBytesPerChar(), argDesc.getCharSet()); },
		false);

	return node;
}


//--------------------


static AggNode::RegisterFactory1<PercentileAggNode, PercentileAggNode::PercentileType> percentileContAggInfo(
	"PERCENTILE_CONT", PercentileAggNode::TYPE_PERCENTILE_CONT);
static AggNode::RegisterFactory1<PercentileAggNode, PercentileAggNode::PercentileType> percentileDiscAggInfo(
	"PERCENTILE_DISC", PercentileAggNode::TYPE_PERCENTILE_DISC);

PercentileAggNode::PercentileAggNode(MemoryPool& pool, PercentileType aType, ValueExprNode* aArg,
	ValueListNode* aOrderClause)
	: AggNode(pool,
		(aType == PercentileAggNode::TYPE_PERCENTILE_CONT ? percentileContAggInfo : percentileDiscAggInfo),
		false, false, aArg),
	type(aType),
	valueArg(nullptr),
	dsqlOrderClause(aOrderClause)
{
	if (dsqlOrderClause)
		valueArg = nodeAs<OrderNode>(dsqlOrderClause->items[0])->value;
}

void PercentileAggNode::parseArgs(thread_db* tdbb, CompilerScratch* csb, unsigned /*count*/)
{
	arg = PAR_parse_value(tdbb, csb);
	valueArg = PAR_parse_value(tdbb, csb);
	if (csb->csb_blr_reader.peekByte() == blr_within_group_order)
	{
		csb->csb_blr_reader.getByte(); // skip blr_within_group_order
		if (const auto count = csb->csb_blr_reader.getByte())
			sort = PAR_sort_internal(tdbb, csb, true, count);
	}
}

bool PercentileAggNode::dsqlMatch(DsqlCompilerScratch* dsqlScratch, const ExprNode* other, bool ignoreMapCast) const
{
	if (!AggNode::dsqlMatch(dsqlScratch, other, ignoreMapCast))
		return false;

	const PercentileAggNode* o = nodeAs<PercentileAggNode>(other);
	fb_assert(o);
	return PASS1_node_match(dsqlScratch, dsqlOrderClause, o->dsqlOrderClause, ignoreMapCast);
}

void PercentileAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	fb_assert(dsqlOrderClause);
	if (dsqlOrderClause->items.getCount() != 1)
	{
		ERR_post(Arg::Gds(isc_percetile_only_one_sort_item));
	}

	if (type == TYPE_PERCENTILE_DISC)
	{
		// same type as order by argument
		DsqlDescMaker::fromNode(dsqlScratch, desc, valueArg, true);
	}
	else
	{
		DsqlDescMaker::fromNode(dsqlScratch, desc, valueArg, true);
		if (desc->isDecOrInt128())
		{
			desc->makeDecimal128();
			desc->setNullable(true);
		}
		else
		{
			desc->makeDouble();
			desc->setNullable(true);
		}
	}
}

void PercentileAggNode::genBlr(DsqlCompilerScratch* dsqlScratch)
{
	AggNode::genBlr(dsqlScratch);
	if (dsqlOrderClause)
		GEN_sort(dsqlScratch, blr_within_group_order, dsqlOrderClause);
}

void PercentileAggNode::makeSortDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	valueArg->getDesc(tdbb, csb, desc);
}

void PercentileAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	if (type == TYPE_PERCENTILE_DISC)
	{
		// same type as order by argument
		valueArg->getDesc(tdbb, csb, desc);
	}
	else
	{
		valueArg->getDesc(tdbb, csb, desc);
		if (desc->isDecOrInt128())
		{
			desc->makeDecimal128();
			desc->setNullable(true);
		}
		else
		{
			desc->makeDouble();
			desc->setNullable(true);
		}
	}
}

ValueExprNode* PercentileAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	PercentileAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) PercentileAggNode(*tdbb->getDefaultPool(), type);

	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	node->valueArg = copier.copy(tdbb, valueArg);
	node->sort = sort->copy(tdbb, copier);

	return node;
}

AggNode* PercentileAggNode::pass2(thread_db* tdbb, CompilerScratch* csb)
{
	AggNode::pass2(tdbb, csb);

	// impure area for calculate border
	percentileImpureOffset = csb->allocImpure<PercentileImpure>();

	return this;
}

bool PercentileAggNode::dsqlInvalidReferenceFinder(InvalidReferenceFinder& visitor)
{
	bool invalid = false;

	if (!visitor.insideOwnMap)
	{
		// We are not in an aggregate from the same scope_level so
		// check for valid fields inside this aggregate
		invalid |= ExprNode::dsqlInvalidReferenceFinder(visitor);
	}

	if (!visitor.insideHigherMap)
	{
		NodeRefsHolder holder(visitor.dsqlScratch->getPool());
		getChildren(holder, true);

		for (auto i : holder.refs)
		{
			// If there's another aggregate with the same scope_level or
			// an higher one then it's a invalid aggregate, because
			// aggregate-functions from the same context can't
			// be part of each other.
			if (Aggregate2Finder::find(visitor.dsqlScratch->getPool(), visitor.context->ctx_scope_level,
				FIELD_MATCH_TYPE_EQUAL, false, *i))
			{
				// Nested aggregate functions are not allowed
				ERRD_post(Arg::Gds(isc_sqlerr) << Arg::Num(-104) <<
					Arg::Gds(isc_dsql_agg_nested_err));
			}
		}

		if (visitor.visit(**holder.refs.begin()))
		{
			// The percent argument must be constant within group
			ERRD_post(Arg::Gds(isc_sqlerr) << Arg::Num(-104) <<
				Arg::Gds(isc_argmustbe_const_within_group) <<
				((type == TYPE_PERCENTILE_CONT) ? Arg::Str("PERCENTILE_CONT") : Arg::Str("PERCENTILE_DISC")));
		}
	}

	return invalid;
}

string PercentileAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, type);

	return "PercentileAggNode";
}


void PercentileAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	impure->vlu_desc.dsc_dtype = 0;
	impure->vlux_count = 0;

	PercentileImpure* percentileImpure = request->getImpure<PercentileImpure>(percentileImpureOffset);
	percentileImpure->vlux_count = 0;
	percentileImpure->rn = 0;
	percentileImpure->crn = 0;
	percentileImpure->frn = 0;
}

bool PercentileAggNode::aggPass(thread_db* tdbb, Request* request) const
{
	dsc* percenteDesc = nullptr;
	percenteDesc = EVL_expr(tdbb, request, arg);
	if (!percenteDesc)
		return false;

	dsc* desc = nullptr;
	desc = EVL_expr(tdbb, request, valueArg);
	if (!desc)
		return false;

	PercentileImpure* percentileImpure = request->getImpure<PercentileImpure>(percentileImpureOffset);
	if (percentileImpure->vlux_count++ == 0)		// first call to aggPass()
	{
		if ((type == TYPE_PERCENTILE_CONT) && !desc->isNumeric())
			ERRD_post(Arg::Gds(isc_argmustbe_numeric_function) << Arg::Str("PERCENTILE_CONT"));

		if (desc->isBlob())
			ERRD_post(Arg::Gds(isc_blobnotsup) << Arg::Str("ORDER BY"));

		const auto percentileValue = MOV_get_double(tdbb, percenteDesc);
		if ((percentileValue < 0) || (percentileValue > 1))
		{
			if (type == TYPE_PERCENTILE_DISC)
				ERRD_post(Arg::Gds(isc_sysf_argmustbe_range_inc0_1) << Arg::Str("PERCENTILE_DISC"));
			else
				ERRD_post(Arg::Gds(isc_sysf_argmustbe_range_inc0_1) << Arg::Str("PERCENTILE_CONT"));
		}

		percentileImpure->percentile = percentileValue;
	}

	if (sort)
	{
		fb_assert(asb);
		// "Put" the value to sort.
		impure_agg_sort* asbImpure = request->getImpure<impure_agg_sort>(asb->impure);
		UCHAR* data;
		asbImpure->iasb_sort->put(tdbb, reinterpret_cast<ULONG**>(&data));

		MOVE_CLEAR(data, asb->length);

		auto descOrder = asb->descOrder.begin();
		auto keyItem = asb->keyItems.begin();

		for (auto& nodeOrder : sort->expressions)
		{
			dsc toDesc = *(descOrder++);
			toDesc.dsc_address = data + (IPTR) toDesc.dsc_address;
			if (const auto fromDsc = EVL_expr(tdbb, request, nodeOrder))
			{
				if (IS_INTL_DATA(fromDsc))
				{
					INTL_string_to_key(tdbb, INTL_TEXT_TO_INDEX(fromDsc->getTextType()),
						fromDsc, &toDesc, INTL_KEY_UNIQUE);
				}
				else
					MOV_move(tdbb, fromDsc, &toDesc);
			}
			else
				*(data + keyItem->getSkdOffset()) = TRUE;

			// The first key for NULLS FIRST/LAST, the second key for the sorter
			keyItem += 2;
		}

		dsc toDesc = asb->desc;
		toDesc.dsc_address = data + (IPTR) toDesc.dsc_address;
		MOV_move(tdbb, desc, &toDesc);

		return true;
	}

	return true;
}

void PercentileAggNode::aggPass(thread_db* tdbb, Request* request, dsc* desc) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	PercentileImpure* percentileImpure = request->getImpure<PercentileImpure>(percentileImpureOffset);

	if (type == TYPE_PERCENTILE_DISC)
	{
		if (impure->vlux_count++ == 0)
		{
			// calculate only ones
			percentileImpure->rn = percentileImpure->percentile * percentileImpure->vlux_count;
			percentileImpure->crn = MAX(static_cast<SINT64>(ceil(percentileImpure->rn)), 1);
		}

		if (impure->vlux_count == percentileImpure->crn)
			EVL_make_value(tdbb, desc, impure);

	}
	else
	{
		if (impure->vlux_count++ == 0)
		{
			// calculate only ones
			percentileImpure->rn = 1 + percentileImpure->percentile * (percentileImpure->vlux_count - 1);
			percentileImpure->crn = static_cast<SINT64>(ceil(percentileImpure->rn));
			percentileImpure->frn = static_cast<SINT64>(floor(percentileImpure->rn));

			if (desc->isDecOrInt128())
			{
				DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
				Firebird::Decimal128 d128;
				d128.set(0, decSt, 0);
				impure->make_decimal128(d128);
			}
			else
				impure->make_double(0);
		}

		if (percentileImpure->crn == percentileImpure->frn)
		{
			if (impure->vlux_count == percentileImpure->frn)
			{
				if (desc->isDecOrInt128())
				{
					const auto value = MOV_get_dec128(tdbb, desc);
					impure->make_decimal128(value);
				}
				else
				{
					const auto value = MOV_get_double(tdbb, desc);
					impure->make_double(value);
				}
			}
		}
		else
		{
			if (impure->vlux_count == percentileImpure->frn)
			{
				if (desc->isDecOrInt128())
				{
					DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
					const auto value = MOV_get_dec128(tdbb, desc);
					Firebird::Decimal128 d128;
					d128.set(percentileImpure->crn - percentileImpure->rn, decSt);
					const auto part = impure->vlu_misc.vlu_dec128.add(decSt, value.mul(decSt, d128));
					impure->make_decimal128(part);
				}
				else
				{
					const auto value = MOV_get_double(tdbb, desc);
					impure->vlu_misc.vlu_double += value * (percentileImpure->crn - percentileImpure->rn);
				}
			}

			if (impure->vlux_count == percentileImpure->crn)
			{
				if (desc->isDecOrInt128())
				{
					DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
					const auto value = MOV_get_dec128(tdbb, desc);
					Firebird::Decimal128 d128;
					d128.set(percentileImpure->rn - percentileImpure->frn, decSt);
					const auto part = impure->vlu_misc.vlu_dec128.add(decSt, value.mul(decSt, d128));
					impure->make_decimal128(part);
				}
				else
				{
					const auto value = MOV_get_double(tdbb, desc);
					impure->vlu_misc.vlu_double += value * (percentileImpure->rn - percentileImpure->frn);
				}
			}
		}
	}
}

dsc* PercentileAggNode::aggExecute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlux_count || !impure->vlu_desc.dsc_dtype)
		return nullptr;

	return &impure->vlu_desc;
}

AggNode* PercentileAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	AggNode* node = FB_NEW_POOL(dsqlScratch->getPool()) PercentileAggNode(dsqlScratch->getPool(), type,
		doDsqlPass(dsqlScratch, arg),
		doDsqlPass(dsqlScratch, dsqlOrderClause) );

	PASS1_set_parameter_type(dsqlScratch, node->arg,
		[&](dsc* desc) { desc->makeDouble(); },
		false);

	return node;
}


//--------------------


static RegisterNode<CountAggNode> regCountAggNodeLegacy({blr_agg_count});

static AggNode::Register<CountAggNode> countAggInfo("COUNT", blr_agg_count2, blr_agg_count_distinct);

CountAggNode::CountAggNode(MemoryPool& pool, bool aDistinct, bool aDialect1, ValueExprNode* aArg)
	: AggNode(pool, countAggInfo, aDistinct, aDialect1, aArg)
{
}

DmlNode* CountAggNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScratch* csb, const UCHAR blrOp)
{
	CountAggNode* node = FB_NEW_POOL(pool) CountAggNode(pool,
		(blrOp == blr_agg_count_distinct),
		(csb->blrVersion == 4));

	if (blrOp != blr_agg_count)
		node->arg = PAR_parse_value(tdbb, csb);

	return node;
}

void CountAggNode::make(DsqlCompilerScratch* /*dsqlScratch*/, dsc* desc)
{
	if (dialect1)
		desc->makeLong(0);
	else
		desc->makeInt64(0);
}

void CountAggNode::genBlr(DsqlCompilerScratch* dsqlScratch)
{
	if (arg)
		AggNode::genBlr(dsqlScratch);
	else
		dsqlScratch->appendUChar(blr_agg_count);
}

void CountAggNode::getDesc(thread_db* /*tdbb*/, CompilerScratch* /*csb*/, dsc* desc)
{
	if (dialect1)
		desc->makeLong(0);
	else
		desc->makeInt64(0);
}

ValueExprNode* CountAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	CountAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) CountAggNode(*tdbb->getDefaultPool(),
		distinct, dialect1);
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	return node;
}

string CountAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);
	return "CountAggNode";
}

//// TODO: Improve count(*) in local tables.
void CountAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	impure->make_int64(0);
}

void CountAggNode::aggPass(thread_db* /*tdbb*/, Request* request, dsc* /*desc*/) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (dialect1)
		++impure->vlu_misc.vlu_long;
	else
		++impure->vlu_misc.vlu_int64;
}

dsc* CountAggNode::aggExecute(thread_db* /*tdbb*/, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlu_desc.dsc_dtype)
		return NULL;

	return &impure->vlu_desc;
}

AggNode* CountAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) CountAggNode(dsqlScratch->getPool(), distinct, dialect1,
		doDsqlPass(dsqlScratch, arg));
}


//--------------------


static AggNode::Register<SumAggNode> sumAggInfo("SUM", blr_agg_total, blr_agg_total_distinct);

SumAggNode::SumAggNode(MemoryPool& pool, bool aDistinct, bool aDialect1, ValueExprNode* aArg)
	: AggNode(pool, sumAggInfo, aDistinct, aDialect1, aArg)
{
}

DmlNode* SumAggNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScratch* csb, const UCHAR blrOp)
{
	SumAggNode* node = FB_NEW_POOL(pool) SumAggNode(pool, (blrOp == blr_agg_total_distinct),
		(csb->blrVersion == 4));

	node->arg = PAR_parse_value(tdbb, csb);

	return node;
}

void SumAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg, true);

	if (desc->isNull())
		return;

	if (DTYPE_IS_DECFLOAT(desc->dsc_dtype))
	{
		desc->dsc_dtype = dtype_dec128;
		desc->dsc_length = sizeof(Decimal128);
	}
	else if (dialect1)
	{
		if (!DTYPE_IS_NUMERIC(desc->dsc_dtype) && !DTYPE_IS_TEXT(desc->dsc_dtype))
		{
			ERRD_post(Arg::Gds(isc_expression_eval_err) <<
					  Arg::Gds(isc_dsql_agg_wrongarg) << Arg::Str("SUM"));
		}
		else if (desc->dsc_dtype == dtype_short)
		{
			desc->dsc_dtype = dtype_long;
			desc->dsc_length = sizeof(SLONG);
		}
		else if (desc->dsc_dtype == dtype_int64)
		{
			desc->dsc_dtype = dtype_double;
			desc->dsc_length = sizeof(double);
		}
		else if (DTYPE_IS_TEXT(desc->dsc_dtype))
		{
			desc->dsc_dtype = dtype_double;
			desc->dsc_length = sizeof(double);
		}
	}
	else
	{
		if (!DTYPE_IS_NUMERIC(desc->dsc_dtype))
		{
			ERRD_post(Arg::Gds(isc_expression_eval_err) <<
					  Arg::Gds(isc_dsql_agg2_wrongarg) << Arg::Str("SUM"));
		}
		else if (desc->dsc_dtype == dtype_int64 || desc->dsc_dtype == dtype_int128)
		{
			desc->dsc_dtype = dtype_int128;
			desc->dsc_length = sizeof(Int128);
		}
		else if (DTYPE_IS_EXACT(desc->dsc_dtype))
		{
			desc->dsc_dtype = dtype_int64;
			desc->dsc_length = sizeof(SINT64);
		}
		else
		{
			desc->dsc_dtype = dtype_double;
			desc->dsc_length = sizeof(double);
		}
	}
}

void SumAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);

	if (DTYPE_IS_DECFLOAT(desc->dsc_dtype))
	{
		desc->dsc_dtype = dtype_dec128;
		desc->dsc_length = sizeof(Decimal128);
		desc->dsc_sub_type = 0;
		desc->dsc_flags = 0;
		nodFlags |= FLAG_DECFLOAT;
		return;
	}

	if (dialect1)
	{
		switch (desc->dsc_dtype)
		{
			case dtype_short:
				desc->dsc_dtype = dtype_long;
				desc->dsc_length = sizeof(SLONG);
				nodScale = desc->dsc_scale;
				desc->dsc_flags = 0;
				return;

			case dtype_unknown:
				desc->dsc_dtype = dtype_unknown;
				desc->dsc_length = 0;
				nodScale = 0;
				desc->dsc_sub_type = 0;
				desc->dsc_flags = 0;
				return;

			case dtype_long:
			case dtype_int64:
			case dtype_real:
			case dtype_double:
			case dtype_text:
			case dtype_cstring:
			case dtype_varying:
				desc->dsc_dtype = DEFAULT_DOUBLE;
				desc->dsc_length = sizeof(double);
				desc->dsc_scale = 0;
				desc->dsc_sub_type = 0;
				desc->dsc_flags = 0;
				nodFlags |= FLAG_DOUBLE;
				return;

			case dtype_sql_time:
			case dtype_sql_date:
			case dtype_timestamp:
			case dtype_quad:
			case dtype_blob:
			case dtype_array:
			case dtype_dbkey:
				break;	// break to error reporting code

			default:
				fb_assert(false);
		}
	}
	else
	{
		switch (desc->dsc_dtype)
		{
			case dtype_short:
			case dtype_long:
				desc->dsc_dtype = dtype_int64;
				desc->dsc_length = sizeof(SINT64);
				nodScale = desc->dsc_scale;
				desc->dsc_flags = 0;
				return;

			case dtype_int64:
			case dtype_int128:
				desc->dsc_dtype = dtype_int128;
				desc->dsc_length = sizeof(Int128);
				desc->dsc_flags = 0;
				nodScale = desc->dsc_scale;
				nodFlags |= FLAG_INT128;
				return;

			case dtype_unknown:
				desc->dsc_dtype = dtype_unknown;
				desc->dsc_length = 0;
				nodScale = 0;
				desc->dsc_sub_type = 0;
				desc->dsc_flags = 0;
				return;

			case dtype_real:
			case dtype_double:
			case dtype_text:
			case dtype_cstring:
			case dtype_varying:
				desc->dsc_dtype = DEFAULT_DOUBLE;
				desc->dsc_length = sizeof(double);
				desc->dsc_scale = 0;
				desc->dsc_sub_type = 0;
				desc->dsc_flags = 0;
				nodFlags |= FLAG_DOUBLE;
				return;

			case dtype_sql_time:
			case dtype_sql_date:
			case dtype_timestamp:
			case dtype_quad:
			case dtype_blob:
			case dtype_array:
			case dtype_dbkey:
				break;	// break to error reporting code

			default:
				fb_assert(false);
		}
	}

	if (desc->dsc_dtype == dtype_quad)
		IBERROR(224);	// msg 224 quad word arithmetic not supported

	ERR_post(Arg::Gds(isc_datype_notsup));	// data type not supported for arithmetic
}

ValueExprNode* SumAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	SumAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) SumAggNode(*tdbb->getDefaultPool(),
		distinct, dialect1);
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	return node;
}

string SumAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);
	return "SumAggNode";
}

void SumAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (dialect1)
		impure->make_long(0);
	else
	{
		// Initialize the result area as an int64. If the field being aggregated is approximate
		// numeric, the first call to add will convert the descriptor to double.
		impure->make_int64(0, nodScale);
	}
}

void SumAggNode::aggPass(thread_db* tdbb, Request* request, dsc* desc) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	++impure->vlux_count;

	ArithmeticNode::add(tdbb, desc, &impure->vlu_desc, impure, blr_add, dialect1, nodScale, nodFlags);
}

dsc* SumAggNode::aggExecute(thread_db* /*tdbb*/, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlux_count)
		return NULL;

	return &impure->vlu_desc;
}

AggNode* SumAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) SumAggNode(dsqlScratch->getPool(), distinct, dialect1,
		doDsqlPass(dsqlScratch, arg));
}


//--------------------


static AggNode::Register<MaxMinAggNode> maxAggInfo("MAX", blr_agg_max);
static AggNode::Register<MaxMinAggNode> minAggInfo("MIN", blr_agg_min);

MaxMinAggNode::MaxMinAggNode(MemoryPool& pool, MaxMinType aType, ValueExprNode* aArg)
	: AggNode(pool, (aType == MaxMinAggNode::TYPE_MAX ? maxAggInfo : minAggInfo), false, false, aArg),
	  type(aType)
{
}

DmlNode* MaxMinAggNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScratch* csb, const UCHAR blrOp)
{
	MaxMinAggNode* node = FB_NEW_POOL(pool) MaxMinAggNode(pool,
		(blrOp == blr_agg_max ? TYPE_MAX : TYPE_MIN));
	node->arg = PAR_parse_value(tdbb, csb);
	return node;
}

void MaxMinAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg, true);
}

void MaxMinAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);
}

ValueExprNode* MaxMinAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	MaxMinAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) MaxMinAggNode(*tdbb->getDefaultPool(),
		type);
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	return node;
}

string MaxMinAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, type);

	return "MaxMinAggNode";
}

void MaxMinAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	impure->vlu_desc.dsc_dtype = 0;
}

void MaxMinAggNode::aggPass(thread_db* tdbb, Request* request, dsc* desc) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	++impure->vlux_count;

	if (!impure->vlu_desc.dsc_dtype)
	{
		EVL_make_value(tdbb, desc, impure);
		return;
	}

	const int result = MOV_compare(tdbb, desc, &impure->vlu_desc);

	if ((type == TYPE_MAX && result > 0) || (type == TYPE_MIN && result < 0))
		EVL_make_value(tdbb, desc, impure);
}

dsc* MaxMinAggNode::aggExecute(thread_db* /*tdbb*/, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlux_count)
		return NULL;

	return &impure->vlu_desc;
}

AggNode* MaxMinAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) MaxMinAggNode(dsqlScratch->getPool(),
		type, doDsqlPass(dsqlScratch, arg));
}

//--------------------

static AggNode::RegisterFactory1<BinAggNode, BinAggNode::BinType> binAndAggInfo(
	"BIN_AND_AGG", BinAggNode::TYPE_BIN_AND);
static AggNode::RegisterFactory1<BinAggNode, BinAggNode::BinType> binOrAggInfo(
	"BIN_OR_AGG", BinAggNode::TYPE_BIN_OR);
static AggNode::RegisterFactory1<BinAggNode, BinAggNode::BinType> binXorAggInfo(
	"BIN_XOR_AGG", BinAggNode::TYPE_BIN_XOR);
static AggNode::RegisterFactory1<BinAggNode, BinAggNode::BinType> binXorDistinctAggInfo(
	"BIN_XOR_DISTINCT_AGG", BinAggNode::TYPE_BIN_XOR_DISTINCT);

BinAggNode::BinAggNode(MemoryPool& pool, BinType aType, ValueExprNode* aArg)
	: AggNode(pool,
		(aType == BinAggNode::TYPE_BIN_AND ? binAndAggInfo :
			aType == BinAggNode::TYPE_BIN_OR ? binOrAggInfo :
			aType == BinAggNode::TYPE_BIN_XOR ? binXorAggInfo : binXorDistinctAggInfo),
		(aType == BinAggNode::TYPE_BIN_XOR_DISTINCT), false, aArg),
	  type(aType)
{
}

void BinAggNode::parseArgs(thread_db* tdbb, CompilerScratch* csb, unsigned /*count*/)
{
	arg = PAR_parse_value(tdbb, csb);
}

void BinAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg, true);

	if (desc->isNull())
		return;

	if (!DTYPE_IS_EXACT(desc->dsc_dtype) || (desc->dsc_scale != 0))
	{
		switch (type)
		{
			case TYPE_BIN_AND:
				ERRD_post(Arg::Gds(isc_expression_eval_err) <<
						Arg::Gds(isc_dsql_agg2_wrongarg) << Arg::Str("BIN_AND_AGG"));
			break;

			case TYPE_BIN_OR:
				ERRD_post(Arg::Gds(isc_expression_eval_err) <<
						Arg::Gds(isc_dsql_agg2_wrongarg) << Arg::Str("BIN_OR_AGG"));
			break;

			case TYPE_BIN_XOR:
			case TYPE_BIN_XOR_DISTINCT:
				ERRD_post(Arg::Gds(isc_expression_eval_err) <<
						Arg::Gds(isc_dsql_agg2_wrongarg) << Arg::Str("BIN_XOR_AGG"));
			break;

			default:
				fb_assert(false);
			break;
		}
	}
}

void BinAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);

	if (desc->is128())
	{
		nodFlags |= FLAG_INT128;
		desc->makeInt128(0);
	}
	else
		desc->makeInt64(0);
}

ValueExprNode* BinAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	BinAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) BinAggNode(*tdbb->getDefaultPool(), type);
	node->arg = copier.copy(tdbb, arg);
	return node;
}

string BinAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, type);

	return "BinAggNode";
}

void BinAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	SINT64 initValue = 0;
	if (type == TYPE_BIN_AND)
		initValue = -1;

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	if (nodFlags & FLAG_INT128)
	{
		Firebird::Int128 i128;
		i128.set(initValue, 0);
		impure->make_decimal_fixed(i128, 0);
	}
	else
		impure->make_int64(initValue);
}

void BinAggNode::aggPass(thread_db* tdbb, Request* request, dsc* desc) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	++impure->vlux_count;
	if (nodFlags & FLAG_INT128)
	{
		const auto value = MOV_get_int128(tdbb, desc, 0);
		switch (type)
		{
			case TYPE_BIN_AND:
				impure->vlu_misc.vlu_int128 &= value;
				break;

			case TYPE_BIN_OR:
				impure->vlu_misc.vlu_int128 |= value;
				break;

			case TYPE_BIN_XOR:
			case TYPE_BIN_XOR_DISTINCT:
				impure->vlu_misc.vlu_int128 ^= value;
				break;
		}
	}
	else
	{
		const auto value = MOV_get_int64(tdbb, desc, 0);
		switch (type)
		{
			case TYPE_BIN_AND:
				impure->vlu_misc.vlu_int64 &= value;
				break;

			case TYPE_BIN_OR:
				impure->vlu_misc.vlu_int64 |= value;
				break;

			case TYPE_BIN_XOR:
			case TYPE_BIN_XOR_DISTINCT:
				impure->vlu_misc.vlu_int64 ^= value;
				break;
		}
    }
}

dsc* BinAggNode::aggExecute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlux_count)
		return nullptr;

	return &impure->vlu_desc;
}

AggNode* BinAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) BinAggNode(dsqlScratch->getPool(),
		type, doDsqlPass(dsqlScratch, arg));
}

//--------------------


static AggNode::RegisterFactory1<StdDevAggNode, StdDevAggNode::StdDevType> stdDevSampAggInfo(
	"STDDEV_SAMP", StdDevAggNode::TYPE_STDDEV_SAMP);
static AggNode::RegisterFactory1<StdDevAggNode, StdDevAggNode::StdDevType> stdDevPopAggInfo(
	"STDDEV_POP", StdDevAggNode::TYPE_STDDEV_POP);
static AggNode::RegisterFactory1<StdDevAggNode, StdDevAggNode::StdDevType> varSampAggInfo(
	"VAR_SAMP", StdDevAggNode::TYPE_VAR_SAMP);
static AggNode::RegisterFactory1<StdDevAggNode, StdDevAggNode::StdDevType> varPopAggInfo(
	"VAR_POP", StdDevAggNode::TYPE_VAR_POP);

StdDevAggNode::StdDevAggNode(MemoryPool& pool, StdDevType aType, ValueExprNode* aArg)
	: AggNode(pool,
		(aType == StdDevAggNode::TYPE_STDDEV_SAMP ? stdDevSampAggInfo :
		 aType == StdDevAggNode::TYPE_STDDEV_POP ? stdDevPopAggInfo :
		 aType == StdDevAggNode::TYPE_VAR_SAMP ? varSampAggInfo :
		 varPopAggInfo),
		false, false, aArg),
	  type(aType),
	  impure2Offset(0)
{
}

void StdDevAggNode::parseArgs(thread_db* tdbb, CompilerScratch* csb, unsigned /*count*/)
{
	arg = PAR_parse_value(tdbb, csb);
}

void StdDevAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg, true);

	if (desc->isNull())
		return;

	if (desc->isDecOrInt128())
		desc->makeDecimal128();
	else
		desc->makeDouble();
}

void StdDevAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);

	if (desc->isDecOrInt128())
	{
		desc->makeDecimal128();
		nodFlags |= FLAG_DECFLOAT;
	}
	else
	{
		desc->makeDouble();
		nodFlags |= FLAG_DOUBLE;
	}
}

ValueExprNode* StdDevAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	StdDevAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) StdDevAggNode(*tdbb->getDefaultPool(), type);
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	return node;
}

AggNode* StdDevAggNode::pass2(thread_db* tdbb, CompilerScratch* csb)
{
	AggNode::pass2(tdbb, csb);

	impure2Offset = csb->allocImpure<StdDevImpure>();

	return this;
}

string StdDevAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, type);
	NODE_PRINT(printer, impure2Offset);

	return "StdDevAggNode";
}

void StdDevAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	StdDevImpure* impure2 = request->getImpure<StdDevImpure>(impure2Offset);

	if (nodFlags & FLAG_DECFLOAT)
	{
		impure->make_decimal128(CDecimal128(0));
		impure2->dec.x = impure2->dec.x2 = CDecimal128(0);
	}
	else
	{
		impure->make_double(0);
		impure2->dbl.x = impure2->dbl.x2 = 0.0;
	}
}

void StdDevAggNode::aggPass(thread_db* tdbb, Request* request, dsc* desc) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	++impure->vlux_count;

	StdDevImpure* impure2 = request->getImpure<StdDevImpure>(impure2Offset);
	if (nodFlags & FLAG_DECFLOAT)
	{
		DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
		const Decimal128 d = MOV_get_dec128(tdbb, desc);

		impure2->dec.x = impure2->dec.x.add(decSt, d);
		impure2->dec.x2 = impure2->dec.x2.fma(decSt, d, d);
	}
	else
	{
		const double d = MOV_get_double(tdbb, desc);

		impure2->dbl.x += d;
		impure2->dbl.x2 += d * d;
	}
}

dsc* StdDevAggNode::aggExecute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	StdDevImpure* impure2 = request->getImpure<StdDevImpure>(impure2Offset);
	double d;
	Decimal128 dec;

	DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
	Decimal128 cnt;
	if (nodFlags & FLAG_DECFLOAT)
		cnt.set(impure->vlux_count, decSt, 0);

	switch (type)
	{
		case TYPE_STDDEV_SAMP:
		case TYPE_VAR_SAMP:
			if (impure->vlux_count < 2)
				return NULL;

			if (nodFlags & FLAG_DECFLOAT)
			{
				Decimal128 cntMinus1;
				cntMinus1.set(impure->vlux_count - 1, decSt, 0);
				dec = impure2->dec.x.mul(decSt, impure2->dec.x).div(decSt, cnt);
				dec = impure2->dec.x2.sub(decSt, dec);
				dec = dec.div(decSt, cntMinus1);

				if (type == TYPE_STDDEV_SAMP)
					dec = dec.sqrt(decSt);
			}
			else
			{
				d = (impure2->dbl.x2 - impure2->dbl.x * impure2->dbl.x / impure->vlux_count) /
					(impure->vlux_count - 1);

				if (type == TYPE_STDDEV_SAMP)
					d = sqrt(d);
			}
			break;

		case TYPE_STDDEV_POP:
		case TYPE_VAR_POP:
			if (impure->vlux_count == 0)
				return NULL;

			if (nodFlags & FLAG_DECFLOAT)
			{
				dec = impure2->dec.x.mul(decSt, impure2->dec.x).div(decSt, cnt);
				dec = impure2->dec.x2.sub(decSt, dec);
				dec = dec.div(decSt, cnt);

				if (type == TYPE_STDDEV_SAMP)
					dec = dec.sqrt(decSt);
			}
			else
			{
				d = (impure2->dbl.x2 - impure2->dbl.x * impure2->dbl.x / impure->vlux_count) /
					impure->vlux_count;

				if (type == TYPE_STDDEV_POP)
					d = sqrt(d);
			}
			break;
	}

	dsc temp;
	if (nodFlags & FLAG_DECFLOAT)
		temp.makeDecimal128(&dec);
	else
		temp.makeDouble(&d);

	EVL_make_value(tdbb, &temp, impure);
	return &impure->vlu_desc;
}

AggNode* StdDevAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) StdDevAggNode(dsqlScratch->getPool(),
		type, doDsqlPass(dsqlScratch, arg));
}


//--------------------


static AggNode::RegisterFactory1<CorrAggNode, CorrAggNode::CorrType> coVarSampAggInfo(
	"COVAR_SAMP", CorrAggNode::TYPE_COVAR_SAMP);
static AggNode::RegisterFactory1<CorrAggNode, CorrAggNode::CorrType> coVarPopAggInfo(
	"COVAR_POP", CorrAggNode::TYPE_COVAR_POP);
static AggNode::RegisterFactory1<CorrAggNode, CorrAggNode::CorrType> corrAggInfo(
	"CORR", CorrAggNode::TYPE_CORR);

CorrAggNode::CorrAggNode(MemoryPool& pool, CorrType aType, ValueExprNode* aArg, ValueExprNode* aArg2)
	: AggNode(pool,
		(aType == CorrAggNode::TYPE_COVAR_SAMP ? coVarSampAggInfo :
		 aType == CorrAggNode::TYPE_COVAR_POP ? coVarPopAggInfo :
		 corrAggInfo),
		false, false, aArg),
	  type(aType),
	  arg2(aArg2),
	  impure2Offset(0)
{
}

void CorrAggNode::parseArgs(thread_db* tdbb, CompilerScratch* csb, unsigned /*count*/)
{
	arg = PAR_parse_value(tdbb, csb);
	arg2 = PAR_parse_value(tdbb, csb);
}

void CorrAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg, true);

	if (desc->isNull())
		return;

	if (desc->isDecOrInt128())
		desc->makeDecimal128();
	else
		desc->makeDouble();
}

void CorrAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);

	if (desc->isDecOrInt128())
	{
		desc->makeDecimal128();
		nodFlags |= FLAG_DECFLOAT;
	}
	else
	{
		desc->makeDouble();
		nodFlags |= FLAG_DOUBLE;
	}
}

ValueExprNode* CorrAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	CorrAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) CorrAggNode(*tdbb->getDefaultPool(), type);
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	node->arg2 = copier.copy(tdbb, arg2);
	return node;
}

AggNode* CorrAggNode::pass2(thread_db* tdbb, CompilerScratch* csb)
{
	AggNode::pass2(tdbb, csb);

	impure2Offset = csb->allocImpure<CorrImpure>();

	return this;
}

string CorrAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, type);
	NODE_PRINT(printer, arg2);

	return "CorrAggNode";
}

void CorrAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	CorrImpure* impure2 = request->getImpure<CorrImpure>(impure2Offset);

	if (nodFlags & FLAG_DECFLOAT)
	{
		impure->make_decimal128(CDecimal128(0));
		impure2->dec.x = impure2->dec.x2 = impure2->dec.y = impure2->dec.y2 = impure2->dec.xy = CDecimal128(0);
	}
	else
	{
		impure->make_double(0);
		impure2->dbl.x = impure2->dbl.x2 = impure2->dbl.y = impure2->dbl.y2 = impure2->dbl.xy = 0.0;
	}
}

bool CorrAggNode::aggPass(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	dsc* desc = NULL;
	dsc* desc2 = NULL;

	desc = EVL_expr(tdbb, request, arg);
	if (!desc)
		return false;

	desc2 = EVL_expr(tdbb, request, arg2);
	if (!desc2)
		return false;

	++impure->vlux_count;
	CorrImpure* impure2 = request->getImpure<CorrImpure>(impure2Offset);

	if (nodFlags & FLAG_DECFLOAT)
	{
		const Decimal128 y = MOV_get_dec128(tdbb, desc);
		const Decimal128 x = MOV_get_dec128(tdbb, desc2);

		DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
		impure2->dec.x = impure2->dec.x.add(decSt, x);
		impure2->dec.x2 = impure2->dec.x2.fma(decSt, x, x);
		impure2->dec.y = impure2->dec.y.add(decSt, y);
		impure2->dec.y2 = impure2->dec.y2.fma(decSt, y, y);
		impure2->dec.xy = impure2->dec.xy.fma(decSt, x, y);
	}
	else
	{
		const double y = MOV_get_double(tdbb, desc);
		const double x = MOV_get_double(tdbb, desc2);
		impure2->dbl.x += x;
		impure2->dbl.x2 += x * x;
		impure2->dbl.y += y;
		impure2->dbl.y2 += y * y;
		impure2->dbl.xy += x * y;
	}

	return true;
}

void CorrAggNode::aggPass(thread_db* /*tdbb*/, Request* /*request*/, dsc* /*desc*/) const
{
	fb_assert(false);
}

dsc* CorrAggNode::aggExecute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	CorrImpure* impure2 = request->getImpure<CorrImpure>(impure2Offset);
	double d;
	Decimal128 dec;

	DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
	Decimal128 cnt;
	if (nodFlags & FLAG_DECFLOAT)
		cnt.set(impure->vlux_count, decSt, 0);

	switch (type)
	{
		case TYPE_COVAR_SAMP:
			if (impure->vlux_count < 2)
				return NULL;

			if (nodFlags & FLAG_DECFLOAT)
			{
				Decimal128 cntMinus1;
				cntMinus1.set(impure->vlux_count - 1, decSt, 0);
				dec = impure2->dec.x.mul(decSt, impure2->dec.y).div(decSt, cnt);
				dec = impure2->dec.xy.sub(decSt, dec);
				dec = dec.div(decSt, cntMinus1);
			}
			else
				d = (impure2->dbl.xy - impure2->dbl.y * impure2->dbl.x / impure->vlux_count) / (impure->vlux_count - 1);
			break;

		case TYPE_COVAR_POP:
			if (impure->vlux_count == 0)
				return NULL;

			if (nodFlags & FLAG_DECFLOAT)
			{
				dec = impure2->dec.x.mul(decSt, impure2->dec.y).div(decSt, cnt);
				dec = impure2->dec.xy.sub(decSt, dec);
				dec = dec.div(decSt, cnt);
			}
			else
				d = (impure2->dbl.xy - impure2->dbl.y * impure2->dbl.x / impure->vlux_count) / impure->vlux_count;
			break;

		case TYPE_CORR:
		{
			// COVAR_POP(Y, X) / (STDDEV_POP(X) * STDDEV_POP(Y))
			if (impure->vlux_count == 0)
				return NULL;

			if (nodFlags & FLAG_DECFLOAT)
			{
				dec = impure2->dec.x.mul(decSt, impure2->dec.y).div(decSt, cnt);
				dec = impure2->dec.xy.sub(decSt, dec);
				const Decimal128 covarPop = dec.div(decSt, cnt);

				dec = impure2->dec.x.mul(decSt, impure2->dec.x).div(decSt, cnt);
				dec = impure2->dec.x2.sub(decSt, dec);
				const Decimal128 varPopX = dec.div(decSt, cnt);

				dec = impure2->dec.y.mul(decSt, impure2->dec.y).div(decSt, cnt);
				dec = impure2->dec.y2.sub(decSt, dec);
				const Decimal128 varPopY = dec.div(decSt, cnt);

				const Decimal128 divisor = varPopX.sqrt(decSt).mul(decSt, varPopY.sqrt(decSt));

				if (divisor.compare(decSt, CDecimal128(0)) == 0)
					return NULL;

				dec = covarPop.div(decSt, divisor);
			}
			else
			{
				const double covarPop = (impure2->dbl.xy - impure2->dbl.y * impure2->dbl.x / impure->vlux_count) /
					impure->vlux_count;
				const double varPopX = (impure2->dbl.x2 - impure2->dbl.x * impure2->dbl.x / impure->vlux_count) /
					impure->vlux_count;
				const double varPopY = (impure2->dbl.y2 - impure2->dbl.y * impure2->dbl.y / impure->vlux_count) /
					impure->vlux_count;
				const double divisor = sqrt(varPopX) * sqrt(varPopY);

				if (divisor == 0.0)
					return NULL;

				d = covarPop / divisor;
			}
			break;
		}
	}

	dsc temp;
	if (nodFlags & FLAG_DECFLOAT)
		temp.makeDecimal128(&dec);
	else
		temp.makeDouble(&d);

	EVL_make_value(tdbb, &temp, impure);

	return &impure->vlu_desc;
}

AggNode* CorrAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) CorrAggNode(dsqlScratch->getPool(), type,
		doDsqlPass(dsqlScratch, arg), doDsqlPass(dsqlScratch, arg2));
}


//--------------------

static AggNode::RegisterFactory1<RegrAggNode, RegrAggNode::RegrType> regrAvgxAggInfo(
	"REGR_AVGX", RegrAggNode::TYPE_REGR_AVGX);
static AggNode::RegisterFactory1<RegrAggNode, RegrAggNode::RegrType> regrAvgyAggInfo(
	"REGR_AVGY", RegrAggNode::TYPE_REGR_AVGY);
static AggNode::RegisterFactory1<RegrAggNode, RegrAggNode::RegrType> regrInterceptAggInfo(
	"REGR_INTERCEPT", RegrAggNode::TYPE_REGR_INTERCEPT);
static AggNode::RegisterFactory1<RegrAggNode, RegrAggNode::RegrType> regrR2AggInfo(
	"REGR_R2", RegrAggNode::TYPE_REGR_R2);
static AggNode::RegisterFactory1<RegrAggNode, RegrAggNode::RegrType> regrSlopeAggInfo(
	"REGR_SLOPE", RegrAggNode::TYPE_REGR_SLOPE);
static AggNode::RegisterFactory1<RegrAggNode, RegrAggNode::RegrType> regrSxxAggInfo(
	"REGR_SXX", RegrAggNode::TYPE_REGR_SXX);
static AggNode::RegisterFactory1<RegrAggNode, RegrAggNode::RegrType> regrSxyAggInfo(
	"REGR_SXY", RegrAggNode::TYPE_REGR_SXY);
static AggNode::RegisterFactory1<RegrAggNode, RegrAggNode::RegrType> regrSyyAggInfo(
	"REGR_SYY", RegrAggNode::TYPE_REGR_SYY);

RegrAggNode::RegrAggNode(MemoryPool& pool, RegrType aType, ValueExprNode* aArg, ValueExprNode* aArg2)
	: AggNode(pool,
		(aType == RegrAggNode::TYPE_REGR_AVGX ? regrAvgxAggInfo :
		 aType == RegrAggNode::TYPE_REGR_AVGY ? regrAvgyAggInfo :
		 aType == RegrAggNode::TYPE_REGR_INTERCEPT ? regrInterceptAggInfo :
		 aType == RegrAggNode::TYPE_REGR_R2 ? regrR2AggInfo :
		 aType == RegrAggNode::TYPE_REGR_SLOPE ? regrSlopeAggInfo :
		 aType == RegrAggNode::TYPE_REGR_SXX ? regrSxxAggInfo :
		 aType == RegrAggNode::TYPE_REGR_SXY ? regrSxyAggInfo :
		 aType == RegrAggNode::TYPE_REGR_SYY ? regrSyyAggInfo :
		 regrSyyAggInfo),
		false, false, aArg),
	  type(aType),
	  arg2(aArg2),
	  impure2Offset(0)
{
}

void RegrAggNode::parseArgs(thread_db* tdbb, CompilerScratch* csb, unsigned /*count*/)
{
	arg = PAR_parse_value(tdbb, csb);
	arg2 = PAR_parse_value(tdbb, csb);
}

void RegrAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	DsqlDescMaker::fromNode(dsqlScratch, desc, arg, true);

	if (desc->isNull())
		return;

	if (desc->isDecOrInt128())
		desc->makeDecimal128();
	else
		desc->makeDouble();
}

void RegrAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	arg->getDesc(tdbb, csb, desc);

	if (desc->isDecOrInt128())
	{
		desc->makeDecimal128();
		nodFlags |= FLAG_DECFLOAT;
	}
	else
	{
		desc->makeDouble();
		nodFlags |= FLAG_DOUBLE;
	}
}

ValueExprNode* RegrAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	RegrAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) RegrAggNode(*tdbb->getDefaultPool(), type);
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	node->arg2 = copier.copy(tdbb, arg2);
	return node;
}

AggNode* RegrAggNode::pass2(thread_db* tdbb, CompilerScratch* csb)
{
	AggNode::pass2(tdbb, csb);

	impure2Offset = csb->allocImpure<RegrImpure>();

	return this;
}

string RegrAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, type);
	NODE_PRINT(printer, arg2);

	return "RegrAggNode";
}

void RegrAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	RegrImpure* impure2 = request->getImpure<RegrImpure>(impure2Offset);

	if (nodFlags & FLAG_DECFLOAT)
	{
		impure->make_decimal128(CDecimal128(0));
		impure2->dec.x = impure2->dec.x2 = impure2->dec.y = impure2->dec.y2 = impure2->dec.xy = CDecimal128(0);
	}
	else
	{
		impure->make_double(0);
		impure2->dbl.x = impure2->dbl.x2 = impure2->dbl.y = impure2->dbl.y2 = impure2->dbl.xy = 0.0;
	}
}

bool RegrAggNode::aggPass(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	dsc* desc = NULL;
	dsc* desc2 = NULL;

	desc = EVL_expr(tdbb, request, arg);
	if (!desc)
		return false;

	desc2 = EVL_expr(tdbb, request, arg2);
	if (!desc2)
		return false;

	++impure->vlux_count;
	RegrImpure* impure2 = request->getImpure<RegrImpure>(impure2Offset);

	if (nodFlags & FLAG_DECFLOAT)
	{
		const Decimal128 y = MOV_get_dec128(tdbb, desc);
		const Decimal128 x = MOV_get_dec128(tdbb, desc2);

		DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
		impure2->dec.x = impure2->dec.x.add(decSt, x);
		impure2->dec.x2 = impure2->dec.x2.fma(decSt, x, x);
		impure2->dec.y = impure2->dec.y.add(decSt, y);
		impure2->dec.y2 = impure2->dec.y2.fma(decSt, y, y);
		impure2->dec.xy = impure2->dec.xy.fma(decSt, x, y);
	}
	else
	{
		const double y = MOV_get_double(tdbb, desc);
		const double x = MOV_get_double(tdbb, desc2);

		impure2->dbl.x += x;
		impure2->dbl.x2 += x * x;
		impure2->dbl.y += y;
		impure2->dbl.y2 += y * y;
		impure2->dbl.xy += x * y;
	}

	return true;
}

void RegrAggNode::aggPass(thread_db* /*tdbb*/, Request* /*request*/, dsc* /*desc*/) const
{
	fb_assert(false);
}

dsc* RegrAggNode::aggExecute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (impure->vlux_count == 0)
		return NULL;

	RegrImpure* impure2 = request->getImpure<RegrImpure>(impure2Offset);
	dsc temp;
	double doubleVal;
	Decimal128 decimal128Val;

	if (nodFlags & FLAG_DECFLOAT)
	{
		DecimalStatus decSt = tdbb->getAttachment()->att_dec_status;
		Decimal128 cnt;
		cnt.set(impure->vlux_count, decSt, 0);
		DecimalStatus safeDivide = decSt;
		safeDivide.decExtFlag &= ~DEC_Division_by_zero;

		const Decimal128 sxx = impure2->dec.x2.sub(decSt, impure2->dec.x.mul(decSt, impure2->dec.x).div(decSt, cnt));
		const Decimal128 syy = impure2->dec.y2.sub(decSt, impure2->dec.y.mul(decSt, impure2->dec.y).div(decSt, cnt));
		const Decimal128 sxy = impure2->dec.xy.sub(decSt, impure2->dec.x.mul(decSt, impure2->dec.y).div(decSt, cnt));
		const Decimal128 varPopX = sxx.div(decSt, cnt);
		const Decimal128 varPopY = syy.div(decSt, cnt);
		const Decimal128 covarPop = sxy.div(decSt, cnt);
		const Decimal128 avgX = impure2->dec.x.div(decSt, cnt);
		const Decimal128 avgY = impure2->dec.y.div(decSt, cnt);
		const Decimal128 slope = covarPop.div(safeDivide, varPopX);
		const Decimal128 sq = varPopX.sqrt(decSt).mul(decSt, varPopY.sqrt(decSt));
		const Decimal128 corr = covarPop.div(safeDivide, sq);

		switch (type)
		{
			case TYPE_REGR_AVGX:
				decimal128Val = avgX;
				break;

			case TYPE_REGR_AVGY:
				decimal128Val = avgY;
				break;

			case TYPE_REGR_INTERCEPT:
				if (varPopX.compare(decSt, CDecimal128(0)) == 0)
					return NULL;
				else
					decimal128Val = avgY.sub(decSt, slope.mul(decSt, avgX));
				break;

			case TYPE_REGR_R2:
				if (varPopX.compare(decSt, CDecimal128(0)) == 0)
					return NULL;
				else if (varPopY.compare(decSt, CDecimal128(0)) == 0)
					decimal128Val.set(1, decSt, 0);
				else if (sq.compare(decSt, CDecimal128(0)) == 0)
					return NULL;
				else
					decimal128Val = corr.mul(decSt, corr);
				break;

			case TYPE_REGR_SLOPE:
				if (varPopX.compare(decSt, CDecimal128(0)) == 0)
					return NULL;
				else
					decimal128Val = slope;
				break;

			case TYPE_REGR_SXX:
				decimal128Val = sxx;
				break;

			case TYPE_REGR_SXY:
				decimal128Val = sxy;
				break;

			case TYPE_REGR_SYY:
				decimal128Val = syy;
				break;
		}

		temp.makeDecimal128(&decimal128Val);
	}
	else
	{
		const double varPopX = (impure2->dbl.x2 - impure2->dbl.x * impure2->dbl.x / impure->vlux_count) / impure->vlux_count;
		const double varPopY = (impure2->dbl.y2 - impure2->dbl.y * impure2->dbl.y / impure->vlux_count) / impure->vlux_count;
		const double covarPop = (impure2->dbl.xy - impure2->dbl.y * impure2->dbl.x / impure->vlux_count) / impure->vlux_count;
		const double avgX = impure2->dbl.x / impure->vlux_count;
		const double avgY = impure2->dbl.y / impure->vlux_count;
		const double slope = covarPop / varPopX;
		const double sq = sqrt(varPopX) * sqrt(varPopY);
		const double corr = covarPop / sq;

		switch (type)
		{
			case TYPE_REGR_AVGX:
				doubleVal = avgX;
				break;

			case TYPE_REGR_AVGY:
				doubleVal = avgY;
				break;

			case TYPE_REGR_INTERCEPT:
				if (varPopX == 0.0)
					return NULL;
				else
					doubleVal = avgY - slope * avgX;
				break;

			case TYPE_REGR_R2:
				if (varPopX == 0.0)
					return NULL;
				else if (varPopY == 0.0)
					doubleVal = 1.0;
				else if (sq == 0.0)
					return NULL;
				else
					doubleVal = corr * corr;
				break;

			case TYPE_REGR_SLOPE:
				if (varPopX == 0.0)
					return NULL;
				else
					doubleVal = covarPop / varPopX;
				break;

			case TYPE_REGR_SXX:
				doubleVal = impure->vlux_count * varPopX;
				break;

			case TYPE_REGR_SXY:
				doubleVal = impure->vlux_count * covarPop;
				break;

			case TYPE_REGR_SYY:
				doubleVal = impure->vlux_count * varPopY;
				break;
		}

		temp.makeDouble(&doubleVal);
	}

	EVL_make_value(tdbb, &temp, impure);
	return &impure->vlu_desc;
}

AggNode* RegrAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) RegrAggNode(dsqlScratch->getPool(), type,
		doDsqlPass(dsqlScratch, arg), doDsqlPass(dsqlScratch, arg2));
}


//--------------------


static AggNode::RegisterFactory0<RegrCountAggNode> regrCountAggInfo("REGR_COUNT");

RegrCountAggNode::RegrCountAggNode(MemoryPool& pool, ValueExprNode* aArg, ValueExprNode* aArg2)
	: AggNode(pool, regrCountAggInfo, false, false, aArg),
	  arg2(aArg2)
{
}

void RegrCountAggNode::parseArgs(thread_db* tdbb, CompilerScratch* csb, unsigned /*count*/)
{
	arg = PAR_parse_value(tdbb, csb);
	arg2 = PAR_parse_value(tdbb, csb);
}

void RegrCountAggNode::make(DsqlCompilerScratch* dsqlScratch, dsc* desc)
{
	desc->makeInt64(0);
}

void RegrCountAggNode::getDesc(thread_db* tdbb, CompilerScratch* csb, dsc* desc)
{
	desc->makeInt64(0);
}

ValueExprNode* RegrCountAggNode::copy(thread_db* tdbb, NodeCopier& copier) const
{
	RegrCountAggNode* node = FB_NEW_POOL(*tdbb->getDefaultPool()) RegrCountAggNode(*tdbb->getDefaultPool());
	node->nodScale = nodScale;
	node->arg = copier.copy(tdbb, arg);
	node->arg2 = copier.copy(tdbb, arg2);
	return node;
}

string RegrCountAggNode::internalPrint(NodePrinter& printer) const
{
	AggNode::internalPrint(printer);

	NODE_PRINT(printer, arg2);

	return "RegrCountAggNode";
}

void RegrCountAggNode::aggInit(thread_db* tdbb, Request* request) const
{
	AggNode::aggInit(tdbb, request);

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	impure->make_int64(0);
}

bool RegrCountAggNode::aggPass(thread_db* tdbb, Request* request) const
{
	if (!EVL_expr(tdbb, request, arg))
		return false;

	if (!EVL_expr(tdbb, request, arg2))
		return false;

	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);
	++impure->vlu_misc.vlu_int64;

	return true;
}

void RegrCountAggNode::aggPass(thread_db* /*tdbb*/, Request* /*request*/, dsc* /*desc*/) const
{
	fb_assert(false);
}

dsc* RegrCountAggNode::aggExecute(thread_db* tdbb, Request* request) const
{
	impure_value_ex* impure = request->getImpure<impure_value_ex>(impureOffset);

	if (!impure->vlu_desc.dsc_dtype)
		return NULL;

	return &impure->vlu_desc;
}

AggNode* RegrCountAggNode::dsqlCopy(DsqlCompilerScratch* dsqlScratch) /*const*/
{
	return FB_NEW_POOL(dsqlScratch->getPool()) RegrCountAggNode(dsqlScratch->getPool(),
		doDsqlPass(dsqlScratch, arg), doDsqlPass(dsqlScratch, arg2));
}


}	// namespace Jrd