Frontport PR #8871: Fix locking error if IN/EXISTS is converted into a semi-join

Author: dyemanov

src/jrd/recsrc/ExternalTableScan.cpp

@@ -108,10 +108,8 @@ bool ExternalTableScan::refetchRecord(thread_db* /*tdbb*/) const
 	return true;
 }
 
-WriteLockResult ExternalTableScan::lockRecord(thread_db* tdbb) const
+WriteLockResult ExternalTableScan::lockRecord(thread_db* /*tdbb*/) const
 {
-	SET_TDBB(tdbb);
-
 	status_exception::raise(Arg::Gds(isc_record_lock_not_supp));
 }
 

src/jrd/recsrc/LocalTableStream.cpp

@@ -104,7 +104,7 @@ bool LocalTableStream::refetchRecord(thread_db* tdbb) const
 	return true;
 }
 
-WriteLockResult LocalTableStream::lockRecord(thread_db* tdbb) const
+WriteLockResult LocalTableStream::lockRecord(thread_db* /*tdbb*/) const
 {
 	status_exception::raise(Arg::Gds(isc_record_lock_not_supp));
 }

src/jrd/recsrc/RecordSource.h

@@ -1175,8 +1175,11 @@ namespace Jrd
 			return true;
 		}
 
-		WriteLockResult lockRecord(thread_db* /*tdbb*/) const override
+		WriteLockResult lockRecord(thread_db* tdbb) const override
 		{
+			if (m_joinType == JoinType::SEMI || m_joinType == JoinType::ANTI)
+				return m_args.front()->lockRecord(tdbb);
+
 			Firebird::status_exception::raise(Firebird::Arg::Gds(isc_record_lock_not_supp));
 		}