Skip to content

Commit 9873052

Browse files
committed
Removed outdated comments, some new added.
1 parent 4b71466 commit 9873052

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/include/firebird/impl/blr.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,7 @@
138138
#define blr_minimum (unsigned char)30
139139
#define blr_total (unsigned char)31
140140
#define blr_receive_batch (unsigned char)32
141-
142-
// unused code: 33
143141
#define blr_bulk_insert (unsigned char)33
144-
145142
#define blr_add (unsigned char)34
146143
#define blr_subtract (unsigned char)35
147144
#define blr_multiply (unsigned char)36

src/jrd/tra.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4244,10 +4244,13 @@ BulkInsert* jrd_tra::getBulkInsert(thread_db* tdbb, jrd_rel* relation, bool crea
42444244
return tra_bulkInsert;
42454245
}
42464246

4247-
void jrd_tra::finiBulkInsert(thread_db* tdbb, bool commit)
4247+
void jrd_tra::finiBulkInsert(thread_db* tdbb, bool /*commit*/)
42484248
{
42494249
if (tra_bulkInsert)
42504250
{
4251+
// Currently, there is no way to explicitly undo bulk insert actions, while it
4252+
// might be implemented later if needed. Thus "commit" arg is not used for now.
4253+
42514254
tra_bulkInsert->flush(tdbb);
42524255

42534256
delete tra_bulkInsert;

0 commit comments

Comments
 (0)