Skip to content

Commit a09493d

Browse files
committed
Fix warnings.
1 parent 0884411 commit a09493d

4 files changed

Lines changed: 18 additions & 11 deletions

File tree

src/common/StatusHolder.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,10 +325,10 @@ class LocalStatus : public AutoStorage, public BaseStatus<LocalStatus>
325325
}
326326

327327
static void setVersionError(IStatus* status, const char* interfaceName,
328-
unsigned currentVersion, unsigned expectedVersion)
328+
uintptr_t currentVersion, unsigned expectedVersion)
329329
{
330330
BaseStatusWrapper<LocalStatus>::setVersionError(
331-
status, interfaceName,currentVersion, expectedVersion);
331+
status, interfaceName, currentVersion, expectedVersion);
332332
}
333333
};
334334

src/gpre/languages/cob.cpp

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2699,7 +2699,11 @@ static void gen_get_segment( const act* action)
26992699
names[isc_a_pos], blob->blb_ident,
27002700
names[isc_a_pos], blob->blb_len_ident,
27012701
BY_VALUE, blob->blb_seg_length, END_VALUE,
2702-
BY_REF, names[isc_a_pos], blob->blb_buff_ident, names[isc_status_pos]);
2702+
BY_REF, names[isc_a_pos], blob->blb_buff_ident
2703+
#ifdef GIVING_SUPPORTED
2704+
, names[isc_status_pos]
2705+
#endif
2706+
);
27032707

27042708
COB_print_buffer(output_buffer, true);
27052709

@@ -2872,7 +2876,11 @@ static void gen_put_segment( const act* action)
28722876
status_vector(action),
28732877
BY_REF, names[isc_a_pos], blob->blb_ident,
28742878
BY_VALUE, names[isc_a_pos], blob->blb_len_ident, END_VALUE,
2875-
BY_REF, names[isc_a_pos], blob->blb_buff_ident, names[isc_status_pos]);
2879+
BY_REF, names[isc_a_pos], blob->blb_buff_ident
2880+
#ifdef GIVING_SUPPORTED
2881+
, names[isc_status_pos]
2882+
#endif
2883+
);
28762884
COB_print_buffer(output_buffer, true);
28772885

28782886
set_sqlcode(action);
@@ -4283,4 +4291,3 @@ static void t_start_auto(const gpre_req* request,
42834291

42844292
set_sqlcode(action);
42854293
}
4286-

src/include/firebird/Interface.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ namespace Firebird
229229
}
230230

231231
static void setVersionError(IStatus* status, const char* interfaceName,
232-
unsigned currentVersion, unsigned expectedVersion)
232+
uintptr_t currentVersion, unsigned expectedVersion)
233233
{
234234
intptr_t codes[] = {
235235
isc_arg_gds,

src/lock/tests/LockManagerTest.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -196,19 +196,19 @@ BOOST_AUTO_TEST_CASE(LockUnlockNoWaitTest)
196196

197197
BOOST_AUTO_TEST_CASE(LockUnlockAstTest)
198198
{
199-
struct Lock;
199+
struct LocalLock;
200200

201201
struct ThreadData
202202
{
203203
std::thread::id threadId;
204204
LockManager* lockManager = nullptr;
205205
std::mutex localMutex;
206-
std::unordered_map<SLONG, std::unique_ptr<Lock>> locks;
206+
std::unordered_map<SLONG, std::unique_ptr<LocalLock>> locks;
207207
SLONG ownerHandle = 0;
208208
bool shutdown = false;
209209
};
210210

211-
struct Lock
211+
struct LocalLock
212212
{
213213
ThreadData* threadData = nullptr;
214214
unsigned key = 0;
@@ -232,7 +232,7 @@ BOOST_AUTO_TEST_CASE(LockUnlockAstTest)
232232
std::latch latch(THREAD_COUNT);
233233

234234
static const auto ast = [](void* astArg) -> int {
235-
const auto lock = static_cast<Lock*>(astArg);
235+
const auto lock = static_cast<LocalLock*>(astArg);
236236
const auto threadData = lock->threadData;
237237

238238
std::lock_guard localMutexGuard(threadData->localMutex);
@@ -273,7 +273,7 @@ BOOST_AUTO_TEST_CASE(LockUnlockAstTest)
273273

274274
for (unsigned i = 0; i < ITERATION_COUNT; ++i)
275275
{
276-
auto lock = std::make_unique<Lock>();
276+
auto lock = std::make_unique<LocalLock>();
277277
lock->threadData = &threadData;
278278
lock->key = i;
279279

0 commit comments

Comments
 (0)