Skip to content

Commit 7c98e0c

Browse files
committed
Configure and test all Srp plugins
1 parent 7879c84 commit 7c98e0c

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
with:
2525
version: '5.0.3'
2626
firebird_root_password: 'masterkey'
27-
firebird_conf: 'WireCrypt=Enabled,AuthServer=Srp256;Srp;Legacy_Auth,UserManager=Srp;Legacy_UserManager'
27+
firebird_conf: 'WireCrypt=Enabled,AuthServer=Srp256;Srp;Legacy_Auth;Srp224;Srp384;Srp512,UserManager=Srp;Legacy_UserManager'
2828
- uses: actions/checkout@v6
2929
- name: Set up Java ${{ matrix.java.version }}
3030
uses: actions/setup-java@v5

src/test/org/firebirdsql/common/extension/RunEnvironmentExtension.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@ public boolean isMet() {
9797
ALL_SRP_PLUGINS {
9898
@Override
9999
public boolean isMet() {
100-
// Enabling all SRP plugins is messy in the jacobalberty/firebird Docker image,
101-
// so assume it is not available
102-
return !DB_ON_DOCKER;
100+
// NOTE: This requirement exist for historic reasons; configuring all plugins on
101+
// the jacobalberty/firebird image was hard to do (especially using juarezr/firebirdsql-github-action)
102+
return true;
103103
}
104104
}
105105
;

0 commit comments

Comments
 (0)