Don't create reference to a temporary

Ansariel · Ansariel · commit 8b58c6b9aa13 · 2025-12-13T23:22:11.000+01:00
diff --git a/indra/newview/fsfloaterim.cpp b/indra/newview/fsfloaterim.cpp
@@ -1595,7 +1595,7 @@ void FSFloaterIM::updateMessages()
             // See also LLSpeakers::updateSpeakers() for own "has_spoken" extension. -Zi
             if (!is_history && !pIMSession->mSpeakers->findSpeaker(from_id))
             {
-                const std::string& from_id_str = from_id.asString();
+                const std::string from_id_str = from_id.asString();
                 LLSD new_speaker;
                 new_speaker["session_id"] = mSessionID;
                 new_speaker["agent_updates"][from_id_str]["transition"] = "ENTER";

Original file line number	Diff line number	Diff line change
`@@ -1595,7 +1595,7 @@ void FSFloaterIM::updateMessages()`
`1595`	`1595`	`// See also LLSpeakers::updateSpeakers() for own "has_spoken" extension. -Zi`
`1596`	`1596`	`if (!is_history && !pIMSession->mSpeakers->findSpeaker(from_id))`
`1597`	`1597`	`{`
`1598`		`- const std::string& from_id_str = from_id.asString();`
	`1598`	`+ const std::string from_id_str = from_id.asString();`
`1599`	`1599`	`LLSD new_speaker;`
`1600`	`1600`	`new_speaker["session_id"] = mSessionID;`
`1601`	`1601`	`new_speaker["agent_updates"][from_id_str]["transition"] = "ENTER";`