4.6.19R

- Fixed rigidbodies never settling on clients often resulting in very subtle shaking and excessive replicate/reconcile sends.
- Fixed WriteUnsignedPackedWhole ensuring 9 bytes rather than 10, very rarely causing out of bounds exception when writing large numbers.
- Fixed replayed replicates executing 1 tick early.
- Improved notes within CharacterControllerPrediction demo script.
- Improved upgraded internal API for Unity 6.
- Added NetworkObject.LocalReconcileCorrectionType when using physics prediction; this repairs rigidbody drifting during replays due to non-deterministic physics.

Author: FirstGearGames

Assets/FishNet/CodeGenerating/Helpers/Extension/ModuleDefinitionExtensions.cs

@@ -49,7 +49,7 @@ public static MethodReference ImportReference(this ModuleDefinition module, Lamb
 
             if (expression.Body is MemberExpression memberExpression)
             {
-                var property = memberExpression.Member as PropertyInfo;
+                PropertyInfo property = memberExpression.Member as PropertyInfo;
                 return module.ImportReference(property.GetMethod);
             }
 

Assets/FishNet/CodeGenerating/Helpers/Extension/TypeDefinitionExtensions.cs

@@ -341,7 +341,7 @@ internal static MethodDefinition AddMethod(this TypeDefinition typDef, string me
         /// <returns></returns>
         internal static MethodDefinition AddMethod(this TypeDefinition typeDef, string methodName, MethodAttributes attributes, TypeReference typeReference)
         {
-            var method = new MethodDefinition(methodName, attributes, typeReference);
+            MethodDefinition method = new(methodName, attributes, typeReference);
             typeDef.Methods.Add(method);
             return method;
         }

Assets/FishNet/CodeGenerating/Helpers/NetworkBehaviourHelper.cs

@@ -131,7 +131,7 @@ public override bool ImportReferences()
                     Replicate_Replay_MethodRef = ImportReference(mi);
                 else if (mi.Name == nameof(NetworkBehaviour.Replicate_Reader))
                     Replicate_Reader_MethodRef = ImportReference(mi);
-                else if (mi.Name == nameof(NetworkBehaviour.Reconcile_Reader))
+                else if (mi.Name == nameof(NetworkBehaviour.Reconcile_Reader_Remote))
                     Reconcile_Reader_MethodRef = ImportReference(mi);
                 else if (mi.Name == nameof(NetworkBehaviour.Reconcile_Server))
                     Reconcile_Server_MethodRef = ImportReference(mi);

Assets/FishNet/CodeGenerating/Helpers/WriterImports.cs

@@ -49,7 +49,7 @@ public override bool ImportReferences()
             // WriterPool.GetWriter
             Type writerPoolType = typeof(WriterPool);
             ImportReference(writerPoolType);
-            foreach (var methodInfo in writerPoolType.GetMethods())
+            foreach (MethodInfo methodInfo in writerPoolType.GetMethods())
             {
                 if (methodInfo.Name == nameof(WriterPool.Retrieve))
                 {

Assets/FishNet/CodeGenerating/ILCore/FNPostProcessorAssemblyResolver.cs

@@ -33,29 +33,29 @@ public AssemblyDefinition Resolve(AssemblyNameReference name, ReaderParameters p
                     return m_SelfAssembly;
                 }
 
-                var fileName = FindFile(name);
+                string fileName = FindFile(name);
                 if (fileName == null)
                 {
                     return null;
                 }
 
-                var lastWriteTime = File.GetLastWriteTime(fileName);
-                var cacheKey = $"{fileName}{lastWriteTime}";
-                if (m_AssemblyCache.TryGetValue(cacheKey, out var result))
+                DateTime lastWriteTime = File.GetLastWriteTime(fileName);
+                string cacheKey = $"{fileName}{lastWriteTime}";
+                if (m_AssemblyCache.TryGetValue(cacheKey, out AssemblyDefinition result))
                 {
                     return result;
                 }
 
                 parameters.AssemblyResolver = this;
 
-                var ms = MemoryStreamFor(fileName);
-                var pdb = $"{fileName}.pdb";
+                MemoryStream ms = MemoryStreamFor(fileName);
+                string pdb = $"{fileName}.pdb";
                 if (File.Exists(pdb))
                 {
                     parameters.SymbolStream = MemoryStreamFor(pdb);
                 }
 
-                var assemblyDefinition = AssemblyDefinition.ReadAssembly(ms, parameters);
+                AssemblyDefinition assemblyDefinition = AssemblyDefinition.ReadAssembly(ms, parameters);
                 m_AssemblyCache.Add(cacheKey, assemblyDefinition);
 
                 return assemblyDefinition;
@@ -64,7 +64,7 @@ public AssemblyDefinition Resolve(AssemblyNameReference name, ReaderParameters p
 
         private string FindFile(AssemblyNameReference name)
         {
-            var fileName = m_AssemblyReferences.FirstOrDefault(r => Path.GetFileName(r) == $"{name.Name}.dll");
+            string fileName = m_AssemblyReferences.FirstOrDefault(r => Path.GetFileName(r) == $"{name.Name}.dll");
             if (fileName != null)
             {
                 return fileName;
@@ -92,10 +92,10 @@ private static MemoryStream MemoryStreamFor(string fileName)
             return Retry(10, TimeSpan.FromSeconds(1), () =>
             {
                 byte[] byteArray;
-                using (var fs = new FileStream(fileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
+                using (FileStream fs = new(fileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
                 {
                     byteArray = new byte[fs.Length];
-                    var readLength = fs.Read(byteArray, 0, (int)fs.Length);
+                    int readLength = fs.Read(byteArray, 0, (int)fs.Length);
                     if (readLength != fs.Length)
                     {
                         throw new InvalidOperationException("File read length is not full length of file.");