#69 fix coin conversion for special denoms such as om

Signed-off-by: Long Zhang <gluckzhang@gmail.com>

Author: gluckzhang

td2/alert.go

@@ -1006,10 +1006,12 @@ func evaluateUnclaimedRewardsAlert(cc *ChainConfig) (bool, bool) {
 			return alert, resolved
 		}
 
+		convertedToDisplay := false
 		if cc.denomMetadata != nil {
 			convertedCoins, err := utils.ConvertDecCoinToDisplayUnit(nativeCoins, *cc.denomMetadata)
 			if err == nil {
 				nativeCoins = *convertedCoins
+				convertedToDisplay = true
 			} else {
 				l(slog.LevelDebug, fmt.Errorf("cannot convert rewards/commission to display unit for %s, err: %w", cc.name, err))
 			}
@@ -1024,26 +1026,17 @@ func evaluateUnclaimedRewardsAlert(cc *ChainConfig) (bool, bool) {
 			return alert, resolved
 		}
 
-		if err := github_com_cosmos_cosmos_sdk_types.ValidateDenom(targetDenom); err != nil {
-			fallback := ""
-			if len(nativeCoins) > 0 {
-				if errFallback := github_com_cosmos_cosmos_sdk_types.ValidateDenom(nativeCoins[0].Denom); errFallback == nil {
-					fallback = nativeCoins[0].Denom
-				}
-			}
-			if fallback == "" {
-				l(slog.LevelError, fmt.Errorf("invalid target denom %q for %s: %w", targetDenom, cc.name, err))
-				return alert, resolved
-			}
-			l(slog.LevelDebug, fmt.Errorf("invalid target denom %q for %s: %w; falling back to %q", targetDenom, cc.name, err, fallback))
-			targetDenom = fallback
+		// coinPrice is for the chain display token. If metadata exists but conversion to display
+		// failed, the amount may still be in base units (e.g. uom), which would misprice by 10^exp.
+		// Skip this alert evaluation rather than raising a false amount-based alert.
+		if cc.denomMetadata != nil && !convertedToDisplay {
+			l(slog.LevelDebug, fmt.Errorf("skipping unclaimed rewards pricing for %s because rewards are not confirmed in display units", cc.name))
+			return alert, resolved
 		}
 
-		totalRewards := github_com_cosmos_cosmos_sdk_types.NewDecCoinFromDec(targetDenom, totalAmount)
-
 		coinPrice, err := td.coinMarketCapClient.GetPrice(td.ctx, cc.Slug)
-		if err == nil {
-			totalRewardsConverted := totalRewards.Amount.MustFloat64() * coinPrice.Price
+		if err == nil && convertedToDisplay {
+			totalRewardsConverted := totalAmount.MustFloat64() * coinPrice.Price
 			threshold := floatVal(cc.Alerts.UnclaimedRewardsThreshold)
 
 			alertID := fmt.Sprintf("UnclaimedRewards_%s", cc.ValAddress)

td2/run.go

@@ -67,7 +67,7 @@ func Run(configFile, stateFile, chainConfigDirectory string, password *string, d
 
 	if td.EnableDash {
 		go dash.Serve(td.Listen, td.updateChan, td.logChan, td.HideLogs, devMode)
-		l(slog.LevelInfo, "starting dashboard on", td.Listen)
+		l(slog.LevelInfo, "starting dashboard on ", td.Listen)
 	} else {
 		go func() {
 			for {
@@ -147,7 +147,7 @@ func saveOnExit(stateFile string, saved chan any) {
 		defer close(saved)
 		slog.Info("saving state")
 		//#nosec -- variable specified on command line
-		f, e := os.OpenFile(stateFile, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0600)
+		f, e := os.OpenFile(stateFile, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0o600)
 		if e != nil {
 			slog.Error("failed to open state file for writing", "err", e)
 			return

td2/utils/price-conversion.go

@@ -239,10 +239,6 @@ func ConvertDecCoinToDisplayUnit(coins []github_com_cosmos_cosmos_sdk_types.DecC
 	} else {
 		displayDenom = metadata.Display
 	}
-	if err := github_com_cosmos_cosmos_sdk_types.ValidateDenom(displayDenom); err != nil {
-		return nil, fmt.Errorf("invalid display denom %q for base %q: %w", displayDenom, metadata.Base, err)
-	}
-
 	// Find the exponent for the display denom
 	foundDisplayDenom := false
 	for _, unit := range metadata.DenomUnits {
@@ -311,7 +307,12 @@ func ConvertDecCoinToDisplayUnit(coins []github_com_cosmos_cosmos_sdk_types.DecC
 			convertedAmount = coin.Amount.Mul(multiplier)
 		}
 
-		convertedCoins = append(convertedCoins, github_com_cosmos_cosmos_sdk_types.NewDecCoinFromDec(displayDenom, convertedAmount))
+		// Use a struct literal instead of NewDecCoinFromDec so short display denoms (e.g. "om")
+		// can still be represented after conversion.
+		convertedCoins = append(convertedCoins, github_com_cosmos_cosmos_sdk_types.DecCoin{
+			Denom:  displayDenom,
+			Amount: convertedAmount,
+		})
 	}
 
 	return &convertedCoins, nil
@@ -328,17 +329,11 @@ func ConvertFloatInBaseUnitToDisplayUnit(value float64, metadata bank.Metadata)
 	// If no display is set, default to base
 	if metadata.Display == "" {
 		displayDenom = metadata.Base
-		if err := github_com_cosmos_cosmos_sdk_types.ValidateDenom(displayDenom); err != nil {
-			return 0, "", fmt.Errorf("invalid display denom %q for base %q: %w", displayDenom, metadata.Base, err)
-		}
 		// If display is base, no conversion needed
 		return value, displayDenom, nil
 	} else {
 		displayDenom = metadata.Display
 	}
-	if err := github_com_cosmos_cosmos_sdk_types.ValidateDenom(displayDenom); err != nil {
-		return 0, "", fmt.Errorf("invalid display denom %q for base %q: %w", displayDenom, metadata.Base, err)
-	}
 
 	// Find the exponent for the display denom
 	foundDisplayDenom := false

td2/validator.go

@@ -179,7 +179,7 @@ func (cc *ChainConfig) GetValInfo(first bool) (err error) {
 			}
 		}
 		if first {
-			l("⚙️", cc.ValAddress[:20], "... is using consensus key:", cc.valInfo.Valcons)
+			l("⚙️ ", cc.ValAddress[:20], "... is using consensus key: ", cc.valInfo.Valcons)
 		}
 	}