Soundcloud embeds (2nd attempt)#847
Conversation
ChrisButterworth
commented
Feb 26, 2026
ChrisButterworth
commented
- Updated cookie consent to track consent
- Added helper to hide embed until consent given
- Updating faq template to include the helper functon
sean-dunwoody
left a comment
sean-dunwoody
left a comment
There was a problem hiding this comment.
Hi @ChrisButterworth ,
This looks good to me. I've just added a couple of minor comments and questions for review if you have time.
Please make sure this gets tested on staging before merging it in.
| $accordion_image_alt = !empty($accodion_image['data']['description']) ? $accodion_image['data']['description'] : ''; | ||
| } | ||
| @endphp | ||
| <img class="mt-2 mb-4" src="{{ $accordion_image_src }}" alt="{{ $accordion_image_alt }}" load="lazy"> |
There was a problem hiding this comment.
Would it not make more sense to wrap this in the if(!empty($accordion_image)) check?
Otherwise this image could be empty?
|
Deployed to staging ready to test! |
|
@ChrisButterworth I fixed a couple of issues with the template code (check commits for more information). I've deployed this to staging but there is still an issue with the JavaScript code that is preventing this from working correctly: https://fitzmuseum.studio24.dev/plan-your-visit/exhibitions/test-exhibition-2025-2 Can you please look into this and resolve it. |
It was a single line that needed to be fixed!! |
3 participants
