Addressed PR feedback

Author: itsniper

Demo/ReliaBLE Demo/ReliaBLE Demo/Central/CentralView.swift

@@ -138,7 +138,7 @@ struct CentralView: View {
 
     private var deviceList: some View {
         List {
-            ForEach(Array(devices.enumerated()), id: \.element.persistentModelID) { index, device in
+            ForEach(devices, id: \.persistentModelID) { device in
                 NavigationLink {
                     Group {
                         let currentState = viewModel.connectionStates[device.id]

Sources/ReliaBLE/BluetoothActor.swift

@@ -668,7 +668,7 @@ actor BluetoothActor {
             log?.warn(tags: [.category(.connection)], "didDisconnect for unknown peripheral — dropped")
             return
         }
-        let mappedError: PeripheralError? = payload.error.flatMap { ($0 as? CBError).map { PeripheralError.fromCBError($0) } }
+        let mappedError: PeripheralError? = payload.error.map { ($0 as? CBError).map(PeripheralError.fromCBError) ?? .unknown }
         let state: ConnectionState = .disconnected(reason: mappedError)
         connectionStates[id] = state
         if let error = mappedError {
@@ -684,7 +684,7 @@ actor BluetoothActor {
             log?.warn(tags: [.category(.connection)], "didFailToConnect for unknown peripheral — dropped")
             return
         }
-        let mappedError: PeripheralError? = payload.error.flatMap { ($0 as? CBError).map { PeripheralError.fromCBError($0) } }
+        let mappedError: PeripheralError? = payload.error.map { ($0 as? CBError).map(PeripheralError.fromCBError) ?? .unknown }
         let state: ConnectionState = .failed(reason: mappedError)
         connectionStates[id] = state
         log?.warn(tags: [.peripheral(id), .category(.connection)], "Peripheral connection failed with error: \(mappedError ?? .unknown)")
@@ -780,14 +780,14 @@ final class BluetoothDelegateShim: NSObject, CBCentralManagerDelegate {
         let payload = ConnectionPayload(peripheral: peripheral, error: nil)
         eventContinuation.yield(.connected(payload))
     }
-
-    func centralManager(_ central: CBCentralManager, didDisconnectPeripheral peripheral: CBPeripheral, timestamp: CFAbsoluteTime, isReconnecting: Bool, error: Error?) {
+    
+    func centralManager(_ central: CBCentralManager, didFailToConnect peripheral: CBPeripheral, error: Error?) {
         let payload = ConnectionPayload(peripheral: peripheral, error: error)
-        eventContinuation.yield(.disconnected(payload))
+        eventContinuation.yield(.connectFailed(payload))
     }
 
-    func centralManager(_ central: CBCentralManager, didFailToConnect peripheral: CBPeripheral, error: Error?) {
+    func centralManager(_ central: CBCentralManager, didDisconnectPeripheral peripheral: CBPeripheral, timestamp: CFAbsoluteTime, isReconnecting: Bool, error: Error?) {
         let payload = ConnectionPayload(peripheral: peripheral, error: error)
-        eventContinuation.yield(.connectFailed(payload))
+        eventContinuation.yield(.disconnected(payload))
     }
 }

Sources/ReliaBLE/Documentation.docc/GettingStarted.md

@@ -147,23 +147,24 @@ Use ``ReliaBLEManager/connect(to:)`` to initiate a connection to a discovered ``
 
 ```swift
 do {
-    try await bleManager.connect(to: peripheral)
-
-    for await change in bleManager.connectionStateChanges
-        where change.peripheralId == peripheral.id {
-        switch change.state {
-        case .connected:
-            print("Connected to \(peripheral.id)")
-        case .disconnected(let reason):
-            print("Disconnected", reason ?? "clean")
-        case .failed(let reason):
-            print("Failed", reason ?? "")
-        default:
-            break
+    Task {
+        for await change in bleManager.connectionStateChanges
+            where change.peripheralId == peripheral.id {
+            switch change.state {
+            case .connected:
+                print("Connected to \(peripheral.id)")
+                try await bleManager.disconnect(from: peripheral)
+            case .disconnected(let reason):
+                print("Disconnected", reason ?? "clean")
+            case .failed(let reason):
+                print("Failed", reason ?? "")
+            default:
+                break
+            }
         }
     }
 
-    try await bleManager.disconnect(from: peripheral)
+    try await bleManager.connect(to: peripheral)
 } catch PeripheralError.notFound {
     // The snapshot is stale — its underlying peripheral reference was invalidated
     // (for example, after a Bluetooth reset). Re-scan to rediscover it.

Tests/ReliaBLETests/ReliaBLEManagerTests.swift

@@ -772,10 +772,6 @@ final class CapturingLogWriter: LogWriter, @unchecked Sendable {
 /// Helpers for driving the Nordic `CBMCentralManagerMock` simulation under the constraints of the
 /// process-wide ``BluetoothActor`` singleton.
 enum Mock {
-    /// The resolved ``Peripheral/id`` of the simulated test peripheral.
-    ///
-    /// The actor resolves a peripheral's id as `name ?? advertisement.localName ?? identifier`. Our spec advertises
-    /// this exact local name, so the discovered snapshot's `id` is deterministic.
     /// The resolved ``Peripheral/id`` of the simulated test peripheral.
     ///
     /// The actor resolves a peripheral's id as `name ?? advertisement.localName ?? identifier`. Our spec advertises