Claude cleanup (#276)

* claude cleanup

* update

* update

Author: matthieugomez

.github/workflows/CompatHelper.yml

@@ -15,7 +15,7 @@ jobs:
         run: which julia
         continue-on-error: true
       - name: Install Julia, but only if it is not already available in the PATH
-        uses: julia-actions/setup-julia@v1
+        uses: julia-actions/setup-julia@v2
         with:
           version: '1'
           arch: ${{ runner.arch }}

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         version:
-          - '1.9'
+          - '1.10'
           - '1'
           # - 'nightly'
         os:

.gitignore

@@ -1,3 +1,4 @@
-
+Manifest.toml
+settings.local.json
 benchmark/.sublime2Terminal.jl
 .vscode/settings.json

Project.toml

@@ -19,7 +19,7 @@ Vcov = "ec2bfdc2-55df-4fc9-b9ae-4958c2cf2486"
 
 [compat]
 DataFrames = "0.21, 0.22, 1"
-FixedEffects = "2.6"
+FixedEffects = "2.6, 3"
 PrecompileTools = "1"
 Reexport = "0.1, 0.2, 1"
 Statistics = "1"
@@ -29,7 +29,7 @@ StatsFuns = "0.9, 1"
 StatsModels = "0.7"
 Tables = "1"
 Vcov = "0.8"
-julia = "1.9"
+julia = "1.10"
 
 
 [extras]

src/FixedEffectModel.jl

@@ -99,7 +99,7 @@ function StatsAPI.adjr2(model::FixedEffectModel, variant::Symbol=:devianceratio)
         n = nobs(model)
         dev  = deviance(model)
         dev0 = nulldeviance(model)
-        1 - (dev*(n - (has_int | has_fe(model)))) / (dev0 * max(n - k, 1))
+        1 - (dev*(n - (has_int || has_fe(model)))) / (dev0 * max(n - k, 1))
     else
         throw(ArgumentError("variant must be one of :McFadden or :devianceratio"))
     end
@@ -184,7 +184,7 @@ function StatsAPI.residuals(m::FixedEffectModel, data)
     Tables.istable(data) ||
       throw(ArgumentError("expected second argument to be a Table, got $(typeof(data))"))
     has_fe(m) &&
-     throw("To access residuals for a model with high-dimensional fixed effects,  run `m = reg(..., save = :residuals)` and then access residuals with `residuals(m)`.")
+     throw(ArgumentError("To access residuals for a model with high-dimensional fixed effects, run `m = reg(..., save = :residuals)` and then access residuals with `residuals(m)`."))
     cdata = StatsModels.columntable(data)
     cols, nonmissings = StatsModels.missing_omit(cdata, m.formula_schema.rhs)
     Xnew = modelmatrix(m.formula_schema, cols)
@@ -201,8 +201,10 @@ end
 
 function StatsAPI.residuals(m::FixedEffectModel)
     if m.residuals === nothing
-        has_fe(m) && throw("To access residuals in a fixed effect regression,  run `reg` with the option save = :residuals, and then access residuals with `residuals()`")
-        !has_fe(m) && throw("To access residuals,  use residuals(m, data) where `m` is an estimated FixedEffectModel and  `data` is a Table")
+        throw(ArgumentError(
+            has_fe(m) ? "To access residuals in a fixed effect regression, run `reg` with the option save = :residuals, and then access residuals with `residuals()`" :
+            "To access residuals, use residuals(m, data) where `m` is an estimated FixedEffectModel and `data` is a Table"
+        ))
     end
     m.residuals
 end
@@ -214,11 +216,11 @@ Return a DataFrame with fixed effects estimates.
 The output is aligned with the original DataFrame used in `reg`.
 
 ### Keyword arguments
-* `keepkeys::Bool' : Should the returned DataFrame include the original variables used to defined groups? Default to false
+* `keepkeys::Bool` : Should the returned DataFrame include the original variables used to defined groups? Default to false
 """
 
 function fe(m::FixedEffectModel; keepkeys = false)
-   !has_fe(m) && throw("fe() is not defined for fixed effect models without fixed effects")
+   !has_fe(m) && throw(ArgumentError("fe() is not defined for fixed effect models without fixed effects"))
    if keepkeys
        m.fe
    else