Made sure all our pattern calls are now try/catch safe to avoid crashing

Author: mitchcapper

src/FlaUInspect/ViewModels/ElementViewModel.cs

@@ -7,13 +7,15 @@
 using System.Collections.ObjectModel;
 using System.Windows.Input;
 using MenuItem = System.Windows.Controls.MenuItem;
+using User32=FlaUI.Core.WindowsAPI.User32;
 namespace FlaUInspect.ViewModels;
 
 public class ElementViewModel(AutomationElement? automationElement, ILogger? logger) : ObservableObject {
     private readonly object _lockObject = new ();
     public AutomationElement? AutomationElement { get; } = automationElement;
     private RelayCommand? _refreshItemCommand;
     private RelayCommand? _focusCommand;
+    private RelayCommand? _focusNativeCommand;
 
     public bool IsExpanded {
         get => GetProperty<bool>();
@@ -47,24 +49,55 @@ public bool IsSelected {
         });
 
     public ICommand FocusCommand =>
-        _focusCommand ??= new((_) => {
+        _focusCommand ??= CreateDelayedSafeCommand(AutomationElement.Focus);
+
+    public ICommand FocusNativeCommand =>
+        _focusNativeCommand ??= CreateDelayedSafeCommand(DoNativeFocus);
+
+    private async void DoNativeFocus() {
+        try{
+        //await Task.Delay(250);
+            if (AutomationElement.Properties.ProcessId.TryGetValue(out int processId)){
+                var proc = System.Diagnostics.Process.GetProcessById(processId);
+                var res = User32.SetForegroundWindow(proc.MainWindowHandle);
+                await Task.Delay(100);
+            }
+            AutomationElement.FocusNative();
+        }catch(Exception ex){
+            System.Diagnostics.Debug.WriteLine(ex.ToString());
+        }
+    }
+
+    private static RelayCommand CreateDelayedSafeCommand(Action action, int delayMs=250){
+        var delayedAction = CreateDelayedSafeAction(action,delayMs);
+        return new RelayCommand(_ => delayedAction());
+    }
+    /// <summary>
+    /// Mouse/focus related commands need a delay to allow our mosue action t obe handled first or we resteal the mouse
+    /// </summary>
+    /// <param name="action"></param>
+    /// <param name="delayMs"></param>
+    /// <returns></returns>
+    public static Action CreateDelayedSafeAction(Action action, int delayMs=250) {
+        return async () => {
             try {
-                AutomationElement.Focus();
+                await Task.Delay(delayMs);
+                action();
             } catch { }
-        });
-
+        };
+    }
 
     private ObservableCollection<MenuItem>? _mouseActions;
     public ObservableCollection<MenuItem> MouseActions { get => _mouseActions ??= BuildMouseActions(); }
 
     private ObservableCollection<MenuItem> BuildMouseActions() {
         return [
-            CreateMenuItem("Left Click", () => AutomationElement?.Click()),
-            CreateMenuItem("Right Click", () => AutomationElement?.RightClick()),
-            CreateMenuItem("Double Click", () => AutomationElement?.DoubleClick()),
+            CreateMenuItem("Left Click", CreateDelayedSafeAction(() => AutomationElement?.Click())),
+            CreateMenuItem("Right Click", CreateDelayedSafeAction(() => AutomationElement?.RightClick())),
+            CreateMenuItem("Double Click", CreateDelayedSafeAction(() => AutomationElement?.DoubleClick())),
         ];
     }
-
+    private MenuItem CreateMenuItem(string header, Action<object> value) => CreateMenuItem(header,()=>value(default));
     private MenuItem CreateMenuItem(string header, Action value) {
         return new MenuItem {
             Header = header,

src/FlaUInspect/ViewModels/MainViewModel.cs

@@ -216,7 +216,8 @@ private void ReadPatternsForSelectedItem(AutomationElement? selectedItemAutomati
                              System.Windows.Controls.MenuItem actionMenuItem = new() {
                                 Header = $"{patternItem.Key}"
                             };
-                            actionMenuItem.Click += (_, _) => patternItem.Action?.Invoke();
+                            var safeAction = ElementViewModel.CreateDelayedSafeAction(patternItem.Action);
+                            actionMenuItem.Click += (_, _) => safeAction();
                             PatternActionContextItems.Add(actionMenuItem);
                         }
                     }

src/FlaUInspect/Views/MainWindow.xaml

@@ -320,6 +320,7 @@
 										<ContextMenu>
 											<MenuItem Header="Refresh Children" Command="{Binding RefreshItemCommand}" />
                                             <MenuItem Header="Focus" Command="{Binding FocusCommand}" IsCheckable="False" />
+                                            <MenuItem Header="Native Front &amp; Focus" Command="{Binding FocusNativeCommand}" IsCheckable="False" />
                                             <MenuItem Header="Pattern Actions" ItemsSource="{Binding PlacementTarget.Tag.PatternActionContextItems, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType=ContextMenu}}" Visibility="{Binding PlacementTarget.Tag.PatternActionContextItems.Count, Converter={StaticResource CountToVisibilityConverter}, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType=ContextMenu}}" />
                                             <MenuItem Header="Mouse Actions" ItemsSource="{Binding MouseActions}" />
                                         </ContextMenu>