fix(security): do not enable trust_remote_code from basename registry#1587
Open
Solaris-star wants to merge 1 commit into
Open
fix(security): do not enable trust_remote_code from basename registry#1587Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
from_finetuned used os.path.basename to look up AUTO_EMBEDDER_MAPPING and copied model_config.trust_remote_code when the caller omitted the flag. A colliding local path or Hub repo name could silently execute remote code. Default to False; require an explicit trust_remote_code=True. Fixes FlagOpen#1579
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlagAutoModel.from_finetunedresolved embedder config viaos.path.basename(model_name_or_path)and, whentrust_remote_codewas omitted, copiedmodel_config.trust_remote_codefrom the registry. Entries withtrust_remote_code=Truetherefore enabled custom code for any path/repo whose basename collided with a trusted registry name — without an explicit user opt-in (#1579).Change
trust_remote_code is None, always default toFalseTrue, log a warning telling callers to passtrust_remote_code=Trueexplicitlytrust_remote_code=True/Falsefrom the caller is unchangedTest plan
tests/test_auto_embedder_trust_remote_code.py(2 passed)Fixes #1579