Skip to content

Commit 395c217

Browse files
emyllerclaude
andcommitted
Consolidate engine evaluation logic into Engine class
Co-authored-by: Claude <noreply@anthropic.com>
1 parent a57f402 commit 395c217

8 files changed

Lines changed: 454 additions & 648 deletions

File tree

Flagsmith.Client.Test/MappersTest.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,16 @@ public void MapEnvironmentDocumentToContext_ProducesEvaluationContext()
3434
Assert.Equal(1, apiSegment.Metadata.Id);
3535

3636
// Verify segment rule structure
37-
Assert.Equal(TypeEnum.All, apiSegment.Rules[0].Type);
37+
Assert.Equal(SegmentRuleType.All, apiSegment.Rules[0].Type);
3838
Assert.Empty(apiSegment.Rules[0].Conditions);
3939
Assert.Single(apiSegment.Rules[0].Rules);
4040

41-
Assert.Equal(TypeEnum.All, apiSegment.Rules[0].Rules[0].Type);
41+
Assert.Equal(SegmentRuleType.All, apiSegment.Rules[0].Rules[0].Type);
4242
Assert.Single(apiSegment.Rules[0].Rules[0].Conditions);
4343
Assert.Empty(apiSegment.Rules[0].Rules[0].Rules);
4444

4545
Assert.Equal("foo", apiSegment.Rules[0].Rules[0].Conditions[0].Property);
46-
Assert.Equal(Operator.Equal, apiSegment.Rules[0].Rules[0].Conditions[0].Operator);
46+
Assert.Equal(SegmentConditionOperator.Equal, apiSegment.Rules[0].Rules[0].Conditions[0].Operator);
4747
Assert.Equal("bar", apiSegment.Rules[0].Rules[0].Conditions[0].Value.String);
4848

4949
// Verify identity override segment
@@ -55,19 +55,19 @@ public void MapEnvironmentDocumentToContext_ProducesEvaluationContext()
5555
Assert.Single(overrideSegment.Rules);
5656
Assert.Single(overrideSegment.Overrides);
5757

58-
Assert.Equal(TypeEnum.All, overrideSegment.Rules[0].Type);
58+
Assert.Equal(SegmentRuleType.All, overrideSegment.Rules[0].Type);
5959
Assert.Single(overrideSegment.Rules[0].Conditions);
6060
Assert.Empty(overrideSegment.Rules[0].Rules);
6161

6262
Assert.Equal("$.identity.identifier", overrideSegment.Rules[0].Conditions[0].Property);
63-
Assert.Equal(Operator.In, overrideSegment.Rules[0].Conditions[0].Operator);
63+
Assert.Equal(SegmentConditionOperator.In, overrideSegment.Rules[0].Conditions[0].Operator);
6464
Assert.Equal(new[] { "overridden-id" }, overrideSegment.Rules[0].Conditions[0].Value.StringArray);
6565

6666
Assert.Equal("", overrideSegment.Overrides[0].Key);
6767
Assert.Equal("some_feature", overrideSegment.Overrides[0].Name);
6868
Assert.False(overrideSegment.Overrides[0].Enabled);
6969
Assert.Equal("some-overridden-value", overrideSegment.Overrides[0].Value);
70-
Assert.Equal(Constants.StrongestPriority, overrideSegment.Overrides[0].Priority);
70+
Assert.Equal(Engine.StrongestPriority, overrideSegment.Overrides[0].Priority);
7171
Assert.Null(overrideSegment.Overrides[0].Variants);
7272
Assert.Equal(1, overrideSegment.Overrides[0].Metadata.Id);
7373

0 commit comments

Comments
 (0)