support JSON-encoded IN condition values

Author: khvn26

flag_engine/context/mappers.py

@@ -1,3 +1,4 @@
+import json
 import typing
 from collections import defaultdict
 
@@ -122,7 +123,7 @@ def _map_identity_overrides_to_segment_contexts(
                         {
                             "property": "$.identity.identifier",
                             "operator": "IN",
-                            "value": ",".join(identifiers),
+                            "value": json.dumps(identifiers),
                         }
                     ],
                 }

flag_engine/segments/evaluator.py

@@ -1,3 +1,4 @@
+import json
 import operator
 import re
 import typing
@@ -322,12 +323,22 @@ def _evaluate_in(
     segment_value: typing.Optional[str], context_value: ContextValue
 ) -> bool:
     if segment_value:
-        if isinstance(context_value, str):
-            return context_value in segment_value.split(",")
+        try:
+            in_values = json.loads(segment_value)
+            # Only accept JSON lists.
+            # Ideally, we should use something like pydantic.TypeAdapter[list[str]],
+            # but we aim to ditch the pydantic dependency in the future.
+            if not isinstance(in_values, list):
+                raise ValueError
+            in_values = [str(value) for value in in_values]
+        except ValueError:
+            in_values = segment_value.split(",")
+        # Guard against comparing boolean values to numeric strings.
         if isinstance(context_value, int) and not any(
             context_value is x for x in (False, True)
         ):
-            return str(context_value) in segment_value.split(",")
+            context_value = str(context_value)
+        return context_value in in_values
     return False
 
 

tests/unit/segments/test_segments_evaluator.py

@@ -480,6 +480,26 @@ def test_context_in_segment_is_set_and_is_not_set(
         (constants.IN, 1, "1", True),
         (constants.IN, 1, None, False),
         (constants.IN, 1, None, False),
+        (constants.IN, "foo", "", False),
+        (constants.IN, "foo", "foo,bar", True),
+        (constants.IN, "bar", "foo,bar", True),
+        (constants.IN, "foo", "foo", True),
+        (constants.IN, 1, "1,2,3,4", True),
+        (constants.IN, 1, "", False),
+        (constants.IN, 1, "1", True),
+        (constants.IN, 1, None, False),
+        (constants.IN, 1, None, False),
+        (constants.IN, "foo", "[]", False),
+        (constants.IN, "foo", '["foo","bar"]', True),
+        (constants.IN, "bar", '["foo","bar"]', True),
+        (constants.IN, "foo", '["foo"]', True),
+        (constants.IN, 1, "[1,2,3,4]", True),
+        (constants.IN, 1, '["1","2","3","4"]', True),
+        (constants.IN, 1, "[]", False),
+        (constants.IN, 1, "[1]", True),
+        (constants.IN, 1, '["1"]', True),
+        (constants.IN, 1, None, False),
+        (constants.IN, 1, None, False),
     ),
 )
 def test_segment_condition_matches_context_value(