chore: add sane model defaults to OrganisationModel and ProjectModel#213
Merged
matthewelwell merged 3 commits intomainfrom Jun 25, 2025
Merged
chore: add sane model defaults to OrganisationModel and ProjectModel#213matthewelwell merged 3 commits intomainfrom
matthewelwell merged 3 commits intomainfrom
Conversation
matthewelwell
requested review from
a team and
khvn26
and removed request for
a team
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 30441d9 |
# Conflicts: # .github/workflows/pull-request.yml
khvn26
approved these changes
Jun 25, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
Have we got an OfflineHandler implementation example somewhere? Curious to see the impact of this (and whether we can make further improvements).
Contributor
Author
@khvn26 the only one that I'm using as a reference is the one in the PR here (which wasn't really ready for review yet, but I appreciate the feedback!) I think these changes are useful, if incomplete, regardless of the comments on the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds defaults to attributes in the OrganisationModel and ProjectModel classes which have defaults in the django ORM models.
Adding these should simplify interfaces when creating custom offline handlers for example.