Skip to content

feat(v7)!: Remove deprecated APIs, Pydantic models#250

Merged
khvn26 merged 11 commits intomainfrom
feat/drop-pydantic-models
Sep 1, 2025
Merged

feat(v7)!: Remove deprecated APIs, Pydantic models#250
khvn26 merged 11 commits intomainfrom
feat/drop-pydantic-models

Conversation

@khvn26
Copy link
Copy Markdown
Member

@khvn26 khvn26 commented Aug 21, 2025

In this PR, we remove deprecated interfaces:

  • get_identity_feature_state
  • get_identity_feature_states
  • get_identity_segments
  • get_context_segments
  • get_environment_feature_state
  • get_environment_feature_states
    and all the Pydantic models representing the Core API entities.

Only get_evaluation_result, along with EvaluationContext and EvaluationResult types, are now exported by the engine.

The following functionality isn't managed by the engine anymore:

  • Sorting the multivariate feature states by id – variants are expected to be pre-sorted.
  • Filtering resulting flags based on project/environment hide_disabled_flags attributes.
  • Mapping Core API entities to engine typed dicts, and vice versa — there is, however, adapting code to map engine-test-data to evaluation contexts.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 21, 2025

File Coverage Missing
All files 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 988984f

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Aug 21, 2025

CodSpeed Performance Report

Merging #250 will not alter performance

Comparing feat/drop-pydantic-models (988984f) with main (f99fa99)

Summary

✅ 1 untouched benchmarks

@khvn26 khvn26 requested review from a team and gagantrivedi and removed request for a team August 21, 2025 19:05
@khvn26 khvn26 force-pushed the feat/drop-pydantic-models branch from 40c3adc to 1eaca0a Compare August 25, 2025 12:51
@khvn26 khvn26 changed the title feat!: Remove deprecated APIs, Pydantic models feat(v7)!: Remove deprecated APIs, Pydantic models Aug 25, 2025
@khvn26 khvn26 force-pushed the feat/drop-pydantic-models branch from 1eaca0a to 9ab732a Compare August 26, 2025 09:58
Copy link
Copy Markdown
Member

@gagantrivedi gagantrivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one minor question/comment

emyller
emyller previously approved these changes Aug 28, 2025
Copy link
Copy Markdown
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with minor optional comments.

Copy link
Copy Markdown
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@khvn26 khvn26 enabled auto-merge (squash) September 1, 2025 14:25
@khvn26 khvn26 dismissed gagantrivedi’s stale review September 1, 2025 14:26

Gagan is OOO and the only outstanding thread was resolved.

@khvn26 khvn26 merged commit 92de872 into main Sep 1, 2025
7 checks passed
@khvn26 khvn26 deleted the feat/drop-pydantic-models branch September 1, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants