feat: Support returning default flags for None identities#254
Merged
Conversation
khvn26
requested review from
a team and
emyller
and removed request for
a team
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1cf3760 |
CodSpeed Performance ReportMerging #254 will not alter performanceComparing Summary
|
matthewelwell
approved these changes
Aug 25, 2025
khvn26
deleted the
feat/support-null-identifiers-returning-default-flags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deemed opening this PR necessary to support the Python SDK's local evaluation mode, specifically
Flagsmith._get_environment_flags_from_documentengine wrapper method.This PR adds support for contexts with segments that don't target identities, but still use Context values that can be extracted from an identity-less evaluation context, like Environment names.