Skip to content

fix: PERCENTAGE_SPLIT working for undefined keys#256

Merged
khvn26 merged 7 commits intomainfrom
fix/percentage-split-enabled-for-undefined-keys
Sep 11, 2025
Merged

fix: PERCENTAGE_SPLIT working for undefined keys#256
khvn26 merged 7 commits intomainfrom
fix/percentage-split-enabled-for-undefined-keys

Conversation

@khvn26
Copy link
Copy Markdown
Member

@khvn26 khvn26 commented Sep 11, 2025

In this PR, we:

  • Exclude evaluation contexts lacking identity from PERCENTAGE_SPLIT rule evaluations.
  • Make sure the engine doesn't crash when a PERCENTAGE_SPLIT condition holds a non-numeric property.
  • Delegate linting to pre-commit.ci.

@khvn26 khvn26 requested a review from a team as a code owner September 11, 2025 09:24
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team September 11, 2025 09:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 11, 2025

File Coverage Missing
All files 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against f5fd2e9

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Sep 11, 2025

CodSpeed Performance Report

Merging #256 will improve performances by 18.47%

Comparing fix/percentage-split-enabled-for-undefined-keys (f5fd2e9) with main (c58dc38)

Summary

⚡ 1 improvement

Benchmarks breakdown

Benchmark BASE HEAD Change
test_engine_benchmark 18 ms 15.2 ms +18.47%

@Flagsmith Flagsmith deleted a comment from github-actions bot Sep 11, 2025
Copy link
Copy Markdown
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khvn26 khvn26 merged commit fa37c6c into main Sep 11, 2025
9 checks passed
@khvn26 khvn26 deleted the fix/percentage-split-enabled-for-undefined-keys branch September 11, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants