Merge pull request #71 from Flagsmith/fix/custom-storage

fix: Fix custom storage

Author: rolodato

lib/src/flagsmith_client.dart

@@ -166,7 +166,10 @@ class FlagsmithClient {
     } else {
       switch (config.storageType) {
         case StorageType.custom:
-          store = storage!;
+          if (storage == null) {
+            throw FlagsmithConfigException(Exception('When using StorageType.custom, a storage implementation must be provided'));
+          }
+          store = storage;
           break;
         default:
           store = InMemoryStorage();
@@ -181,7 +184,6 @@ class FlagsmithClient {
   ///
   ///
   Future<void> initialize() async {
-    storageProvider = prepareStorage(storage: storage, config: config);
     await initStore(seeds: seeds);
   }
 
@@ -198,7 +200,8 @@ class FlagsmithClient {
       config: config,
       apiKey: apiKey,
       seeds: seeds,
-    )..storageProvider = prepareStorage(storage: storage, config: config);
+      storage: storage,
+    );
     await client.initStore(seeds: seeds);
     return client;
   }

test/fg/flagsmith_custom_storage_test.dart

@@ -0,0 +1,58 @@
+import 'package:flagsmith/flagsmith.dart';
+import 'package:test/test.dart';
+import '../shared.dart';
+
+class TestStorage extends InMemoryStorage {
+  bool initCalled = false;
+
+  @override
+  Future<void> init() async {
+    initCalled = true;
+    return Future.value();
+  }
+}
+
+void main() {
+  group('FlagsmithClient with custom storage', () {
+    test('Should initialize with custom storage', () async {
+      final customStorage = TestStorage();
+
+      // Initialize the client with custom storage
+      final client = await FlagsmithClient.init(
+        apiKey: apiKey,
+        config: const FlagsmithConfig(
+          storageType: StorageType.custom,
+          isDebug: true,
+        ),
+        storage: customStorage,
+        seeds: <Flag>[
+          Flag.seed('feature', enabled: true),
+        ],
+      );
+
+      // Verify the client was initialized successfully
+      expect(client, isA<FlagsmithClient>());
+      expect(customStorage.initCalled, isTrue);
+
+      // Clean up
+      client.close();
+    });
+
+    test('Should throw error when StorageType.custom is used without providing storage', () async {
+      expect(
+        () => FlagsmithClient.init(
+          apiKey: apiKey,
+          config: const FlagsmithConfig(
+            storageType: StorageType.custom,
+            isDebug: true,
+          ),
+          seeds: <Flag>[
+            Flag.seed('feature', enabled: true),
+          ],
+        ),
+        throwsA(isA<FlagsmithConfigException>()),
+      );
+    });
+
+  });
+}