Skip to content

feat: Make most Feature fields optional #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolodato merged 1 commit into from
Jul 8, 2025
Merged

feat: Make most Feature fields optional #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions FlagsmithClient/src/main/java/com/flagsmith/entities/Flag.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ data class Flag(
)

data class Feature(
val id: Long,
val name: String,
@SerializedName(value = "created_date") val createdDate: String,
val description: String,
@SerializedName(value = "initial_value") val initialValue: String,
@SerializedName(value = "default_enabled") val defaultEnabled: Boolean,
val type: String
val id: Long = 0L,
@SerializedName(value = "created_date") val createdDate: String = "",
val description: String = "",
@SerializedName(value = "initial_value") val initialValue: String = "",
@SerializedName(value = "default_enabled") val defaultEnabled: Boolean = false,
val type: String = ""
)
26 changes: 7 additions & 19 deletions FlagsmithClient/src/test/java/com/flagsmith/FeatureFlagCachingTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,26 +51,14 @@ class FeatureFlagCachingTests {
setupMocks()
val defaultFlags = listOf(
Flag(
feature = Feature(
id = 345345L,
name = "Flag 1",
createdDate = "2023‐07‐07T09:07:16Z",
description = "Flag 1 description",
type = "CONFIG",
defaultEnabled = true,
initialValue = "true"
), enabled = true, featureStateValue = "Vanilla Ice"
feature = Feature(name = "Flag 1"),
enabled = true,
featureStateValue = "Vanilla Ice"
),
Flag(
feature = Feature(
id = 34345L,
name = "Flag 2",
createdDate = "2023‐07‐07T09:07:16Z",
description = "Flag 2 description",
type = "CONFIG",
defaultEnabled = true,
initialValue = "true"
), enabled = true, featureStateValue = "value2"
feature = Feature(name = "Flag 2"),
enabled = true,
featureStateValue = "value2"
),
)

Expand Down Expand Up @@ -380,4 +368,4 @@ class FeatureFlagCachingTests {
await untilTrue(hasFinishedGetRequest)
Assert.assertNull("Shouldn't get any data back as we don't have a cache", foundFromCache)
}
}
}