Skip to content

Commit 10621ad

Browse files
committed
feat: fix-get-identity-segments-returning-identity-overrides
1 parent 45c4594 commit 10621ad

4 files changed

Lines changed: 9 additions & 5 deletions

File tree

flagsmith-engine/evaluation/evaluationContext/mappers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ function mapIdentityOverridesToSegments(identityOverrides: IdentityModel[]): Seg
151151

152152
featuresToIdentifiers.get(overridesHash)!.identifiers.push(identity.identifier);
153153
}
154+
154155
for (const [overrideHash, { identifiers, overrides }] of featuresToIdentifiers.entries()) {
155156
const segmentKey = `identity_override_${overrideHash}`;
156157

@@ -164,7 +165,6 @@ function mapIdentityOverridesToSegments(identityOverrides: IdentityModel[]): Seg
164165
{
165166
property: '$.identity.identifier',
166167
operator: 'IN',
167-
// TODO: Modify once new IN operator is implemented
168168
value: identifiers.join(',')
169169
}
170170
]

flagsmith-engine/evaluation/models.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,5 +68,5 @@ export type EvaluationResult = {
6868
segments: EvaluationResultSegments;
6969
};
7070

71-
export type { FlagResult } from './evaluationResult/evaluationResult.types.js';
72-
export type * from './evaluationContext/evaluationContext.types.js';
71+
export { FlagResult } from './evaluationResult/evaluationResult.types.js';
72+
export * from './evaluationContext/evaluationContext.types.js';

flagsmith-engine/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ export { EnvironmentModel } from './environments/models.js';
77
export { IdentityModel } from './identities/models.js';
88
export { TraitModel } from './identities/traits/models.js';
99
export { SegmentModel } from './segments/models.js';
10-
10+
export { FeatureModel, FeatureStateModel } from './features/models.js';
11+
export { OrganisationModel } from './organisations/models.js';
1112
type SegmentOverride = {
1213
feature: FeatureContext;
1314
segmentName: string;

flagsmith-engine/segments/models.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,10 @@ export class SegmentModel {
223223
segment.featureStates = SegmentModel.createFeatureStatesFromOverrides(
224224
segmentContext.overrides || []
225225
);
226-
segmentModels.push(segment);
226+
227+
if (!isNaN(segment.id)) {
228+
segmentModels.push(segment);
229+
}
227230
}
228231
}
229232

0 commit comments

Comments
 (0)